From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752125AbdHIJzk (ORCPT <rfc822;w@1wt.eu>);
        Wed, 9 Aug 2017 05:55:40 -0400
Received: from mx2.suse.de ([195.135.220.15]:33072 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751443AbdHIJzj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 9 Aug 2017 05:55:39 -0400
Subject: Re: [PATCH v4 1/2] x86/unwind: add ORC unwinder
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andy Lutomirski <luto@kernel.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "live-patching@vger.kernel.org" <live-patching@vger.kernel.org>,
        Jiri Slaby <jslaby@suse.cz>, Ingo Molnar <mingo@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Mike Galbraith <efault@gmx.de>
References: <20170728185720.fwczcezbkrlxmwqb@treble>
 <20170728195912.panyn4p6e6ovueey@sasha-lappy>
 <20170729035437.fmnxmeedrq55bpwm@treble>
 <20170808185809.qaug762cj7nw3bcd@treble>
 <CA+55aFz+4WkCA1wQBB6dtttWWEgB+FiVDAp1mY1b=UPnjd0ZKQ@mail.gmail.com>
 <20170808191344.kw5nlicmq4g6fpii@treble>
 <CALCETrX=JcvLEzjj2kc2uron+sRF4FJMfDAKcEp4du3z2T80qg@mail.gmail.com>
 <79d6e04a-0a1d-592d-5e35-e4d6e7c7526b@suse.com>
 <20170809091648.p57ircm64t63mejj@hirez.programming.kicks-ass.net>
 <29fcd05f-3a0d-c20e-f20a-ee2019eea73c@suse.com>
 <20170809093511.oorxaiau5dtgfjxr@hirez.programming.kicks-ass.net>
From: Juergen Gross <jgross@suse.com>
Message-ID: <c04ecd71-a7d5-9adb-e306-35ea474e6fe1@suse.com>
Date: Wed, 9 Aug 2017 11:55:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170809093511.oorxaiau5dtgfjxr@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/08/17 11:35, Peter Zijlstra wrote:
> On Wed, Aug 09, 2017 at 11:24:07AM +0200, Juergen Gross wrote:
>> On 09/08/17 11:16, Peter Zijlstra wrote:
>>> On Wed, Aug 09, 2017 at 10:49:43AM +0200, Juergen Gross wrote:
>>>>> ALTERNATIVE "pushfq; popq %rax", "callq *pv_irq_ops.save_fl",
>>>>> X86_FEATURE_GODDAMN_PV_IRQ_OPS
>>>>
>>>> You are aware that at least some of the Xen irq pvops functionality is
>>>> patched inline? Your modification would slow down pv guests quite a
>>>> bit, I guess.
>>>
>>> Where does that live? I know of the inline patching for native, but
>>> didn't know the guests did any of that too.
>>
>> See arch/x86/xen/enlighten_pv.c xen_patch().
> 
> 'obvious' name that :-) I see that the actual code that's patched in
> lives in xen-asm.S which unlike the native case doesn't appear to have
> its own section. So that might make things even more difficult.

I don't see why this couldn't be changed.


Juergen