From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEC7D19DFBF for ; Thu, 15 Aug 2024 15:15:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723734941; cv=none; b=nYKsUCtH15Fuv6WfQdsk35FeJAH+ECEKhyyqafzA8iq4nC/aEOwelFqaHTHsw5SHnVICBBfZ14Y/kh8KN6Q+pdwCy5q+xNMaJT8KYdsYr67ifdQbu+7LVv4j9CXcRrg8k0gbbMOCEdmrrQk1xYjcgQZAfarO9u2tToscamlrNs0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723734941; c=relaxed/simple; bh=vE16knDDPEhIOws2TpQRIKWJVED7xSXQPEzP3dgG+vY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aNmGwsQ4/BCnh0O60FCmao++1aPy7LLFlnDcmmZAc1D3PsUTwRX+roaOtnJrNCFnX1esiyhhrNcDtfDJyW49cEzhhqCtZC6nl+f2ZAWQFMaLYeAUhg0wJ061aAhBqrwAQOYkGJ1S6M26ib1AQ/8V5sIDJLJoKtQMxhxEKGvPVOg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=iMWwoxYW; arc=none smtp.client-ip=95.215.58.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="iMWwoxYW" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1723734937; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YYigmxDcwTho9rKIrBqACxBsAtA/H5Uwy4J6Qcv76Sw=; b=iMWwoxYWoxVV3br3wv3lYpuelL+1sxO1ZDaDiSYqRX+AgNekDU7y49SUjwNLmgVQc4K2U7 1rVgBz9Rf3aNzY+1H39r5lpnbUUSj+qqypIC+0Nm1XGG1ns3vRP1YMdrSWUIlu6hmphLWS pkGIS+EulsBWdq3QSDfLkCIdrI4DHQ4= Date: Thu, 15 Aug 2024 11:15:32 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next 3/4] net: xilinx: axienet: Don't print if we go into promiscuous mode To: Simon Horman Cc: Radhey Shyam Pandey , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Lunn , Michal Simek , Daniel Borkmann , Paolo Abeni , "David S. Miller" , Eric Dumazet , linux-arm-kernel@lists.infradead.org, Jakub Kicinski , Ariane Keller References: <20240812200437.3581990-1-sean.anderson@linux.dev> <20240812200437.3581990-4-sean.anderson@linux.dev> <20240815145948.GH632411@kernel.org> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <20240815145948.GH632411@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 8/15/24 10:59, Simon Horman wrote: > On Mon, Aug 12, 2024 at 04:04:36PM -0400, Sean Anderson wrote: >> A message about being in promiscuous mode is printed every time each >> additional multicast address beyond four is added. Suppress this message >> like is done in other drivers. And don't set IFF_PROMISC in ndev->flags; >> contrary to the comment we don't have to inform the net subsystem. > > Hi Sean, > > FWIIW, this feels like two things that could be two patches. > > ... OK