From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9D13C3A5A3 for ; Tue, 27 Aug 2019 14:05:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4FB0214DA for ; Tue, 27 Aug 2019 14:05:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729726AbfH0OFE (ORCPT ); Tue, 27 Aug 2019 10:05:04 -0400 Received: from mga09.intel.com ([134.134.136.24]:30685 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726134AbfH0OFE (ORCPT ); Tue, 27 Aug 2019 10:05:04 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Aug 2019 07:05:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,437,1559545200"; d="scan'208";a="197314678" Received: from linux.intel.com ([10.54.29.200]) by fmsmga001.fm.intel.com with ESMTP; 27 Aug 2019 07:05:01 -0700 Received: from [10.255.129.116] (unknown [10.255.129.116]) by linux.intel.com (Postfix) with ESMTP id 13641580375; Tue, 27 Aug 2019 07:04:56 -0700 (PDT) Subject: Re: [PATCH v2 1/2] dt-bindings: reset: Add YAML schemas for the Intel Reset controller To: Rob Herring Cc: Philipp Zabel , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , cheol.yong.kim@intel.com, chuanhua.lei@linux.intel.com, qi-ming.wu@intel.com References: <42039170811f798b8edc66bf85166aefe7dbc903.1566531960.git.eswara.kota@linux.intel.com> <746ed130-a1ae-0cc2-5060-70de95cdf2fe@linux.intel.com> From: Dilip Kota Message-ID: Date: Tue, 27 Aug 2019 22:04:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On 8/26/2019 7:23 PM, Rob Herring wrote: > On Mon, Aug 26, 2019 at 4:52 AM Dilip Kota wrote: >> Hi Rob, >> >> On 8/23/2019 8:25 PM, Rob Herring wrote: >>> On Fri, Aug 23, 2019 at 12:28 AM Dilip Kota wrote: >>>> Add YAML schemas for the reset controller on Intel >>>> Lightening Mountain (LGM) SoC. >>>> >>>> Signed-off-by: Dilip Kota >>>> --- >>>> Changes on v2: >>>> Address review comments >>>> Update the compatible property definition >>>> Add description for reset-cells >>>> Add 'additionalProperties: false' property >>>> >>>> .../bindings/reset/intel,syscon-reset.yaml | 53 ++++++++++++++++++++++ >>>> 1 file changed, 53 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/reset/intel,syscon-reset.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/reset/intel,syscon-reset.yaml b/Documentation/devicetree/bindings/reset/intel,syscon-reset.yaml >>>> new file mode 100644 >>>> index 000000000000..3403a967190a >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/reset/intel,syscon-reset.yaml >>>> @@ -0,0 +1,53 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/reset/intel,syscon-reset.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Intel Lightening Mountain SoC System Reset Controller >>>> + >>>> +maintainers: >>>> + - Dilip Kota >>>> + >>>> +properties: >>>> + compatible: >>>> + items: >>>> + - const: intel,rcu-lgm >>>> + - const: syscon >>>> + >>>> + reg: >>>> + description: Reset controller register base address and size >>>> + >>>> + intel,global-reset: >>>> + $ref: /schemas/types.yaml#/definitions/uint32-array >>>> + description: Global reset register offset and bit offset. >>>> + >>>> + "#reset-cells": >>>> + const: 2 >>>> + description: | >>>> + The 1st cell is the register offset. >>>> + The 2nd cell is the bit offset in the register. >>>> + >>>> +required: >>>> + - compatible >>>> + - reg >>>> + - intel,global-reset >>>> + - "#reset-cells" >>>> + >>>> +additionalProperties: false >>>> + >>>> +examples: >>>> + - | >>>> + rcu0: reset-controller@00000000 { >>>> + compatible = "intel,rcu-lgm", "syscon"; >>>> + reg = <0x000000 0x80000>; >>>> + intel,global-reset = <0x10 30>; >>>> + #reset-cells = <2>; >>>> + }; >>>> + >>>> + pcie_phy0: pciephy@... { >>>> + ... >>> You need to run 'make dt_binding_check' and fix the warnings. The >>> example has to be buildable and it is not. >> Sure, i will correct this pcie_phy0 node. But i didn't get any warnings >> for make dt_binding_check >> >> CHKDT Documentation/devicetree/bindings/reset/intel,syscon-reset.yaml >> DTC Documentation/devicetree/bindings/arm/renesas.example.dt.yaml >> FATAL ERROR: Unknown output format "yaml" >> >> Will DTC report about the example node errors? But, DTC is failing with >> FATAL_ERROR. >> I tried it even after installing libyaml and headers in my local >> directory and export the path, but no luck.(ref: >> https://lkml.org/lkml/2018/12/3/951) >> Could you please let me know if i miss anything and help me to proceed >> further. > See Documentation/devicetree/writing-schema.md I have followed all the steps mentioned in the document before keeping the mail itself. Does the dtc script looks for libyaml and its header files at any default or specific location? Regards, Dilip > > Rob