From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A2E73546D0 for ; Tue, 19 May 2026 15:55:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779206112; cv=none; b=UqBQLXykM30iDkj6Jlg/NaOUoqblU3eXcF77RYdCxyfByly3FnNOR5vfTfq+M7eGor7fIgkcjTXhhM/3NM6W2szjtM0yzJC4f06NYFk1rFhVzQwHiz3HBGbuxeDyhMpc5h3JDtGJnEdbL7AaJEtchWzOKEM222h3UvCFlspJZ/Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779206112; c=relaxed/simple; bh=py1MRqKn7exNdjXsmsX1yh47Z7tsmCUTS6qgb/gwScY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tfY32rOE8cZ9Z7QhNZ4306+fItvHSmPo7ip36iSdvxrQCGE8/hllEG3k4GBfPpi4L6IfUTFloLG1O6njCoEpuUU+m4NPWgWcIAvtBYSOBK3ZNQB/fSw+k6VDFiEr7qyR6g8X4PZB5/Uj8sBtHM92Y1dV950IWOaRLiO3VVhLfiw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=g6mbDe4c; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=BRC8Ur9P; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="g6mbDe4c"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="BRC8Ur9P" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779206108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9ShAj6l51xuzBF/j17UKisc3z8T5wY7lSXY12qKT0nQ=; b=g6mbDe4cENcbyfFXP8976XBJV/xZ7y4rb8TS/hjALfKKHItgR8miRqDZmajyosBiiq8ICV xHwwbA2H3NPoytjWM2gCUSOl6XrMyxbmit2Bfuf4sYPB30OHR3pTu+j+zf0JszPB7KZkGd uAiNhm/0PTx6jhQRLs8Bbq6L3FJtF4A= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-398-TkcDxeZbP_2bGcHbedOZGw-1; Tue, 19 May 2026 10:08:44 -0400 X-MC-Unique: TkcDxeZbP_2bGcHbedOZGw-1 X-Mimecast-MFC-AGG-ID: TkcDxeZbP_2bGcHbedOZGw_1779199723 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-45e73a4f1dfso2272553f8f.0 for ; Tue, 19 May 2026 07:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779199723; x=1779804523; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9ShAj6l51xuzBF/j17UKisc3z8T5wY7lSXY12qKT0nQ=; b=BRC8Ur9Pe6V8siEVZXvjQ4vQL/dOC7tOrTJVQO4KlIAJGjCSqmNKiuq0WqYYb75s9e 5YGxcmggdQw2MnMThPhCaDTB7oAfDMafrXc83MAhMa8XvCBIW8LAJhgnVAO+UCDrIKwl DYfSQvQo1lZJCfOrABPbMrMmEmhxfsSKOpRodnWeK5GyYPIvGWW9VtGc//IG517niLBX izknrQRhMAEtj2ZmoQJNItwF1B9mbvwfBOlyT2EUPUuiWfduMnSoqDe6BIiRVFq13kJ/ I4yrK7HeJAd8nBWD127GBSR0o+MavsTji0Lc7uWImQ8WHA8XlIUTmYZKiu4GuTqHdbMF 8TUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779199723; x=1779804523; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9ShAj6l51xuzBF/j17UKisc3z8T5wY7lSXY12qKT0nQ=; b=Qlv9SHafBzpkMa3WzJDSwJU/2StzqyQz1PNqn73VddhIK2SzTOS/vrlMTzmpV720SZ C1Ic7uj1uHvNmTmjSLx/1R9cgswhEFxdj1mf4tGa9fC+38QoGK9sf4eC2z5g+a9120Vm DRGvIaK2YUBAU02yBfOpfLiBO3K0ObwjKik9WrZWw7fsPjYjKdW52cBVVmTiEASfoqtV HgfXfp4C0aet6+1yX+ab+4a31WDHQFOXUEKip7vQOKJJX1+N9UUt2hKvh+3O0xeqeD/W +5TEb4gwWDKLQ0BuXHqEXMSe2mQi+u4PzXYzgxI8eyfsSzeAXmQIqUZ6IwXj6Bg7YOdz ihaA== X-Forwarded-Encrypted: i=1; AFNElJ9hy8qG4P7VwvraGr7FXNRdorw+fSRAqGxZZCneYuOdTbRoXN5qpn5unD4yawJGBLKnT8d/cHd3H5NIXFY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/oFwAwD6SCAPc/FoG6mi6SKrHp0Ccs6/sPGJB+GrwEojjDBFR 2s8/vED1tuwIe1cZCgEmfHPmrWYLR+2aQHenYwlIkc1jPiERzO8WaOQU7DX4W7nHcolRMM6E2V7 fSNEl+c93xvqxxQvZxrrhYebNzpmHRMiJHFxM5i3MvANxwHKu9VLkU3L8QpMyX5y60Q== X-Gm-Gg: Acq92OHAxH7GnBEsrovcD62rmRxMvTKkFBYJaMQOAGBY/54pibVWRye5ng5TU2PtYGx SZOYzUlUcabNuc5mSqdLsnSwzE0XD7LDZiUblfo9Snwc89wto9qu+CKEd2/++BK9u0SJ0HsKu7J ZbT2A0GHYefHyGMj2RVTyfBjlvYzWO3yepdRdsDmjlwFdtHUJMFdxPDV/WHyTrOzj3XHm675yBL yJiAWTGz8Pbwkmc/sTCCJvMWrv1n86i2jN3fUMThG/pJKXHhl5ILw4F9NQAYOddUOLCvF+hcbRU LCavUPRBrvv/2FQJd3nQ87PVWfk6UERwtV2tNLR/sJhj0Z4/Bp+kYLEUBBH4QnJdpY2pSQzncDo 8mLU56ZmWO+pmomZZpGkLCgsCMPba4nZ60n1phU0S+qY8uiWSlEcMfl1rl2Rpr1+htw== X-Received: by 2002:a05:600c:5304:b0:490:17da:27f8 with SMTP id 5b1f17b1804b1-49017da2830mr97673585e9.18.1779199722794; Tue, 19 May 2026 07:08:42 -0700 (PDT) X-Received: by 2002:a05:600c:5304:b0:490:17da:27f8 with SMTP id 5b1f17b1804b1-49017da2830mr97672985e9.18.1779199722357; Tue, 19 May 2026 07:08:42 -0700 (PDT) Received: from [192.168.88.32] ([150.228.25.33]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48febe5bc94sm204874615e9.4.2026.05.19.07.08.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2026 07:08:41 -0700 (PDT) Message-ID: Date: Tue, 19 May 2026 16:08:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 7/7] tipc: convert to getsockopt_iter To: Breno Leitao , Chas Williams <3chas3@gmail.com>, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , Magnus Karlsson , Maciej Fijalkowski , Stanislav Fomichev , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Jon Maloy , Alexandra Winter , Thorsten Winkler , James Chapman , David Howells , Marc Dionne , David Heidelberg , Samuel Ortiz Cc: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-s390@vger.kernel.org, linux-afs@lists.infradead.org, oe-linux-nfc@lists.linux.dev, kernel-team@meta.com References: <20260515-getsock_four-v2-0-0d8eed952627@debian.org> <20260515-getsock_four-v2-7-0d8eed952627@debian.org> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260515-getsock_four-v2-7-0d8eed952627@debian.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/15/26 10:32 AM, Breno Leitao wrote: > @@ -3260,7 +3260,6 @@ static int tipc_getsockopt(struct socket *sock, int lvl, int opt, > break; > case TIPC_CONN_TIMEOUT: > value = tsk->conn_timeout; > - /* no need to set "res", since already 0 at this point */ Since you have to repost, there is another obsoleted comment referring to "res" later on: return res; /* "get" failed */ please strip it, too. /P