From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.forwardemail.net (smtp.forwardemail.net [121.127.44.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2539D52F66 for ; Sun, 17 Aug 2025 16:46:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=121.127.44.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755449211; cv=none; b=P0qxeciE6hYmR8SWAvse9ShdlGjNyhZqezmjqFBsydb7PJi5Cg8n+K4MSUmOA8AKBKjEwVVkwGoryjv/f4ivIctm/weP8TfEQncM5RgglgoKMJPyQGKGJkS9RmWZthygEyoW77OTLPfs6NFgmjRmFGsUuyi87+Idlgseyl3SRj4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755449211; c=relaxed/simple; bh=wemZUqS+A99/VxPlNDzmg1mhu/qnaB75Q4d073x9468=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PC98QmjAk7NX6nSmYf0wnJ5nkZZ048utM3NyzBWqUsM6nY84sroJ5UIj2As4iGvI+aJG3R7GFY2d5xlEcA5L1d8xtv1qn8W779W4jkm7of5l5DVud6vekhFprNgLxih2ZLFy6MOe3H0sLGNdsAPjk54zMMOFfbMM5//AJxuDbwM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kwiboo.se; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b=Sayp2sr7; arc=none smtp.client-ip=121.127.44.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kwiboo.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b="Sayp2sr7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: From: References: Cc: To: Subject: MIME-Version: Date: Message-ID; q=dns/txt; s=fe-e1b5cab7be; t=1755449208; bh=V0JgX9niK/jrh4YSavrLzHuTfEZE1FFWTu/eobrzLTk=; b=Sayp2sr7ACsvw8CnhuK71MfnNoHK2w+HgeroUX5Ju0r3GJOeJuvTaMXKKwlmAVn8KpZGj7UW3 16Z5OlXdI8IwdGtKIAGa55m5KdzT5e0rQ7oZa4FXOHzHG2/6NE5poOKka7cI7QBoneXwgwp2pZs 9JENLeiqsYBJMGw9DLrUT7dnEwlBvk8sl4MfhwwDiz6tb1bOsUQAxW0whXjHidN2PikmTtD4IY/ sMSmZLKaWmtYBSWOizv7RGyiioHfqeb8C0qG+A6mEgOi1c4ROslVwzaJXRbcU70fO0Qko8ocyde HP0LvHPth28vIbZdCOk6FnWD2bBytuRM39Aqvenf+LaQ== X-Forward-Email-ID: 68a207649a82a81f459cfa06 X-Forward-Email-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 121.127.44.73 X-Forward-Email-Version: 1.2.4 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net Message-ID: Date: Sun, 17 Aug 2025 18:46:24 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/7] media: rkvdec: Add HEVC backend To: Detlev Casanova Cc: Ezequiel Garcia , Mauro Carvalho Chehab , Heiko Stuebner , Alex Bee , Nicolas Dufresne , Sebastian Fricke , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250810212454.3237486-1-jonas@kwiboo.se> <20250810212454.3237486-2-jonas@kwiboo.se> <22971824.EfDdHjke4D@earth> Content-Language: en-US From: Jonas Karlman In-Reply-To: <22971824.EfDdHjke4D@earth> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Detlev, On 8/12/2025 10:10 PM, Detlev Casanova wrote: > Hi Jonas, > > On Sunday, 10 August 2025 17:24:31 EDT Jonas Karlman wrote: >> The Rockchip VDEC supports the HEVC codec with the Main and Main10 >> Profile up to Level 5.1 High tier: 4096x2304@60 fps. >> >> Add the backend for HEVC format to the decoder. >> >> Signed-off-by: Alex Bee >> Signed-off-by: Nicolas Dufresne >> Signed-off-by: Sebastian Fricke >> Signed-off-by: Jonas Karlman >> --- >> Changes in v2: >> - Use new_value in transpose_and_flatten_matrices() >> - Add NULL check for ctrl->new_elems in rkvdec_hevc_run_preamble() >> - Set RKVDEC_WR_DDR_ALIGN_EN for RK3328 >> --- >> .../media/platform/rockchip/rkvdec/Makefile | 2 +- >> .../rockchip/rkvdec/rkvdec-hevc-data.c | 1848 +++++++++++++++++ >> .../platform/rockchip/rkvdec/rkvdec-hevc.c | 817 ++++++++ >> .../platform/rockchip/rkvdec/rkvdec-regs.h | 2 + >> .../media/platform/rockchip/rkvdec/rkvdec.c | 76 + >> .../media/platform/rockchip/rkvdec/rkvdec.h | 1 + >> 6 files changed, 2745 insertions(+), 1 deletion(-) >> create mode 100644 >> drivers/media/platform/rockchip/rkvdec/rkvdec-hevc-data.c create mode >> 100644 drivers/media/platform/rockchip/rkvdec/rkvdec-hevc.c >> > > [snip] > >> diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec-hevc.c >> b/drivers/media/platform/rockchip/rkvdec/rkvdec-hevc.c new file mode 100644 >> index 000000000000..1994ea24f0be >> --- /dev/null >> +++ b/drivers/media/platform/rockchip/rkvdec/rkvdec-hevc.c > > [snip] > >> + >> +static enum rkvdec_image_fmt rkvdec_hevc_get_image_fmt(struct rkvdec_ctx >> *ctx, + struct > v4l2_ctrl *ctrl) >> +{ >> + const struct v4l2_ctrl_hevc_sps *sps = ctrl->p_new.p_hevc_sps; >> + >> + if (ctrl->id != V4L2_CID_STATELESS_HEVC_SPS) >> + return RKVDEC_IMG_FMT_ANY; >> + >> + if (sps->bit_depth_luma_minus8 == 0) { >> + if (sps->chroma_format_idc == 2) >> + return RKVDEC_IMG_FMT_422_8BIT; > > Is 4:2:2 really supported ? It is not on rk3588 and likely neither on rk3576. > You also mention later that Only 4:0:0 and 4:2:0 are supported. On the older rkvdec it is not, and I was unsure about the newer SoCs at the time of initial re-work of this. Regardless this is more correct when only looking at this function, it does not include 4:4:4 but is correct for all currently known RKVDEC_IMG_FMT. Also to keep this function in sync with the h264 variant for more easy compare and less confusion about the two down the line. Regards, Jonas > >> + else >> + return RKVDEC_IMG_FMT_420_8BIT; >> + } else if (sps->bit_depth_luma_minus8 == 2) { >> + if (sps->chroma_format_idc == 2) >> + return RKVDEC_IMG_FMT_422_10BIT; > > Same here. > > -- > Detlev. > > >