From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E0E23630B3 for ; Thu, 30 Apr 2026 04:46:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777524402; cv=none; b=W2fz0ij6U6S6vDS6YXYppf3YYhbswwY+rpr3sBGqJYG1T9mVHHu8WmIElpxFv3PHMElP1KCB8DBVHpFEExL3JKf5HnwlJEN0GK3X2Rw3UpDUGhpZeRE5Bl1oLBI9Y2a7yrQ3RLyZKIxRarWeXyZSyFkFAMPEcEPQwF3QKnf39jg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777524402; c=relaxed/simple; bh=ERhZOvBPJGPRGOnygQd9Z24lOzXG4tJMtlhFjmEopLY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LD8ZGWxWHMAptJf2SNv9VHm/6xTOkkBpKTon+BUGuyavacJjRPtDYlHJ4rcTuZZfGD7GVb5cXiaJQn4kwD5NW+XfzI7YLPtqEXPtpDwA9S4HTNqM9KWwgB1UPj9wuaN2j7mAH/88jRU5/ozkn8rvFzU1BkTw2WdbY0eMcPKOKjw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pauSl8Ye; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YMG2rh5d; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pauSl8Ye"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YMG2rh5d" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63TMF8sb3884658 for ; Thu, 30 Apr 2026 04:46:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UHHyy1jhBLSCQLkczwQR9iTY7y+sVIfuoEj3zUQPDRo=; b=pauSl8YeBI7B11Tk 8T2OP/Hl1HpR7rcTTzMTrL1rTlJe9v8o7NIHtPxoea5QcSJKKdnlXICKsB+Qv8DZ aH+7M/YUFBQV5bs4rIvJW1CjtXdPdt5rV02NAxCIeFY3FqBI+pzjCkYlzmVnUzba 0Xw1o76B1sF5pQqXv4RpKTQSKKo6N+Bdho7VKA4A4kGFWxlX5HRaTaC6icD2zova 4/UO99JL5/xl/QtaiS4of+V90FgMNuHNWrHMRJHymUvWD6pcN1xtI1KJCFZHwM+S ubSH4GxZejEzCzGk3fZG4EAxBgCFuLG2JDnGcBqUstmp+7nc5/Q1qJhPKlnDi7zV YMB5AQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dutmah0fe-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Apr 2026 04:46:40 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-362eb03240bso502574a91.3 for ; Wed, 29 Apr 2026 21:46:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777524400; x=1778129200; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UHHyy1jhBLSCQLkczwQR9iTY7y+sVIfuoEj3zUQPDRo=; b=YMG2rh5dHnf4LkrK2VObCBcugfclPfBmIO6klmm7fDOAIQjPNvxX2NzflnYitMQMJU HFm+meHBGSxtmNfTc6eTfSKBD7HWqqbBj6wahVIH5TmtrAlG5vfru+HEaIeIR/4tRuZ4 MLr7Xt01i2Svlnjbx1QC+lI5Lqs0QOv8bcHjQFagRqXBw5cdorfTFp2cKr0HQqXPm8Wk WmRx2LpOCgVV1Kl22znFphTjcjZ3YypAgkdE3XrWTovOsaItyzcSqcdX6CdKK7JfqIH2 YeiXZjxGzyPIcY/dR3+CekZLKfPKeHIavI2lNeRA4xmskBFC96CdEYN92/PDwN4YADvb 8JZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777524400; x=1778129200; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UHHyy1jhBLSCQLkczwQR9iTY7y+sVIfuoEj3zUQPDRo=; b=Mp5Q1I0bEk4Imk4cVCcIpisHE6fWqh2nn0aM7bStWrfuDVCE9tz+j2VqsDBhYIBHEE 6bmC7hNKuP8U5MGGxgcUiq2IMhCuEMFT9N4+IgotJqUd+TwgW0QC6FqTQbaCVS3J/nw2 qUG8w5iYxYqeYjerrTgIvQLgC6EcKySfvW8ABv3mwbaSb9wwVBabdb3GTh67I+HfahTS QMB/sIYBtC1c8mclyv34TajIYnEb5Uv65k8+pTrwb4X7cCoX5uaRF2zX91dFwSnyDCjc mHhQm8gF3L8c459J4RT06d00uMfu7o4du90LfqQ2al2p0BzX6laO7pN9oGrtxmhK+Gfs KIMA== X-Forwarded-Encrypted: i=1; AFNElJ9uaHbRkL10KduxIoC+R6FEDZ2es4ofCDxDaPQw5IepqwV/UEpuwEnyiwnh0YFC7HYOcL+SZg7DTjOMizk=@vger.kernel.org X-Gm-Message-State: AOJu0YzBDmPr5ph/a2kQgKYFWOBqZb3OHBeDppdOBLpLswMRQAEnou3L tqs7hlgxCXZvKpvSB7KgL+rMvDJTcwBjn1Vn9Ay990SsBG2QZOE8EXI5rRVnFaaI7T3taxAGEb9 ZzWFOwKUJSUKWJEJ4knr60BAAELXvhubzKOKa77bzoXtP5jtPo8baNn/Qgh9voQpR0gwlWZUjWL M= X-Gm-Gg: AeBDietp21IwwH7jhM21gwZ7S5pM9QVZekIzuE3BBTz8G9YIOs8I7wd0eMvFRLhk/Vc PRCuKxK/styH8QhDt/dINMmHB3Jhvs1AUQ7Vu2pMehGcULzOSZRaGJpWwnW3hu5rHipW5QkvpEF 9GYyV8v9Sj758tY/mvm4XI7zKzz79Q/75hUY28cbsfqzfpKOfZOo0UKOBABZEr0CVZYO1wFuaWB +u4lYMuCFNfzk0NnNcVEn3vKo2jS4/5eyIzoTKb9Hem/+NpgImMFSXvbfPqlzN7xoP91C/26uv0 f6RuUMsFCXKziNvN56vMHZ5WDsm9tOelPZBGA9CsU+uyzqkL+68c5Jo7uEol6SQyRDfs7wvG6ug Fhf3LlyoCDyAL2MYzLT5b4sPEd7tPfPE/Dvt0dRrVXG1g/zOOp/H1+hxcwFym2w== X-Received: by 2002:a17:90b:4b8f:b0:35f:c729:de9f with SMTP id 98e67ed59e1d1-364c32cdbcdmr1280462a91.27.1777524399737; Wed, 29 Apr 2026 21:46:39 -0700 (PDT) X-Received: by 2002:a17:90b:4b8f:b0:35f:c729:de9f with SMTP id 98e67ed59e1d1-364c32cdbcdmr1280434a91.27.1777524399270; Wed, 29 Apr 2026 21:46:39 -0700 (PDT) Received: from [10.217.198.242] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-364be044f23sm1211837a91.17.2026.04.29.21.46.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Apr 2026 21:46:38 -0700 (PDT) Message-ID: Date: Thu, 30 Apr 2026 10:16:33 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] pinctrl: qcom: add the TLMM driver for the Nord platforms To: Bartosz Golaszewski , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Bartosz Golaszewski , Shawn Guo , Arnd Bergmann , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20260428-nord-tlmm-v3-0-f16f08d084cc@oss.qualcomm.com> <20260428-nord-tlmm-v3-2-f16f08d084cc@oss.qualcomm.com> Content-Language: en-US From: "Maulik Shah (mkshah)" In-Reply-To: <20260428-nord-tlmm-v3-2-f16f08d084cc@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: kMzHdhtuZgz8IETfsV2HIfKfieVgcyPW X-Proofpoint-GUID: kMzHdhtuZgz8IETfsV2HIfKfieVgcyPW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDMwMDA0NSBTYWx0ZWRfX2L4Lhnqaj0EB Eyxaw26Yeo1skaUe7T7Usnr0lH4Znr2tTWaf8th0fOvm3MySF7C1PN6BxkKOBH6d6vxEkzFnvUj nAjSSik5WVtUHA4mEpzo0PJtCxJ+WtrGigi+CrBiQVFGBMwKsQG5eMsrWF+FSNMrkbH/peGA4Zl q9XbnWsbK4zqlBjepvwT9wnkNKCbtk/SGaxtltpWDpMQzpp8DMsKCk2Ey8rpPdHKtq1EsxL48us axLBHATN+0+NCeNMJPNUCxRAZnf2W5Q8W1mzmwIbSIygPJobLw2IepXqSediDFc3+/uu3Zdu6Qn TbXCmSzVtmJUYvMdH0qAzG4uqtDyUubnT+otgLoNDEyVn4e5y1N9eT3IVCBxtUohIYI3zUDf3OX V6Q2hCZW5pmjALp1GmBzSL72UlhguECemvbgLxc3qseP7t/HGOdFb8vlKiqMHkXiZ6B9lwmryx0 0zyH3/ma+Y/fRyyZiNA== X-Authority-Analysis: v=2.4 cv=Fpo1OWrq c=1 sm=1 tr=0 ts=69f2deb0 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=d8IIXGk-wedfOAHOyJQA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-30_01,2026-04-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 suspectscore=0 malwarescore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604300045 On 4/28/2026 7:18 PM, Bartosz Golaszewski wrote: > Add support for the TLMM controller on the Qualcomm Nord platform. > + > +static const struct of_device_id nord_tlmm_of_match[] = { > + { .compatible = "qcom,nord-tlmm", .data = &nord_tlmm }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, nord_tlmm_of_match); [...] MODULE_DEVICE_TABLE() seems to be kept as the last line in other pinctrl- files. if you are sending a new revision, better to keep at the end for uniformity. > + [...] > + > +MODULE_DESCRIPTION("Qualcomm Technologies Inc. Nordschleife TLMM driver"); Is Nordschleife expected name here or should it be just called Nord? Also since all other pinctrl- files have this description using "QTI TLMM driver" Do you need to replace Qualcomm Technologies Inc. with QTI to have uniformity across all SoCs? Otherwise looks good to me, Reviewed-by: Maulik Shah Thanks, Maulik > +MODULE_LICENSE("GPL"); >