From: "Arnd Bergmann" <arnd@arndb.de>
To: "Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Arnd Bergmann" <arnd@kernel.org>
Cc: "Bingbu Cao" <bingbu.cao@intel.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
"Andreas Helbech Kleist" <andreaskleist@gmail.com>,
"Tianshu Qiu" <tian.shu.qiu@intel.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: ipu-bridge: fix ipu6 Kconfig dependencies
Date: Mon, 29 Jul 2024 09:24:23 +0200 [thread overview]
Message-ID: <c05a72dd-1821-43ba-b3b4-caa9334e4016@app.fastmail.com> (raw)
In-Reply-To: <Zqc-tY7LPLdEbZ-9@kekkonen.localdomain>
On Mon, Jul 29, 2024, at 09:03, Sakari Ailus wrote:
>> To make it consistent with the other IPU drivers as well as avoid this warning,
>> change the 'select' into 'depends on'.
>
> Thanks for the patch. I'm not sure how I managed to miss the IPU6 driver...
The driver was only adding in 6.10, so your patch was correct
at the time.
> I think we also need, besides IPU_BRIDGE, || !IPU_BRIDGE, as the IPU_BRIDGE
> has additional dependencies (I2C) compared to VIDEO_INTEL_IPU6. I'll add
> that while applying. Please let me know if you have concerns.
Makes sense, yes. I went with a hard dependency since that stays
close to the current version with the select. I tried build-testing
IPU6 now with IPU_BRIDGE=n and I2C=n/I2C=m, which works fine.
However, the testing showed that IPU6 also missed a 'select AUXILIARY_BUS',
which I had not found in randconfig testing because that usually gets
selected by one of is other 30 users.
Since you are changing my patch already, maybe you can also add
that at the same time. Thanks,
Arnd
next prev parent reply other threads:[~2024-07-29 7:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 9:53 Arnd Bergmann
2024-07-29 7:03 ` Sakari Ailus
2024-07-29 7:24 ` Arnd Bergmann [this message]
2024-07-29 7:37 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c05a72dd-1821-43ba-b3b4-caa9334e4016@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andreaskleist@gmail.com \
--cc=arnd@kernel.org \
--cc=bingbu.cao@intel.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®