From: Sagi Grimberg <sagi@grimberg.me>
To: Johannes Thumshirn <jthumshirn@suse.de>,
Christoph Hellwig <hch@lst.de>,
Keith Busch <keith.busch@intel.com>
Cc: Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH v4 1/1] nvme: trace: add disk name to tracepoints
Date: Tue, 19 Jun 2018 17:09:27 +0300 [thread overview]
Message-ID: <c05ae7fd-3580-ffb5-8beb-6e28666687f4@grimberg.me> (raw)
In-Reply-To: <20180611184630.3435-1-jthumshirn@suse.de>
On 06/11/2018 09:46 PM, Johannes Thumshirn wrote:
> Add disk name to tracepoints so we can better distinguish between
> individual disks in the trace output.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
>
> ---
>
> I'm not entirely sure if this adding the ctrl pointers to
> nvme_complete_rq() and nvme_setup_cmd() is a good idea, it's the
> fast-path after all.
We are going to need it for traffic based keep alive to update
that we saw a completion to extend the kato.
But I suggest you simply keep a ctrl reference in struct nvme_request
instead so you don't need to pass it to nvme_complete_req (that's what
I did for traffic based keep alive).
next prev parent reply other threads:[~2018-06-19 14:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 18:46 Johannes Thumshirn
2018-06-19 14:09 ` Sagi Grimberg [this message]
2018-06-25 7:08 ` Johannes Thumshirn
2018-06-25 13:31 ` Sagi Grimberg
2018-06-25 14:03 ` Johannes Thumshirn
2018-06-26 10:59 ` Sagi Grimberg
2018-06-26 11:13 ` Johannes Thumshirn
2018-06-26 12:29 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c05ae7fd-3580-ffb5-8beb-6e28666687f4@grimberg.me \
--to=sagi@grimberg.me \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®