mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philippe CORNU <philippe.cornu@st.com>
To: Eric Anholt <eric@anholt.net>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Alexandre TORGUE <alexandre.torgue@st.com>,
	Yannick FERTRE <yannick.fertre@st.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] drm/stm: Fixup for "drm/stm: ltdc: Add panel-bridge support"
Date: Fri, 23 Jun 2017 14:46:34 +0000	[thread overview]
Message-ID: <c05b7987-4062-27b3-d704-7070286573bf@st.com> (raw)
In-Reply-To: <20170622175636.22723-2-eric@anholt.net>



On 06/22/2017 07:56 PM, Eric Anholt wrote:
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
> 
> This fixup would be squashed into patch 1 of your series.

Hi Eric,
and many thanks for the two patches, I will follow your suggestion for 
the v5 serie.
By the way, do you have more comments on the "drm/stm: ltdc: Add 
panel-bridge support" patch?
Many thanks :-)
Philippe

>   drivers/gpu/drm/stm/ltdc.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 7d7e889f09c3..d1d28348512b 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -953,7 +953,8 @@ int ltdc_load(struct drm_device *ddev)
>   		bridge = drm_panel_bridge_add(panel, DRM_MODE_CONNECTOR_DPI);
>   		if (IS_ERR(bridge)) {
>   			DRM_ERROR("Failed to create panel-bridge\n");
> -			return PTR_ERR(bridge);
> +			ret = PTR_ERR(bridge);
> +			goto err;
>   		}
>   		ldev->is_panel_bridge = true;
>   	}
> 

  reply	other threads:[~2017-06-23 14:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1497889685-27349-2-git-send-email-philippe.cornu@st.com>
2017-06-22 17:56 ` [PATCH 1/2] drm/stm: Fix leak of pixel clock enable in some error paths Eric Anholt
2017-06-22 17:56   ` [PATCH 2/2] drm/stm: Fixup for "drm/stm: ltdc: Add panel-bridge support" Eric Anholt
2017-06-23 14:46     ` Philippe CORNU [this message]
2017-06-23 18:18       ` Eric Anholt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c05b7987-4062-27b3-d704-7070286573bf@st.com \
    --to=philippe.cornu@st.com \
    --cc=alexandre.torgue@st.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yannick.fertre@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®