From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8F37C433F5 for ; Fri, 28 Jan 2022 16:54:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350349AbiA1QyN (ORCPT ); Fri, 28 Jan 2022 11:54:13 -0500 Received: from foss.arm.com ([217.140.110.172]:53998 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245711AbiA1QyL (ORCPT ); Fri, 28 Jan 2022 11:54:11 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 610E0113E; Fri, 28 Jan 2022 08:54:11 -0800 (PST) Received: from [10.57.68.47] (unknown [10.57.68.47]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 934F93F793; Fri, 28 Jan 2022 08:54:09 -0800 (PST) Message-ID: Date: Fri, 28 Jan 2022 16:54:02 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH] iommu/iova: Separate out rcache init Content-Language: en-GB To: John Garry , "joro@8bytes.org" , "will@kernel.org" , "mst@redhat.com" , "jasowang@redhat.com" Cc: "xieyongji@bytedance.com" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , Linuxarm References: <1643205319-51669-1-git-send-email-john.garry@huawei.com> <5ac3a678-3126-edd9-cb23-72c05f3dcd34@huawei.com> From: Robin Murphy In-Reply-To: <5ac3a678-3126-edd9-cb23-72c05f3dcd34@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-01-28 11:32, John Garry wrote: > On 26/01/2022 17:00, Robin Murphy wrote: >> As above, I vote for just forward-declaring the free routine in iova.c >> and keeping it entirely private. > > BTW, speaking of forward declarations, it's possible to remove all the > forward declarations in iova.c now that the FQ code is gone - but with a > good bit of rearranging. However I am not sure how much people care > about that or whether the code layout is sane... Indeed, I was very tempted to raise the question there of whether there was any more cleanup or refactoring that could be done to justify collecting all the rcache code together at the top of iova.c. But in the end I didn't, so my opinion still remains a secret... Robin.