mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Phil Reid <preid@electromag.com.au>
To: Jia-Ju Bai <baijiaju1990@gmail.com>,
	f.fainelli@gmail.com, andrew@lunn.ch,
	vivien.didelot@savoirfairelinux.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: dsa: b53: Using sleep-able operations in b53_switch_reset_gpio
Date: Thu, 12 Apr 2018 10:31:22 +0800	[thread overview]
Message-ID: <c0613024-9d77-321b-8bcd-57078184d609@electromag.com.au> (raw)
In-Reply-To: <1523497702-7200-1-git-send-email-baijiaju1990@gmail.com>

On 12/04/2018 09:48, Jia-Ju Bai wrote:
> b53_switch_reset_gpio() is never called in atomic context.
> 
> The call chain ending up at b53_switch_reset_gpio() is:
> [1] b53_switch_reset_gpio() <- b53_switch_reset() <-
>      b53_reset_switch() <- b53_setup()
> 
> b53_switch_reset_gpio() is set as ".setup" in struct dsa_switch_ops.
> This function is not called in atomic context.
> 
> Despite never getting called from atomic context, b53_switch_reset_gpio()
> calls non-sleep operations mdelay() and gpio_set_value().
> They are not necessary and can be replaced with msleep()
> and gpio_set_value_cansleep().
> 
> This is found by a static analysis tool named DCNS written by myself.
> And I also manually check it.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
> ---
> v2:
> * Use gpio_set_value_cansleep() to replace gpio_set_value() additionally.
>    Thanks for Florian and Phil for good advice.
> ---
>   drivers/net/dsa/b53/b53_common.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c
> index 274f367..36cc60d 100644
> --- a/drivers/net/dsa/b53/b53_common.c
> +++ b/drivers/net/dsa/b53/b53_common.c
> @@ -596,11 +596,11 @@ static void b53_switch_reset_gpio(struct b53_device *dev)
>   
>   	/* Reset sequence: RESET low(50ms)->high(20ms)
>   	 */
> -	gpio_set_value(gpio, 0);
> -	mdelay(50);
> +	gpio_set_value_cansleep(gpio, 0);
> +	msleep(50);
>   
> -	gpio_set_value(gpio, 1);
> -	mdelay(20);
> +	gpio_set_value_cansleep(gpio, 1);
> +	msleep(20);
>   
>   	dev->current_page = 0xff;
>   }
> 

FWIW:
Reviewed-by: Phil Reid <preid@electromag.com.au>

  reply	other threads:[~2018-04-12  2:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-12  1:48 Jia-Ju Bai
2018-04-12  2:31 ` Phil Reid [this message]
2018-04-12 16:32 ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0613024-9d77-321b-8bcd-57078184d609@electromag.com.au \
    --to=preid@electromag.com.au \
    --cc=andrew@lunn.ch \
    --cc=baijiaju1990@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®