From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC5B7410D38 for ; Tue, 28 Apr 2026 12:18:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378701; cv=none; b=Dysgn8pk3vpfh454mCU7vjQhhSwrDlc0Jg2xckX+V7g5DK3eExaqsqXfN1sX0DpES8tsf8JeWjUyCBUyONVHEZvbFfSNhgFw8dbZtSlk08K+l4Bz5Ca8EJO0cd1mxBDhHeHmupWYZjh9zg9qZRFE0zql0bkEsQn9NAWmwAhcBv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378701; c=relaxed/simple; bh=7Zso9KS+gzl6tIHrYjH5N3xNODteTYkq+N/ntXUkUb8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LdzFSyvWMS2qsMZ7Wfppe6c/wUegPwVOjDKRe3YrOBVucWImlQ+xeAzI0SPK7dSPVBIxtKZew4herQqH91/yOxWk/xkIgfdpjldu1LEA6x7UqUCMbJYohWDZRWX82AQo8GJqeCdqZIHYOJKx0LC8IG3HK9fpvtyWeIFpS8dR5dc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=A+xZbf2g; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BuQV2Qja; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="A+xZbf2g"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BuQV2Qja" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63S9hah12045271 for ; Tue, 28 Apr 2026 12:18:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= b5kFeqYt/6hoO6aGdTKf3E/wifl3FzIvEDfFJxnGaXE=; b=A+xZbf2gkylFt81o x+cSbgpkgy2MCYpYlbrhyfOtVlk7k/QVjPNC8dY1doBJk0mHmknvWTQbVpjICUeu ryCIKDN6nBNLuxQ0NXTzDPaWJuKX+i83c6bN02soMKSaf/MVKUGnCIvRireT6050 Bbe2yXPQKyLJDW56Exk1kG/78wtLIpHBraPeluatU0U4YFwlx0HXV59wveMu+7it 929B3DQxTIVZr5jibBm4YO4rb+/GDFOs2lNM5ZhelSlENe82AjHHjAtGj8p3r0WU 9lXompbtVmDjPFB7w9ADopV3I9BeACDcnyg+ICxIuR88hD6fQYHxnQwPFrf8tZUw 2zD56g== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dttgyrjjc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 28 Apr 2026 12:18:11 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c798fc1a426so4349346a12.2 for ; Tue, 28 Apr 2026 05:18:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777378690; x=1777983490; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=b5kFeqYt/6hoO6aGdTKf3E/wifl3FzIvEDfFJxnGaXE=; b=BuQV2QjapTtvNWxtPEaUba1K8fAnS6x3c8oHGhqlxxnHzomZlKlmDOEB/UJrI3WCiZ ImpNbwQdrWwsUYEOU3mgPITP7vaVP0ai2uhTHpeoY55YFrh+SzuyYRko1As3npyUOTln owlI6ZQgtJJsK1U2TDNVCpbDQe3BffhvLNa81Jjo6D20Oz5qwJ3EBlGcX6CyjBhxq/CB CebkJKDR9EG/uX5vBYjCo1cAzAt3yyJM5IriYovUtuQWVl4rd1gJ3lCyfAK7Go4P0+ED EtVsDXu4GMilggJd7eLCzTbJ6X8EHCxM2oe6O1fDptTmU9GbLfDV4jPV/+56ohQ11+Od +7UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777378690; x=1777983490; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b5kFeqYt/6hoO6aGdTKf3E/wifl3FzIvEDfFJxnGaXE=; b=r6PAZiw/prPhZSB/nRLhFvtH8AUkCJurkPBte6i+PJ97DVMlmPTGgk7PjhUJn3dRvs WeQ2lRgOzCnMaFzANBU4EtmY62fIWWfeCbLh+NTGifTmYGjZeiRBkAvD5ALC8gBjn/3R iEOfZ+jDpGaSL8TXpDANZX+nUiEtBzCDmbJd3+V7tRQ1CPtrbhjEGy3zcpnCC49AiDYh 3jinXXflgMrzy9NODNHJa8M9Bs+sO6LmvLmE6HV2tqKRvjB/Wt944Ua/8Tz5qrZPP76Y Cy+oWwJT9tX9YN1XFQRMeOw/tA6cJQ87uKvcQUJfS+ms/ey99Lhwhkof9PcoEZeA2VBj 5J6g== X-Forwarded-Encrypted: i=1; AFNElJ9+yw7uI7gFL346d+bP8EtIBZSSgqdAwTH85dnWQm4ND6jOktFWbA4fTGtd8M+IgGdCVrokjSnSPBiuMIk=@vger.kernel.org X-Gm-Message-State: AOJu0YwJKwVIdaBcnzG/Sazb73My7Xa/p/w3d5r0s+D8eugqaCDoKxfr Zpo6ZByTF5o1pA2PvMHYOmPqtTXxi/6huKaAG7XIA4D2nSmnpoM8dmUhdd4Tt6x20tJLyvGjcXn RQklfExQdaSIevlCmOWrHSde7bET98MGgv7Ykn5arBVrubGWiu7f0z5NYYsCSc0I65ZA= X-Gm-Gg: AeBDieu9O6llHXlO8U1P+QnTjtIY1d3VmHUBZrAQc9zEMLhBEhU+I6owk/J9xOPS5+l mLcawlPkBaH2pJ4vr20yP7nhZjBj8SfWbbCHfqfhyF1bQj8DLmnhRAATWn76/JQzDqN38PesP8s 6tVgOHfms2Eywchi1XLxvODwr5nKph+gDgO2dHjx1COOiMSmshQnMpXZMOlEG1mJZjDUco97okA kfdxBwrjeZ99gQHiTZ1Sr3AOp1TyeucF1ytUUbxAAYyPf2dWhn7BW4lyo2UyKEHNv4URDDuoHlc Hh0UXhaeFu/XzBEbIdJSwPfLCt1JR5uIMtlSEDRkIPxM3Ty7r3wTTXLfIaNnbLvIruPRt+w6mXz kDfKenA8T+ieh1Xow/1cTS8sPnsQjHMOXapf3ZUsHfRAHT2ZLxZs88yK5dMUiLvbe94U= X-Received: by 2002:a05:6a20:958f:b0:398:7830:8a40 with SMTP id adf61e73a8af0-3a39c0ed8c6mr3526737637.23.1777378690300; Tue, 28 Apr 2026 05:18:10 -0700 (PDT) X-Received: by 2002:a05:6a20:958f:b0:398:7830:8a40 with SMTP id adf61e73a8af0-3a39c0ed8c6mr3526670637.23.1777378689785; Tue, 28 Apr 2026 05:18:09 -0700 (PDT) Received: from [10.219.57.134] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7fc6015691sm2244868a12.18.2026.04.28.05.18.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 05:18:09 -0700 (PDT) Message-ID: Date: Tue, 28 Apr 2026 17:47:59 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v21 08/13] mfd: core: Add firmware-node support to MFD cells To: Bartosz Golaszewski Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Florian Fainelli , Krzysztof Kozlowski , Dmitry Baryshkov , Mukesh Ojha , Andre Draszik , Greg Kroah-Hartman , Kathiravan Thirumoorthy , Srinivas Kandagatla , Sebastian Reichel , Mark Rutland , Lorenzo Pieralisi , "Rafael J. Wysocki" , Daniel Lezcano , Christian Loehle , Ulf Hansson , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Arnd Bergmann , Souvik Chakravarty , Andy Yan , Matthias Brugger , John Stultz , Moritz Fischer , Sudeep Holla References: <20260427-arm-psci-system_reset2-vendor-reboots-v21-0-dcf937775e73@oss.qualcomm.com> <20260427-arm-psci-system_reset2-vendor-reboots-v21-8-dcf937775e73@oss.qualcomm.com> Content-Language: en-US From: Shivendra Pratap In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: xbmRMupfAq2cHl5L1m8QZrD7R49Y2SVE X-Proofpoint-GUID: xbmRMupfAq2cHl5L1m8QZrD7R49Y2SVE X-Authority-Analysis: v=2.4 cv=cb7iaHDM c=1 sm=1 tr=0 ts=69f0a583 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=SHOFGYX_daQPcY9Fc6gA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI4MDExMiBTYWx0ZWRfXxV4JYgOwj39u gqD1Kn71zNJ/5Yg4qEXH4c2Z+nD5GDr8/6Cwo2Sqx9QRfluz2kkD4DdzAtRNUkh6idtPIX5S09c DneF7W436rR+u6Tawj/p+RyH5mwCkENSNLOCe3sryu7r4cK8KhEeTD2kKh1uiBqOUijyyaVQvoG o8aH94gc9mimO79dmxFQCQWYknbuP/ES3Pucl+OmCRr051t3yLrsldWdP7WMqT6sRWYptdhU/qk TCQJzLYE+izg0MId+JibZh8RPFAUimDAMlmyYkXJx6vrnCqwPPEO8mfPq00mTdbh1Qe00o4qBRA LKzAbyNV/ve7DhQMzQBq4YHh4GsVWCHMgFDAc09P095mOK89rQiKeqaVui9oi1HUgHqO1FyhNmB WLS1zQjR+qTARfdwCp9M0MtFTgcPI4k8lPOjzwi8aiUhqR5wn0bscGC1C4/c6+wHKsJ1PUcGQh5 d6lTLcK1auhmnbDDOBQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-28_03,2026-04-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 clxscore=1015 impostorscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604280112 On 28-04-2026 13:33, Bartosz Golaszewski wrote: > On Mon, 27 Apr 2026 19:34:48 +0200, Shivendra Pratap > said: >> MFD core has no way to register a child device using an explicit firmware >> node. This prevents drivers from registering child nodes when those nodes >> do not define a compatible string. One such example is the PSCI >> "reboot-mode" node, which omits a compatible string as it describes >> boot-states provided by the underlying firmware. >> >> Extend struct mfd_cell with an optional fwnode pointer and attach it to the >> child device during registration when no firmware node is already assigned. >> >> Signed-off-by: Shivendra Pratap >> --- > > In the following patch you use this and violate the supposed constness of > MFD cells. This also mean you need to modify the mfd_cell at run-time. I would > prefer introducing a field in mfd_cell: bool use_parent_fwnode which would > indicate to MFD core that - in case no fwnode was assigned from other sources: > DT or software node - it should reuse the parent MFD device's node. Have one doubt on this, When we fallback to use_parent_fwnode for cell: psci-reboot-mode, at psci_reboot_mode_probe(), pDev->dev->of_node point to psci node. But we want dev->of_node to point to "reboot-mode" node. This may need an explicit assignment again of of_node? thanks, Shivendra