mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Manish Pandey <quic_mapa@quicinc.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org, quic_nitirawa@quicinc.com,
	quic_bhaskarv@quicinc.com, quic_rampraka@quicinc.com,
	quic_cang@quicinc.com, quic_nguyenb@quicinc.com
Subject: Re: [PATCH] ufs: qcom: Add quirks for Samsung UFS devices
Date: Tue, 25 Mar 2025 07:42:53 -0400	[thread overview]
Message-ID: <c0691392-1523-4863-a722-d4f4640e4e28@acm.org> (raw)
In-Reply-To: <20250325083857.23653-1-quic_mapa@quicinc.com>

On 3/25/25 4:38 AM, Manish Pandey wrote:
> Introduce quirks for Samsung UFS devices to override PA hibern8 time,
> PA TX HSG1 sync length, and TX_HS_EQUALIZER for the Qualcomm UFS Host
> controller. These adjustments are essential to maintain the proper
> functionality of Samsung UFS devices for Qualcomm UFS Host controller.

Which of these quirks are required for all host controllers and which of
these quirks are only required for Qualcomm host controllers?

> +	equalizer_val = (gear == 5) ? DEEMPHASIS_3_5_dB : NO_DEEMPHASIS;

I think that the parenthesis can be removed from the above statement
without reducing readability of the code.

Thanks,

Bart.

  reply	other threads:[~2025-03-25 11:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-25  8:38 Manish Pandey
2025-03-25 11:42 ` Bart Van Assche [this message]
2025-03-26  9:53   ` MANISH PANDEY
2025-03-26 10:39     ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0691392-1523-4863-a722-d4f4640e4e28@acm.org \
    --to=bvanassche@acm.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=martin.petersen@oracle.com \
    --cc=quic_bhaskarv@quicinc.com \
    --cc=quic_cang@quicinc.com \
    --cc=quic_mapa@quicinc.com \
    --cc=quic_nguyenb@quicinc.com \
    --cc=quic_nitirawa@quicinc.com \
    --cc=quic_rampraka@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®