From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752871AbdHOPhC (ORCPT ); Tue, 15 Aug 2017 11:37:02 -0400 Received: from mout.web.de ([212.227.15.14]:49495 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751460AbdHOPg7 (ORCPT ); Tue, 15 Aug 2017 11:36:59 -0400 Subject: [PATCH 1/3] fs-udf: Delete an error message for a failed memory allocation in two functions From: SF Markus Elfring To: Jan Kara , kernel-janitors@vger.kernel.org Cc: LKML References: <6eedcf1a-57f0-2ba4-d1b8-47a8da945d87@users.sourceforge.net> Message-ID: Date: Tue, 15 Aug 2017 17:36:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <6eedcf1a-57f0-2ba4-d1b8-47a8da945d87@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:fAjQcIHSFOp/SIb0cByUg7KMUdn01UQ+BcSCDEH1YDfS+NdlsyY 8N/JljGnGQ43Pt/B16GhiplIVwTG4Y4GDlDHCFgkg45TIEJuuLIj0fKleDICvCavtL5M2+8 iDYBaEtQgLO/SSk6Oa9YjH8AFVjLb+qmqqcDgqZaKXKgPl9+2TdZaFoUEMP3Ibt0YFAKsax 2DTl2RzJtuMT4LQxM8a4w== X-UI-Out-Filterresults: notjunk:1;V01:K0:B2NNAB91z0s=:rNxPgBPlWsnkrwd3jaJD0B MVgvtW+A4OvOlnlSTiO/qr1KMR2zh4v+rcYhkHL11erY8K5vUynSSadZEAR7JeJKceViofPiJ sMfuUcblF6VsUXBJinLZL1Mgo465MNAd7yYcGCH+vaT8PQqsHdyle7UkSf0jm0DsLOdVGOAVR IB9hNYd4OtscATRt0DfHU+wMFr0tYjCkOjmgBlp7ZNRgyKzXSVpbav9SaKSqpmVU/W98Al4gr uZl1fh8OMz27QB3GwH4CT7da5p2IwsC4IR237uCgBN448FGWiVPZP5e7quLoXhMZSFf61n3Rn +W7PlfYniM7j6sRNtqXzQbsxwTVcGSBDTda/7hdQFtKolwaFk/TWoBPcNnHq4x5VCwxlVRx1k uoiJn4o+8N4qxbXu63b3Nr66NJXqy2GCCYfaK/5OSSWp6d7Fff/ZTg+DFNimWgD5iTh7V1FNS NxWnXsB7hUdpN95+iirGKrKMy7AdaOOtNUmCmdDh9ARi3Hu12LOUhNuVO1o4XO+/CAh8HR7j4 g1Co92rN0r0ySdCKPrVg9cIzPd9wydLmnfL6pZKyJO+DMMbD+t15Q91pqhewlD064z8uQwXPJ QOH0lBCm2BD/mExug7uRcI2I5haCT/fs/P902JujvbGhkR7SWdzDt7enSonciDf3FzHZ0UlE2 fYvjdc9jNYKdYtUKsveWx1z0R/yQDbjuYlpF98R5DC01BqeUDANSXvq/kv/lTxA0D1ZXHNuSt y2g0zY8vnvroCncDCP9M3CE3bpnUCyafXori/I9sm70xNjHji/hW+e/Scmo7Z5EP/KY9/sWu6 c/UU5e9au+/5wrjAwBouL+wFK0ZC+ZjEhx76KJStulkAxuUo/c= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 15 Aug 2017 16:14:19 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/udf/inode.c | 7 +------ fs/udf/super.c | 2 -- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/fs/udf/inode.c b/fs/udf/inode.c index 18fdb9d90812..7b50afc6e0c3 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c @@ -1572,13 +1572,8 @@ static int udf_alloc_i_data(struct inode *inode, size_t size) { struct udf_inode_info *iinfo = UDF_I(inode); iinfo->i_ext.i_data = kmalloc(size, GFP_KERNEL); - - if (!iinfo->i_ext.i_data) { - udf_err(inode->i_sb, "(ino %ld) no free memory\n", - inode->i_ino); + if (!iinfo->i_ext.i_data) return -ENOMEM; - } - return 0; } diff --git a/fs/udf/super.c b/fs/udf/super.c index 462ac2e9258c..ca4b4274b524 100644 --- a/fs/udf/super.c +++ b/fs/udf/super.c @@ -271,6 +271,4 @@ static int udf_sb_alloc_partition_maps(struct super_block *sb, u32 count) if (!sbi->s_partmaps) { - udf_err(sb, "Unable to allocate space for %d partition maps\n", - count); sbi->s_partitions = 0; return -ENOMEM; } -- 2.14.0