From: Waiman Long <longman@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will.deacon@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Davidlohr Bueso <dave@stgolabs.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Tim Chen <tim.c.chen@linux.intel.com>,
huang ying <huang.ying.caritas@gmail.com>
Subject: Re: [PATCH v5 00/18] locking/rwsem: Rwsem rearchitecture part 2
Date: Fri, 19 Apr 2019 11:00:31 -0400 [thread overview]
Message-ID: <c06c9fd4-629a-3488-31ff-9f0f148364a4@redhat.com> (raw)
In-Reply-To: <20190419124944.GA44010@gmail.com>
On 04/19/2019 08:49 AM, Ingo Molnar wrote:
> * Ingo Molnar <mingo@kernel.org> wrote:
>
>> * Waiman Long <longman@redhat.com> wrote:
>>
>>> On 04/18/2019 07:46 PM, Waiman Long wrote:
>>>> v5:
>>>> - Drop v4 patch 1 as it is merged into tip's locking/core branch.
>>>> - Integrate the 2 followup patches into the series. The first
>>>> follow-up patch is broken into 2 pieces. The first piece comes in
>>>> before the "Enable readers spinning on writer" and the 2nd piece
>>>> is merged into the "Enable time-based spinning on reader-owned
>>>> rwsem" patch. The 2nd followup patch is added after that.
>>>> - Add a new patch to make all wake_up_q() calls after dropping
>>>> wait_lock as suggested by PeterZ.
>>>> - Incorporate numerouos suggestions by PeterZ and Davidlohr.
>>> This patchset is still being reviewed by Peter . The purpose of this
>>> series is mainly to sync up the version that Peter has and the ones that
>>> I am working on incorporating his feedback. Further changes may still be
>>> needed.
>>>
>>> I run an overall performance test on this new patchset and present the
>>> data in this cover letter. However, I haven't run performance tests for
>>> individual patches. So the performance data listed in some of the
>>> patches may be stale.
>> Just for those who'd like to follow the scope of changes, find below the
>> v4->v5 interdiff. v5 is now included in tip:WIP.locking/core, and also
>> merged into tip:master. (But not propagated towards linux-next yet.)
> Hm, I'm experiencing early boot hangs with v5, on defconfig-ish x86-64
> kernels:
>
> [ 0.153940] rcu: Hierarchical RCU implementation.
> [ 0.154289] rcu: RCU restricting CPUs from NR_CPUS=128 to nr_cpu_ids=17.
> [ 0.154829] rcu: RCU calculated value of scheduler-enlistment delay is 100 jiffies.
> [ 0.155390] rcu: Adjusting geometry for rcu_fanout_leaf=16, nr_cpu_ids=17
>
>
> I bisected it back to the v5 version of this patch:
>
> 2fd5f60fa4c3: locking/rwsem: Merge owner into count on x86-64
>
> I'm moving -tip back to -v4 meanwhile.
>
> Thanks,
>
> Ingo
Sorry about that. Will look into that problem.
-Longman
next prev parent reply other threads:[~2019-04-19 18:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 23:46 Waiman Long
2019-04-18 23:46 ` [PATCH v5 01/18] locking/rwsem: Make owner available even if !CONFIG_RWSEM_SPIN_ON_OWNER Waiman Long
2019-04-18 23:46 ` [PATCH v5 02/18] locking/rwsem: Remove rwsem_wake() wakeup optimization Waiman Long
2019-04-18 23:46 ` [PATCH v5 03/18] locking/rwsem: Implement a new locking scheme Waiman Long
2019-04-18 23:46 ` [PATCH v5 04/18] locking/rwsem: Merge rwsem.h and rwsem-xadd.c into rwsem.c Waiman Long
2019-04-18 23:46 ` [PATCH v5 05/18] locking/rwsem: Code cleanup after files merging Waiman Long
2019-04-18 23:46 ` [PATCH v5 06/18] locking/rwsem: Make rwsem_spin_on_owner() return owner state Waiman Long
2019-04-18 23:46 ` [PATCH v5 07/18] locking/rwsem: Implement lock handoff to prevent lock starvation Waiman Long
2019-04-18 23:46 ` [PATCH v5 08/18] locking/rwsem: Always release wait_lock before waking up tasks Waiman Long
2019-04-18 23:46 ` [PATCH v5 09/18] locking/rwsem: More optimal RT task handling of null owner Waiman Long
2019-04-18 23:46 ` [PATCH v5 10/18] locking/rwsem: Wake up almost all readers in wait queue Waiman Long
2019-04-18 23:46 ` [PATCH v5 11/18] locking/rwsem: Clarify usage of owner's nonspinaable bit Waiman Long
2019-04-18 23:46 ` [PATCH v5 12/18] locking/rwsem: Enable readers spinning on writer Waiman Long
2019-04-18 23:46 ` [PATCH v5 13/18] locking/rwsem: Enable time-based spinning on reader-owned rwsem Waiman Long
2019-04-18 23:46 ` [PATCH v5 14/18] locking/rwsem: Adaptive disabling of reader optimistic spinning Waiman Long
2019-04-18 23:46 ` [PATCH v5 15/18] locking/rwsem: Add more rwsem owner access helpers Waiman Long
2019-04-18 23:46 ` [PATCH v5 16/18] locking/rwsem: Guard against making count negative Waiman Long
2019-04-18 23:46 ` [PATCH v5 17/18] locking/rwsem: Merge owner into count on x86-64 Waiman Long
2019-04-18 23:46 ` [PATCH v5 18/18] locking/rwsem: Remove redundant computation of writer lock word Waiman Long
2019-04-18 23:56 ` [PATCH v5 00/18] locking/rwsem: Rwsem rearchitecture part 2 Waiman Long
2019-04-19 7:50 ` Ingo Molnar
2019-04-19 12:49 ` Ingo Molnar
2019-04-19 15:00 ` Waiman Long [this message]
2019-04-19 16:56 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c06c9fd4-629a-3488-31ff-9f0f148364a4@redhat.com \
--to=longman@redhat.com \
--cc=bp@alien8.de \
--cc=dave@stgolabs.net \
--cc=hpa@zytor.com \
--cc=huang.ying.caritas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®