From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CADD397940 for ; Thu, 20 Aug 2026 19:21:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787253693; cv=none; b=HjZo7/XI0BePBMxNOZaGrMg/Ujcp7KGWgI55nS4HDWJIb5KIu7YWlvhZbBpb3+D6KmL9n1A3EUWRdOado1Cl1nXlXjrEjYyvmZQ22OQHcSzMP+Y6ptFe/TxpnCRJwRJigD3Z0QR6zARV+kkXZgVutPhxFih6fJtAr5ym4lddFb8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787253693; c=relaxed/simple; bh=iXFhaxvru/qMIY8eIZL9QVFGMNTO6OfJBL7/g6B74hs=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Zh6RqN4e87QKW6WHL0r6bO7h8P5ESWzCA1v/SA8JNwUieYI9BE15ZO0HcCG9zdlWFoZy6EzqpP+vht3Z1nTjULZrevj7U6H99S4gEVinAYaQp6pScxbVkbvMqNV07/MfKgYxl8JugdX7woD9JUS+xD400Q4UKnhqEzjoaGmyki0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=J3a/O/0c; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=UJ/Jf6JG; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="J3a/O/0c"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="UJ/Jf6JG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787253691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TgFrJA0kGHjEoIJ3Eqsw42ND56xZloAUAzXc6L7b5qs=; b=J3a/O/0cKyq1cAgXk+vV2KPCWXq+ftGcJZq4q3dAHg0IDi0ZpVEUhz6XgaZlyu63XvznhV OiI7lKk0avVcT8TK3jhl7MmnzvAnlmW4/LG2d4mnBhS8KsnxUuc/eR3XYV87vaUTreFabL XN8aeJwKtKGBOnho9J2CccIw3VkMDFQ= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-614-dp5pRkIdMa2QNWiWuN22_A-1; Thu, 20 Aug 2026 15:21:18 -0400 X-MC-Unique: dp5pRkIdMa2QNWiWuN22_A-1 X-Mimecast-MFC-AGG-ID: dp5pRkIdMa2QNWiWuN22_A_1787253678 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-907c59bd73bso3875656d6.3 for ; Thu, 20 Aug 2026 12:21:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787253678; x=1787858478; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=TgFrJA0kGHjEoIJ3Eqsw42ND56xZloAUAzXc6L7b5qs=; b=UJ/Jf6JGSBLSWTq1N85hQ+729fqJVp4IDzYoYCAjVz2t5XZ9xKSX9e7TeNFHrl7bV0 LJaQDALBGCygyPY+grkMFllOKpLvrgDocK2u5TOt4q/3v+/BzKbT6cGBCbsmCA5gFLag 8+PMDaQRbL310OuGiFUVNeAHR/adeAMRO4iOU+BH9UtvGOy3z+oBZUG6AmpeCVjmbnzT p3SpMToTNAMYjZRcDGh6nH+XCFFO4diMd7Wi72RqoBsqFrYFX8PSD5MtwIrKxiWwfLZ/ 4CvBcixCjUn/98oDuFsuvgH9QxjGbvXc1oAfjNUnVVSaCdq+BO69hzx3ZQZEt5faaJny p85g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787253678; x=1787858478; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TgFrJA0kGHjEoIJ3Eqsw42ND56xZloAUAzXc6L7b5qs=; b=FoGXxlk28qr8KiuZPfpC3OKlNw1KrFlqRc5y0dizLvYi9GJqtBY5qz1nJYvn0SIzVV Qo66GzN9x2BiLKTTELCxQGodwf2LAZ/4R2i9UEev9JUUEG0eZO47WJvyc4KjVNNEsh/X w1I7CHa6TzleXFj9Pg8lnEsDXObNaD+kZ3XcR5o1ivBsQqGQmgROivXrBSjsGxbqaMWy eopO62kLnRLcqD/XRSqelei+QpSwQqSc+ym3H51O7esHBc40eSy9B6ly0p79i7q+WIiY x4hepPXBNoUhTy/XRrX0r7uWTEAnguj9Xv7QQs9RaV8JKiHKWaEJ0vO3dbq+nSxdVaKY nrDA== X-Gm-Message-State: AFuF++lp/6n66sq4LzRYnqVYOi+T/arcc3DwkjCFh60Vx6ksiO9MYoAr VrSVyPTyMgvF/PiQnUig0zGIHBwxzsE8HK8BrUscEmeMjxQUYfIskSTUP7YXcrHo9Hn1fizd3Bl Gg0bK3FgPeOcxS+OQ6RKBnvTeOXOJbINpeW+J3MGUeQzA+9KNv4fGcmiI7jQlNenXIw== X-Gm-Gg: AR+sD118uFog/gx3VxhTsedW8oaq9O+X6CNpAkEzMYp8suqkkx9XCeUy+6C10mJHoJS UxP3nOmqvE6ktbrd5RJbJKGJcXrrTuuct57YRyNhPi48gMjm0/5t6rfghCN9b4q3dbtkV5Uj0Hc l8qQtoSRg4etdzrEF6FWC5fEJG927ACGjslhQsn9BVA7aD8pAtG37hfaVFqJHwInEpfj2kwSFYo POhO6NMEyGfm8UVQ0eEMIIpqtIq3V/Eg24pDy6WTe0QH16NCG01j9A+c1r2r5WCAnSqfOPlBZ4v gt0RtfKXfvJdX3k/xi6Ry+4WZlgAi8wA3y/fi6kBnQjwEF2E4eOIYl35wFysZ8HdBq8jrTOU X-Received: by 2002:a05:6214:4b09:b0:8ce:ca7d:b099 with SMTP id 6a1803df08f44-90c80cabff4mr5132396d6.18.1787253678219; Thu, 20 Aug 2026 12:21:18 -0700 (PDT) X-Received: by 2002:a05:6214:4b09:b0:8ce:ca7d:b099 with SMTP id 6a1803df08f44-90c80cabff4mr5131856d6.18.1787253677671; Thu, 20 Aug 2026 12:21:17 -0700 (PDT) Received: from [192.168.8.4] ([100.0.180.93]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90c5f2a2d62sm44581786d6.38.2026.08.20.12.21.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 12:21:16 -0700 (PDT) Message-ID: Subject: Re: [PATCH v3 3/4] drm/nouveau/fifo/nv04: filter benign CACHE_ERROR from Mesa NV50 bind probe From: lyude@redhat.com To: Marek Czernohous , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Danilo Krummrich , David Airlie , Simona Vetter , Ben Skeggs Date: Thu, 20 Aug 2026 15:21:15 -0400 In-Reply-To: <20260812231330.705425-4-mczernohous@gmail.com> References: <20260812231330.705425-1-mczernohous@gmail.com> <20260812231330.705425-4-mczernohous@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2026-08-13 at 01:13 +0200, Marek Czernohous wrote: > + * chip that reaches this handler, not just on > Tesla. > + * Demote to debug to keep dmesg clean while still > catching > + * real CACHE_ERROR events. > + */ > + if ((mthd & 0x1ffc) =3D=3D 0x0060 && > + =C2=A0=C2=A0=C2=A0 (data & 0xffffff00) =3D=3D 0xbeef0200) { > + nvkm_debug(subdev, "CACHE_ERROR - ch %d subc > %d mthd %04x data %08x (benign, skipped)\n", > + =C2=A0=C2=A0 chid, (mthd >> 13) & 7, mthd & > 0x1ffc, data); > + } else { > + chan =3D nvkm_chan_get_chid(&fifo->engine, > chid, &flags); > + nvkm_error(subdev, "CACHE_ERROR - ch %d [%s] > subc %d mthd %04x data %08x\n", > + =C2=A0=C2=A0 chid, chan ? chan->name : > "unknown", > + =C2=A0=C2=A0 (mthd >> 13) & 7, mthd & 0x1ffc, > data); > + nvkm_chan_put(&chan, flags); > + } I assume this won't break anything, but hindsight is always 20/20 - so, I think we should probably keep the print of the channel name even when demoting this to debug in case we have to investigate this someday. We should also move the nvkm_chan_get_chid(=E2=80=A6) call and nvkm_chan_put(= =E2=80=A6) call out of the conditional, and probably move all of the printf arguments into their own local variables in this function so there's less to maintain for future changes. > =C2=A0 }