From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98D1C299931 for ; Thu, 18 Jun 2026 13:36:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781789768; cv=none; b=egpO9b2FtehD+LAVNDuh/+c5Zo9qdB26PpyHa+MFpUAdQf1B8SITTur06aGPp4TVw/GtT18tvjYLPyPNFol3T03GvLKA4qWkkTWVRw4EVWKGHzX39oqSd3OVQy5yurARe7Wq3MEyUyoveb3m0oLNTGk54SJIX0PRULMbvVzU3A8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781789768; c=relaxed/simple; bh=0svQbbfDdXRqlxsJ3c+ZKTMvtpZqsLt7u4m5g38Yqe4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L51b5Rs3QVGtkxCYKELSnTIGf1V1w60QEYruaajI4B+mST1qlj8cRCN4Xts/3ouuFCryFSMXkYbYnppiQSn3GkfimOH13mbfQct4A1VSr2fPuGFMQW3Tji6adBKZ1pPBkVC2EkUG+Uf4MPzHO17k4q64yBuobeK7MQnnrQRjWBI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ITVSBphN; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ITVSBphN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68CDF1F000E9; Thu, 18 Jun 2026 13:36:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781789767; bh=Hw3Oau8GCQhDw28adaRSeAiGd/Dr4OhrJmOjv09cF60=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=ITVSBphN+wVEXQkcovLoI/+TQYN/ihMxu/wxqSuLByT61y6WOue2dHNfa1ZJfkLFk PSY5BwMk2WjFWmrv/ftjAsI11I7RMlY+k+QAmvl5f8lLUc/Hry2NpTSl2tBhHevDjb CJMbelW2D0M8BmuK7qzMtxy0WFQdr3jmQ7ME/fEa7gHFc1boDAi/O+nxzeD8Nv6+OG grZIWxufCtUUl8KSlw+e3ys2NXuFHehL4mAMWYKtOz79tu7VlFdlEosIdufKLfP38o 83znMqPlGwBLcJ+1CgbP6dqkypmGONT/6rSeYAsMabAEXvkzO6Bbi9vCuP0CiLz3LM CWjkQ0fPINkdg== Date: Thu, 18 Jun 2026 14:36:03 +0100 From: Mark Brown To: Uday Khare Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] regulator: tps6594: Fix device node reference leaks in multiphase loop Message-ID: References: <20260618132327.11529-1-udaykhare77@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9BR1zYPnJUCJJ/dI" Content-Disposition: inline In-Reply-To: <20260618132327.11529-1-udaykhare77@gmail.com> X-Cookie: This unit... must... survive. --9BR1zYPnJUCJJ/dI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 18, 2026 at 06:53:27PM +0530, Uday Khare wrote: > In tps6594_regulator_probe(), the multi-phase configuration loop calls > of_find_node_by_name() to find buck nodes by name, and of_get_parent() > twice to navigate to the PMIC parent node. None of the acquired node > references (np, intermediate parent, np_pmic_parent) are ever released > via of_node_put(), causing a reference leak on every loop iteration. You've not copied me on the rest of the series so I don't know what's going on with dependencies. When sending a patch series it is important to ensure that all the various maintainers understand what the relationship between the patches as the expecation is that there will be interdependencies. Either copy everyone on the whole series or at least copy them on the cover letter and explain what's going on. If there are no strong interdependencies then it's generally simplest to just send the patches separately to avoid any possible confusion. --9BR1zYPnJUCJJ/dI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmoz9EIACgkQJNaLcl1U h9CyeQf/d/6k71Qi1uHyutrKViysOzuX9fA3oGGBXhD2dJBfI2ORZxi0P1MojE7c lcOjoRRxjV5da/9WOgAwsmsfUPmbLMaN5hErj5iMd46Al/g3qP/9wYcGM61JI3Pt 8ByOsair+6TdEcHtsMtavIO5Q3ns9Gel0QGWFZFWL6b056lpG/WaqdtaDwYKRWAY K9XCa6rkKs0mS5FHQwGE0PbjANv1BacU6M0r6s8S5zRkABbjjynNYrgl0C27Yn7Q +VmlFV5IlQAv4rWnOuf/NDRGRNBF5UUqWftHlc/VAydph8+AhxU68ZEnZVF6Thyk brjV2TzDn2Kk8M+GW72he0u5REJnEA== =rJsE -----END PGP SIGNATURE----- --9BR1zYPnJUCJJ/dI--