From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A139334165B for ; Sat, 25 Jul 2026 01:44:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784943880; cv=none; b=OnXYyiV6E0wRpytWyvhRYI0Awu+kAe6ClYdjfu51N/RGtuyng+G8whLaJQLV2j/eV+iRUHkWv4WupH1Du34bY/i3VzRqfma6EDk6QHnP6rIlUGq1EZGmzJJlGRJj7A19NNpDJaM3NOCTHJtPMeP3OJp89Ung9+LaUC5pD+PCo7M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784943880; c=relaxed/simple; bh=IOcelKOBSM0gxgZsfOf3HFgQTLEOn2f28Em+Lgk+IlE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lzJv6xedmOnnX1v4RWZdWO7K4RYN1hE0Ks4YBXQFvwZ//AtOymAoQ2mcPGerJYB5HEopgLi66uQav0Futx1c2NeE1ZmhHaY8p4XPjXbY2z6yNiQRqyQuUQ5Kl7CMdHZLDvlAmR8ggiygYd0Yan9UyFLrDZbhJznf99MDEuXf0Bw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Pn3hkBT1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jblj0lkR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Pn3hkBT1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jblj0lkR" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66P0qOYn477169 for ; Sat, 25 Jul 2026 01:44:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wEhSsyZ5VkLfCaY4mr94Ip3RTnMNE5khCZZZxAwLa74=; b=Pn3hkBT1k/jf5WHy 1FtTlbzyxivH+0Wt6qEQymUj1IcOIAedUAgODBSxrM/dmUCV72KrOseoufu7WJPq DhN0q+429sItcYjnT2lviQ2u0IK9+6WhfI7CoHVWaSvvFgaIc1e4fZDgvaadeVtC u8V7Hv9fBdZ4de6H8Ookqtg7QwWAobgKRDHJMaP6Txz3mecEupvHEDYwfJdwohVl F2Dqf38UueiXyUZ6xxh8s3fqz9xssqQ1Vo7jy8s4nz1/LhAnyqLR6ltiCVBmS7lR dlUxDbj2StuMEICWtQAOc6UaPOqzIu/3E/qIhqenrJxdIc87baj44r/8VFubyvBT dmJ9Iw== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fmc7x1pa3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 25 Jul 2026 01:44:37 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cab041eced3so1371785a12.1 for ; Fri, 24 Jul 2026 18:44:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784943876; x=1785548676; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=wEhSsyZ5VkLfCaY4mr94Ip3RTnMNE5khCZZZxAwLa74=; b=jblj0lkRiOdFa7eGieOw1gQboUe/uX9khh48Tcp7eokr8pqhZ+zvY4s/CWKQGS4HPg tUDXBWhs64tsm98yaGe4p9QCdhOE1xNAXxc2cR7rBCOxbMIllCr4q0JxcSAhivyNpDeG Nc6p1G/LCYGz8oX/e8f2OMJyfxEOfaP7nxiRXxB5VT1T74Mgus0CduItmH79fxLVpA4g rTsskb+T7Vok0sAmaVCFopFWZjOVT0Zdy+aQlDn9gKyUTi1u0AruK9HOgVFISe7U7GEa ySbB+3Mh8oPabKrNEHrVgEqj5BuTyjwUZRPPrRWM1Q/wKGhb1PVksFqadSxxsVk7Dr7T o01g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784943876; x=1785548676; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wEhSsyZ5VkLfCaY4mr94Ip3RTnMNE5khCZZZxAwLa74=; b=WX/0el3dTrHQg6dEEXmbh3+Gi+t67B36mw+a+du/RDcn3E3hAHKWi0j9gZs3GIWzCp JlHJx1ezMwGwavd8zwcvpEFp/la91l2oNYGflulln+L8hBZOsNMJTO0XzcS63vnykhNR 8ZpNmAfaHwgnT7cXBrm3Dn8qLaTr59cPENVfjYpeUknx+0cRKVg4/QisiEX4MDluC8CA 40vsHPfmrhZWHGUMLtbqvKHWDmNNjxx+wLugBi//BxowQOxMlfmCNznEJBoE0NFAaJrR PCa+zH4qu0uXv1gyvEcyt3jnV990+kkJ2fNT1ZHCjY8hzIZnkTEZfub/mdEKuoWpKT1a 1cmA== X-Forwarded-Encrypted: i=1; AHgh+Roa4/w0jq75Hv1PPC3VZ5D1sRORy1smvQq+VzeqRs9kpwpnkib6oA0vuwQOxYiIS7koA87G/0LYHuHM7Aw=@vger.kernel.org X-Gm-Message-State: AOJu0Yzc4JBXficdJKjrKvXDrF2Y5ntCu+8xMG4IMkESOB1wDQavDJsN TnAXXLRdH8iiCodWibNlrVXlYexjuf8pKgpljIRrQKs2PVeV+GVP4ECT3SlLZcwIi7c4GkgL853 ks3LtDdrNrRDBsM9DWzXnQN0oqOpwEWV1Sz/aKTXC4fz1GG/R9U3B07ID1jtYt1s6c9c= X-Gm-Gg: AR+sD10IGKNwRa0Y8GH5tKiWO8rk1ELkFkOrehrex81rKebTNMzrL8PbXPFsow8Kqrj XJRfTo3d/3o+5B91dxO2GIXkHJhU71r/KkSLnRZKg0AxHnRKpkkQew5CFz8jVDVO4SrhZT5qo9n GRHCIejckZIuNdrkO+mXayQLAj/VgwzfjWWH/WZTxSdak4xLlfB3Y7DpGzJbZ5jm8eCPRiUOT5v HJMBXqTjWMvbcOJ8kpuJG4kpLUKWJmO4MRR4Xp0fwbAj6ahUv5S8l+rUNpg9S6gGyJrqaUtwSob 2QherahD5gxtPurlkOo+KJrrloC9I/1C2qm3lNvNgCT0XhzU1omhf5pRifr24jGV0gPtWIhUcyp xeD8rD0mw5/3lLk1JmltoxjHncDQO4SMyiHcMhdvtW/HbEhzQEHn6WOGa+Q== X-Received: by 2002:a05:6a21:3983:b0:3c0:9c19:6590 with SMTP id adf61e73a8af0-3c67e3bc33amr649607637.74.1784943876116; Fri, 24 Jul 2026 18:44:36 -0700 (PDT) X-Received: by 2002:a05:6a21:3983:b0:3c0:9c19:6590 with SMTP id adf61e73a8af0-3c67e3bc33amr649584637.74.1784943875574; Fri, 24 Jul 2026 18:44:35 -0700 (PDT) Received: from [192.168.1.11] (15.sub-75-218-246.myvzw.com. [75.218.246.15]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc5a04b2sm3989098eec.28.2026.07.24.18.44.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2026 18:44:35 -0700 (PDT) Message-ID: Date: Fri, 24 Jul 2026 18:44:33 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] wifi: ath11k: fix resource leak on error in ext IRQ setup To: ZhaoJinming , Baochen Qiang , Jeff Johnson Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260723013818.393470-1-zhaojinming@uniontech.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20260723013818.393470-1-zhaojinming@uniontech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: xB1J6dS4kliGfJGUhYXJvcmkhzkRHnaW X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI1MDAxMyBTYWx0ZWRfX18bk5KtTPfGs kdcJdE550HoYD3G1I6fSPcyav2prI99TM2MDx8m+F9Wh5vSJNT3OBLsSXfkE9MN/MVRv32SWKrV mEdsOknblkatxSZvypmJd/8CY1gSfVk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI1MDAxMyBTYWx0ZWRfXwXMvituwgEHb NdwWEsVExyKy9SRZ4GT2TPkRtIHHjUCOIbzf9oH2agWroD4oMBoiIDYljvH/KEDDFZoKyYgXcPd 6oHAElgNjOMCdBRLGW8lEiptVqs9cw89YI6VOIgxKqDPsoUAUQLc0JjZfM9JNGLEW8ZB5e3M/wd g/4va0CmzBgDB8mEiA9ZI1+QAV/5uDdOEkLzG/KMPBvp3vL2r5DM1biCPezSg4wPct+PGvaaY33 ZcbjXn0v/LDdm9kQaTGm9QRLnye+WE+Tlvy8Pu9+SpI+NnKCqrFCgVCKNvBqDt7607FC/Hc2mqy 3q8BO7a/GdC+NJra+OskYgzpaVeMEfQM9690DtJuMBuxTjBhE8ndWHWPxTPQnWmrOCoPlNEFVnf R3HNQLPMMUNpQA77DWUkwrVlQsXMaV7PtBMmdS7Nz4Bofis8FHLc3pkP0/Cz8OBKIJUwfJR6G8C IymmrxsbPAyrijo+R7A== X-Proofpoint-ORIG-GUID: xB1J6dS4kliGfJGUhYXJvcmkhzkRHnaW X-Authority-Analysis: v=2.4 cv=bOUm5v+Z c=1 sm=1 tr=0 ts=6a641505 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=6VQYfvmiyQ8t40WkS/mQdw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=blo6l0yq89oDT-NQHXUA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-25_01,2026-07-24_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 suspectscore=0 clxscore=1015 adultscore=0 spamscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607250013 On 7/22/2026 6:38 PM, ZhaoJinming wrote: > +static void ath11k_ahb_free_ext_irq_grp(struct ath11k_base *ab, > + struct ath11k_ext_irq_grp *irq_grp) checkpatch says: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis No need to resend for this -- I can fix this when I pick up the patch (but if you need to post a v6 then please fix) /jeff