mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicholas Fraser <nfraser@codeweavers.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Ian Rogers <irogers@google.com>,
	"Frank Ch. Eigler" <fche@redhat.com>,
	Song Liu <songliubraving@fb.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Kim Phillips <kim.phillips@amd.com>,
	Tommi Rantala <tommi.t.rantala@nokia.com>,
	Remi Bernon <rbernon@codeweavers.com>,
	linux-kernel@vger.kernel.org
Cc: Ulrich Czekalla <uczekalla@codeweavers.com>,
	Huw Davies <huw@codeweavers.com>
Subject: [PATCH 2/2] perf buildid-cache: Add test for 16-byte build-id
Date: Tue, 16 Feb 2021 15:38:08 -0500	[thread overview]
Message-ID: <c08be235-7434-5208-5f21-e8c9a3265464@codeweavers.com> (raw)
In-Reply-To: <d1c87379-8837-a5e7-eb44-f063ca0f4766@codeweavers.com>

tests/shell/buildid.sh added an ELF executable with an MD5 build-id to
the perf debug cache but did not check whether the object was printed
by a subsequent call to "perf buildid-cache -l". It was being omitted
from the list.

A previous commit fixed the bug that left it out of the list. This adds
a test for it.
---
 tools/perf/tests/shell/buildid.sh | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tools/perf/tests/shell/buildid.sh b/tools/perf/tests/shell/buildid.sh
index 4861a20edee2..de02a23b7c7b 100755
--- a/tools/perf/tests/shell/buildid.sh
+++ b/tools/perf/tests/shell/buildid.sh
@@ -50,6 +50,12 @@ check()
 		exit 1
 	fi
 
+	${perf} buildid-cache -l|grep $id
+	if [ $? -ne 0 ]; then
+		echo "failed: ${id} is not reported by \"perf buildid-cache -l\""
+		exit 1
+	fi
+
 	echo "OK for ${1}"
 }
 
-- 
2.30.1



  parent reply	other threads:[~2021-02-16 20:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 19:17 [PATCH 0/4] perf: Fix archive/debugcache PE files Nicholas Fraser
2021-02-16 20:37 ` [PATCH 1/2] perf report: Remove redundant libbfd checks Nicholas Fraser
2021-02-16 21:05   ` Nicholas Fraser
2021-02-16 21:06     ` [PATCH 2/2] perf buildid-cache: Add test for 16-byte build-id Nicholas Fraser
2021-02-17 19:53       ` Jiri Olsa
2021-02-18 19:39   ` [PATCH 1/2] perf report: Remove redundant libbfd checks Arnaldo Carvalho de Melo
2021-02-18 19:42     ` Nicholas Fraser
2021-02-18 19:45       ` Arnaldo Carvalho de Melo
2021-02-16 20:38 ` Nicholas Fraser [this message]
2021-02-16 21:04   ` [PATCH 2/2] perf buildid-cache: Add test for 16-byte build-id Nicholas Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c08be235-7434-5208-5f21-e8c9a3265464@codeweavers.com \
    --to=nfraser@codeweavers.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=fche@redhat.com \
    --cc=huw@codeweavers.com \
    --cc=irogers@google.com \
    --cc=jolsa@redhat.com \
    --cc=kim.phillips@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rbernon@codeweavers.com \
    --cc=songliubraving@fb.com \
    --cc=tommi.t.rantala@nokia.com \
    --cc=uczekalla@codeweavers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome