mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aditya Chillara <aditya.chillara@oss.qualcomm.com>
To: Daniel Wade <danjwade95@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	James Clark <james.clark@linaro.org>,
	Kyle Zeng <kylebot@openai.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: Reject group leaders detached by CPU hot-unplug
Date: Tue, 17 Nov 2026 12:18:12 +0530	[thread overview]
Message-ID: <c0922a29-7a2c-4606-b479-5dc6e76ff2d6@oss.qualcomm.com> (raw)
In-Reply-To: <20261116081248.21059-1-danjwade95@gmail.com>

On 11/16/2026 1:42 PM, Daniel Wade wrote:
> When a CPU goes offline, __perf_event_exit_context() removes every event
> of that CPU's context with DETACH_GROUP. That clears PERF_ATTACH_GROUP and
> PERF_ATTACH_CONTEXT and leaves the event in PERF_EVENT_STATE_OFF, or in
> ERROR, while the file descriptor stays open and event->ctx keeps pointing
> at the per-CPU context; nothing re-attaches it when the CPU comes back.
> Commit fa091f46c383 ("perf: Reject exited events as group leaders")
> fixed the same defect for remove-on-exec, by rejecting a leader in a
> state <= PERF_EVENT_STATE_EXIT. OFF and ERROR are both above EXIT, so
> once the CPU is online again a leader detached by hot-unplug is still
> accepted and perf_group_attach() links the new event to it.
> 
> perf_group_detach() returns early when PERF_ATTACH_GROUP is already
> clear, which is right for the double detach it was written for, where no
> group is left to break up. With a sibling added after the hot-unplug
> detach it skips a sibling_list which is no longer empty: the leader is
> freed with that sibling still on it and still pointing at it through
> ->group_leader. Closing the sibling, or a group read or ioctl on it, then
> uses the freed event.
> 
> Commit 42c5ca1f0a28 ("perf/core: Fix group leader use-after-free after
> sibling detach") fixed the mirror image, a sibling detached by hot-unplug
> and the leader closed afterwards. It promotes the sibling from the paths
> below that early return, so a leader detached first and given a sibling
> afterwards still reaches the same free.
> 
> Reproduced on v7.4-rc2, which contains that commit, with KASAN in a
> two-CPU guest, as root:
> 
>   BUG: KASAN: slab-use-after-free in perf_event_update_time
>   Call Trace:
>    perf_event_update_time
>    __event_disable
>    __perf_remove_from_context
>    event_function
>   Freed by task 149 from an RCU callback queued by
>   perf_event_release_kernel(), via perf_release() and __fput().
> 

Great find! Just for clarification and my reference:

A typical failing sequence is:

  - A group contains leader L and sibling S.

  - CPU hot-unplug detaches S and then L with DETACH_GROUP, which
    dismantles the group. 42c5ca1f0a28 ("perf/core: Fix group leader
    use-after-free after sibling detach") resets S->group_leader to S
    so that if L is freed, a PERF_IOC_FLAG_GROUP perf_ioctl() on S
    does not dereference the then stale S->group_leader.

  - The CPU comes back online and sets cpuctx->online = 1, which
    allows perf_event_open() on that CPU again.

  - perf_event_open() with group_fd = L attaches a new sibling S' to L,
    so S'->group_leader points to L.

  - L is closed; perf_group_detach() returns early because L is
    already detached, so the group is not dismantled, S' stays linked
    to L, and L is freed.

  - Closing S', or a PERF_IOC_FLAG_GROUP perf_ioctl() on it, follows
    S'->group_leader and dereferences the freed L.

> Opening a CPU event needs CAP_PERFMON or perf_event_paranoid below 1, so
> an ordinary user cannot reach this on a default configuration.
> 
> Reject a leader that is no longer attached to its context, rather than
> promoting siblings of a detached leader in perf_group_detach(): the early
> return there is right, and the anomaly is a leader on no context taking
> new siblings for a group that can never be scheduled. Test
> PERF_ATTACH_CONTEXT, which only the __perf_remove_from_context() path
> clears, so every detached leader is covered whatever state it is left in,
> and test it under ctx->mutex, where the leader is already known to share
> this context and every detach path holds that mutex across the removal.
> 
> One open that works today fails as well: adding a hardware event to a
> detached, pure software leader takes the move_group path, which installs
> the leader again before the new event is linked to it, so that group was
> valid. Events removed by hot-unplug are not scheduled again, which the
> commit in the Fixes tag relies on, so it now gets ENODEV like any other
> open on a detached leader.
> 
> Fixes: 226424eee809 ("perf: Fix corruption of sibling list with hotplug")
> Signed-off-by: Daniel Wade <danjwade95@gmail.com>
> Cc: stable@vger.kernel.org

Reviewed-by: Aditya Chillara <aditya.chillara@oss.qualcomm.com>

Thank you,
Aditya


      reply	other threads:[~2026-11-17  6:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  8:12 Daniel Wade
2026-11-17  6:48 ` Aditya Chillara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0922a29-7a2c-4606-b479-5dc6e76ff2d6@oss.qualcomm.com \
    --to=aditya.chillara@oss.qualcomm.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=danjwade95@gmail.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=kylebot@openai.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®