From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3304FC4361B for ; Fri, 18 Dec 2020 10:09:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5BAA23A51 for ; Fri, 18 Dec 2020 10:09:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733168AbgLRKJY (ORCPT ); Fri, 18 Dec 2020 05:09:24 -0500 Received: from smtprelay0091.hostedemail.com ([216.40.44.91]:34894 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1733048AbgLRKJX (ORCPT ); Fri, 18 Dec 2020 05:09:23 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 821BB18026431; Fri, 18 Dec 2020 10:08:42 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: rock88_2b13b822743c X-Filterd-Recvd-Size: 2292 Received: from XPS-9350.home (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf19.hostedemail.com (Postfix) with ESMTPA; Fri, 18 Dec 2020 10:08:40 +0000 (UTC) Message-ID: Subject: Re: [PATCH] staging: most: video: fixed a parentheses coding style issue. From: Joe Perches To: David Laight , Daniel West , "gregkh@linuxfoundation.org" Cc: "hverkuil-cisco@xs4all.nl" , "mchehab+huawei@kernel.org" , "christian.gromm@microchip.com" , "masahiroy@kernel.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Date: Fri, 18 Dec 2020 02:08:39 -0800 In-Reply-To: References: <20201217234501.351725-1-daniel.west.dev@gmail.com> <04c331f6bfce57c253cb86208ebd28f6363e04c0.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-12-18 at 09:49 +0000, David Laight wrote: > From: Joe Perches > > Sent: 17 December 2020 23:58 > > > > On Thu, 2020-12-17 at 15:45 -0800, Daniel West wrote: > > > Fixed a coding style issue. > > > > It may pass checkpatch without warning, but it's uncommon kernel coding style. > > checkpatch probably shouldn't complain about lines that end in ( > if they are function definitions. Opinons vary. Very few function declaration/definitions in the linux kernel use the one line per argument style (gnu indent -bfde) type function( type argument1, type argument2, ... ) { ... } It probably shouldn't be encouraged. > > or (> 80 columns) > > static struct most_video_dev *get_comp_dev(struct most_interface *iface, int channel_idx) > Or shorten the variable/type names a bit so it all fits. Always a possibility but probably not a good one here as even renaming channel_idx to idx doesn't make it < 80 columns