From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751177AbdFBOEN (ORCPT ); Fri, 2 Jun 2017 10:04:13 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:58203 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751135AbdFBOEM (ORCPT ); Fri, 2 Jun 2017 10:04:12 -0400 Subject: Re: [PATCH] net: phy: marvell: make two functions static To: Andrew Lunn References: <20170602111424.31287-1-colin.king@canonical.com> <20170602140014.GK12261@lunn.ch> Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org From: Colin Ian King Message-ID: Date: Fri, 2 Jun 2017 15:04:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170602140014.GK12261@lunn.ch> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/06/17 15:00, Andrew Lunn wrote: > On Fri, Jun 02, 2017 at 12:14:24PM +0100, Colin King wrote: >> From: Colin Ian King >> >> functions m88e1510_get_temp_critical and m88e1510_get_temp_alarm can be >> made static as they not need to be in global scope. >> >> Cleans up sparse warnings: >> "symbol 'm88e1510_get_temp_alarm' was not declared. Should it be static?" >> "symbol 'm88e1510_get_temp_critical' was not declared. Should it be >> static?" > > Hi Colin > > What about m88e1510_get_temp_alarm()? That should also have a static. Ah, good point, I somehow missed that one. I'll send a V2 Colin > > Thanks > Andrew > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >