From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D287C433F5 for ; Sun, 12 Sep 2021 12:14:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56E0061108 for ; Sun, 12 Sep 2021 12:14:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235119AbhILMPm (ORCPT ); Sun, 12 Sep 2021 08:15:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229635AbhILMPl (ORCPT ); Sun, 12 Sep 2021 08:15:41 -0400 Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [IPv6:2001:67c:2050::465:102]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9297AC061574; Sun, 12 Sep 2021 05:14:26 -0700 (PDT) Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:105:465:1:4:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4H6pSb1XdvzQk2Y; Sun, 12 Sep 2021 14:14:23 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hauke-m.de; s=MBO0001; t=1631448860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hGo8RfjlaGE86RKp2Ugs8LU5kd9WCcFlCQqfgA32Exs=; b=zSsFaBQlFXVY6UYv6l7EZyjUN00u/dGl4AqKupz185pEKnCg/O5qJOQxmB+yS7ZWyMC0dY wX9Fzy+BmFPhL6OjM6+T2D5UEzjn/ciFbmDltdm3iY1jfShSPnqXoMUtMiXWOZie4g3n8U WZTDrB7aDloiJfGFV65cB7C1KSPLgeODirJlhBVuVstu9/hJOaF8xzH/RVJ8jrBbqn60Z9 MTX+olgdgOVh/4B+lgtUH1Sz30eeTov7ZIVrEA9XrB4YFLUQz6LLj6AsUhXvmz6HhhQvrq oDbNUEpkySLB6fAynO0+cRwnqODxAJ4r0cBZ4guHeQyUMA8ygYJ0K4U3tEA9/g== Subject: Re: [net,v2] net: dsa: lantiq_gswip: Add 200ms assert delay To: Aleksander Jan Bajkowski , andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Martin Blumenstingl References: <20210912115807.3903-1-olek2@wp.pl> From: Hauke Mehrtens Message-ID: Date: Sun, 12 Sep 2021 14:14:16 +0200 MIME-Version: 1.0 In-Reply-To: <20210912115807.3903-1-olek2@wp.pl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3995626C Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/12/21 1:58 PM, Aleksander Jan Bajkowski wrote: > The delay is especially needed by the xRX300 and xRX330 SoCs. Without > this patch, some phys are sometimes not properly detected. > > The patch was tested on BT Home Hub 5A and D-Link DWR-966. > > Fixes: a09d042b0862 ("net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330") > Signed-off-by: Aleksander Jan Bajkowski > Signed-off-by: Martin Blumenstingl Acked-by: Hauke Mehrtens > --- > drivers/net/dsa/lantiq_gswip.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c > index 64d6dfa83122..267324889dd6 100644 > --- a/drivers/net/dsa/lantiq_gswip.c > +++ b/drivers/net/dsa/lantiq_gswip.c > @@ -1885,6 +1885,12 @@ static int gswip_gphy_fw_load(struct gswip_priv *priv, struct gswip_gphy_fw *gph > > reset_control_assert(gphy_fw->reset); > > + /* The vendor BSP uses a 200ms delay after asserting the reset line. > + * Without this some users are observing that the PHY is not coming up > + * on the MDIO bus. > + */ > + msleep(200); > + > ret = request_firmware(&fw, gphy_fw->fw_name, dev); > if (ret) { > dev_err(dev, "failed to load firmware: %s, error: %i\n", >