From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAE76364EB6 for ; Thu, 2 Apr 2026 11:17:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775128634; cv=none; b=T5FpW+rssX5UP0QJLyH66KFXEi+1yAta/wDoPBvLI70+OZMpozrM/UpEPZP8IFEkV+q6fwXlLb7Ep/3pKhiRAZCxJshNN9kAJXpc7MfXHn9gqTkVoNBJ81ze2cXGa0MuGjkVXV0maCO9ICnWkvdMP1uv0SyUI5bUvt4edKXKnY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775128634; c=relaxed/simple; bh=ZTxCNY3HZlQxWzT/XhybbngDtPXeM9/mHZE+xe6f8uQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qO22o3f2l25qY2HNZx7e5qwUSUo4O0JpS3zr2m+ukZVuWIh4O0trZ9A2tp2yGcn6QbbLWXguLEsYGNDqlmZxNXsSuWIwrqlg5GC1ccVO5GW3/SBpffmnmaRR78xnbaMpsS9tK61t4J2GaJYfLdeDK/EROR9JITxRRsBebgjqBXc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Nx+uhBkZ; arc=none smtp.client-ip=209.85.208.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Nx+uhBkZ" Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-38cbfb1322aso447351fa.3 for ; Thu, 02 Apr 2026 04:17:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1775128626; x=1775733426; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=8CTLIiuy4GwEXuXqqFRnPUythaJJJv+IJU5B35u3XdE=; b=Nx+uhBkZdOtyYft2LbXPdI9r1V9PPg3MUbkuVjvMcYgfwgk/m88qHa7tr+LobkYGXW br3QTQD/bn/1XxBJDibpS7ToCRAbaqgxmZIiVz/hdp93W1iGMrFc5WPUnAmVkUvPznVp ZXqMjTImnRlJh78gm348mvqD2s8IvNMJKWRy4SuCBaJlnhPMR9ZQyTtov+I+uRWPe/AS rtCbCIM69oDOK4TZQkZCeF2VPVJA60BZrN+1JR4I0rrBv1uiakQyQO0RQx5plaI6cgZr zEbNd0vBf5dq//AeCrt82PWnWXTm4DHWLANE1VUsI+VZ7RED1CKWGWviM/T+1xg0uXEJ xtdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775128626; x=1775733426; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8CTLIiuy4GwEXuXqqFRnPUythaJJJv+IJU5B35u3XdE=; b=NhQPRq9qISraq5z3wPs/sS69W2c3mmJEya/NOHLkfb70hQE6D3w4+aHPIB9Z4aA5ZS j7Ow+lCxTtQX4aMYL6RhcyTfthg4Mshfp7NsuvWpOn4dWsfQm7vTF5yOZogRuaeStRgH L5I9D7kEZBqPgsP/xlYLQwI3GK9nOp2AhfozplxYOAAPgJm/koqkdla4t2kFNId31HPz /THCUwAKzf+v2yCHzdvczAGLfou0m1isakzzgKU/N6DPLh50THzUFL7bhnmYAPhJMq+q tNRfA6pzFFDlbefOjkeasYdNGzPqWlvcj1lPddpofmcWfpgxwOIfqVzG6pk+I5PvyOtE ZDBQ== X-Forwarded-Encrypted: i=1; AJvYcCUQdXzjAiKrlAsPB12bb+7RU6IxVBjAwhet+j++H8LuAutYc7W3cNIB6S66joZPe7RoCm6KgFdNN7wYeJQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyjMoSXGRU1w9wdvALWhQ0DeF5q7t44rtCKdDRJZdblKaNUKnq4 A4R4aSOtBC8gLBFK2O685CNNPKQbGzYc+E+jjOV1fTYWG3dYkq4QneGAQwyXptMQr7o= X-Gm-Gg: ATEYQzx2W/dlBAu6gAlCSMMa+3LU0jDZyEA8JbM1+z4z34SF56icpckbkX46jfN+96H STaAnUHGjr0r66CsTnPZ3TtGmWJDZw/a/CVRWu1ewrHnaFhxTz/tj3JsQ/Pf1n/VnF2y8Qpt+48 C+VBIRd1Hwg1VY0pdktV718wS3GtFh6gLmhYBm6na9o3pDz23qnifYy/izIDGAejpyTjeV56FlV T+NqNwzEwaZZ1eP47DchIJOCOE7vrdkJkTWiIIcuc4ZVeAUAwJ/HmQu4pfDr2p5x3J5GhzozXjq tDar9ZA+lhZzPvhX05KgNbL/4kMyEcN1ZPiGIXMBg9UBi2QnwB8dfBSQJj/WbI19KxGe8yBy17N CckqinqxMBd+MZ/3C1RSi17lzck5M4iN44MGntZ/9UnsBRSnDENDyDlOIYmD9adhaemkmEBtVNd tOh/8RV1bCHzBU7amoWuaFVCoyRP6NvBGNgoqBN/APHaPJG0DSlEW3O4X54e/TGqxHdDPLzpZ3i 0ksNA== X-Received: by 2002:a05:6512:39d3:b0:5a2:b53b:a457 with SMTP id 2adb3069b0e04-5a2c1f27b2cmr1333288e87.3.1775128626156; Thu, 02 Apr 2026 04:17:06 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a2c6cc8417sm617709e87.41.2026.04.02.04.17.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Apr 2026 04:17:05 -0700 (PDT) Message-ID: Date: Thu, 2 Apr 2026 14:16:58 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] arm64: dts: qcom: sdm845-shift-axolotl: Enable sdcard To: david@ixit.cz, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dylan Van Assche Cc: linux-arm-msm@vger.kernel.org, Petr Hodina , Casey Connolly , Dmitry Baryshkov , Alexander Martinz , Konrad Dybcio , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20260402-axolotl-misc-p1-v3-0-8934e9db6831@ixit.cz> <20260402-axolotl-misc-p1-v3-1-8934e9db6831@ixit.cz> From: Vladimir Zapolskiy In-Reply-To: <20260402-axolotl-misc-p1-v3-1-8934e9db6831@ixit.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/2/26 12:54, David Heidelberg via B4 Relay wrote: > From: Casey Connolly > > The SHIFT6mq features an sdcard slot, add it. > > Signed-off-by: Casey Connolly > Reviewed-by: Konrad Dybcio > Co-developed-by: David Heidelberg > Signed-off-by: David Heidelberg > --- > arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 44 +++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts > index 740eb22550724..b05f04a621e5b 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts > @@ -600,6 +600,24 @@ &qupv3_id_1 { > status = "okay"; > }; > > +&sdhc_2 { > + pinctrl-0 = <&sdc2_default_state &sdc2_card_det_n>; If card detection is broken and disabled, then likely card detection GPIO can be omitted, no? > + pinctrl-names = "default"; > + > + vmmc-supply = <&vreg_l21a_2p95>; > + vqmmc-supply = <&vreg_l13a_2p95>; > + > + bus-width = <4>; > + /* > + * Card detection is broken, but because the battery must be removed > + * to insert the card, we use this rather than the broken-cd property > + * which would just waste CPU cycles polling. > + */ > + non-removable; > + > + status = "okay"; > +}; > + > &slpi_pas { > firmware-name = "qcom/sdm845/SHIFT/axolotl/slpi.mbn"; > > @@ -609,6 +627,32 @@ &slpi_pas { > &tlmm { > gpio-reserved-ranges = <0 4>, <81 4>; > > + sdc2_default_state: sdc2-default-state { > + clk-pins { > + pins = "sdc2_clk"; > + drive-strength = <16>; > + bias-disable; > + }; > + > + cmd-pins { > + pins = "sdc2_cmd"; > + drive-strength = <10>; > + bias-pull-up; > + }; > + > + data-pins { > + pins = "sdc2_data"; > + drive-strength = <10>; > + bias-pull-up; > + }; > + }; > + > + sdc2_card_det_n: sd-card-det-n-state { > + pins = "gpio126"; > + function = "gpio"; > + bias-disable; > + }; > + > sde_dsi_active: sde-dsi-active-state { > pins = "gpio6", "gpio11"; > function = "gpio"; > -- Best wishes, Vladimir