From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 10D3D2FC869; Mon, 18 Aug 2025 08:10:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755504646; cv=none; b=a1eh/eu/8VlpXtGE+YxykVcrNQXORv1SHgmMEqaADsv33qPsHTwWq2q4EnUIgBdQG2kQp/Zsval0gZJmQ3MErszBFuf7oHStVsua8ae35rL7flCUOp9AFSZa8/G3NkLqSbTn3r3zIOrtCcQ2u+wQfb6VD4T6ICWgTFmMZkIew7g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755504646; c=relaxed/simple; bh=rTPslaTDUAs47CsYS6djkjgqvnvRgbpSeyDSRLp0Tjg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rqn0lL9RVpJDSptIEE23wA7BTpEl2fSPmnjc+jFH8UzUgi2ApEIf1mUgpeACXj/th/HoMyJnoK4N+11Ckly8JftYB1iEr0oj6Nh/R+9EwB+SME4B2WB/OubX+arJVhirAH88LMK8H5GKGF5ee8gJzZ4gfl2LhIhLqKCEZRGuUiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A5491596; Mon, 18 Aug 2025 01:10:36 -0700 (PDT) Received: from [10.57.58.12] (unknown [10.57.58.12]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C2E943F63F; Mon, 18 Aug 2025 01:10:38 -0700 (PDT) Message-ID: Date: Mon, 18 Aug 2025 10:10:36 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/8] selftests/mm: Add -Wunreachable-code and fix warnings To: Muhammad Usama Anjum , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jason Gunthorpe , John Hubbard , Peter Xu , Leon Romanovsky , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, Shuah Khan Cc: kernel@collabora.com References: <20250731160132.1795351-1-usama.anjum@collabora.com> <20250731160132.1795351-2-usama.anjum@collabora.com> Content-Language: en-GB From: Kevin Brodsky In-Reply-To: <20250731160132.1795351-2-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 31/07/2025 18:01, Muhammad Usama Anjum wrote: > [...] > > diff --git a/tools/testing/selftests/mm/pkey_sighandler_tests.c b/tools/testing/selftests/mm/pkey_sighandler_tests.c > index b5e076a564c95..302fef54049c8 100644 > --- a/tools/testing/selftests/mm/pkey_sighandler_tests.c > +++ b/tools/testing/selftests/mm/pkey_sighandler_tests.c > @@ -41,7 +41,7 @@ static siginfo_t siginfo = {0}; > * syscall will attempt to access the PLT in order to call a library function > * which is protected by MPK 0 which we don't have access to. > */ > -static inline __always_inline > +static __always_inline Thanks for this, I had this fix locally but never got to post it! > long syscall_raw(long n, long a1, long a2, long a3, long a4, long a5, long a6) > { > unsigned long ret; > diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c > index 05de1fc0005b7..a85b2e393e4e8 100644 > --- a/tools/testing/selftests/mm/split_huge_page_test.c > +++ b/tools/testing/selftests/mm/split_huge_page_test.c > @@ -296,10 +296,8 @@ void split_file_backed_thp(int order) > ksft_exit_fail_msg("Unable to create a tmpfs for testing\n"); > > status = snprintf(testfile, INPUT_MAX, "%s/thp_file", tmpfs_loc); > - if (status >= INPUT_MAX) { > + if (status >= INPUT_MAX) > ksft_exit_fail_msg("Fail to create file-backed THP split testing file\n"); > - goto cleanup; At that point the mount() call has succeeded so I think we do want to keep the goto and just print the error message instead of calling replace ksft_exit_fail_msg(). - Kevin > - } > > fd = open(testfile, O_CREAT|O_RDWR, 0664); > if (fd == -1) {