From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Yin Tirui <yintirui@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Cc: Lorenzo Stoakes <ljs@kernel.org>, Dev Jain <dev.jain@arm.com>,
Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
Ryan Roberts <ryan.roberts@arm.com>,
Nico Pache <nico.pache@linux.dev>,
Usama Arif <usama.arif@linux.dev>,
"Liam R . Howlett" <liam@infradead.org>,
wangkefeng.wang@huawei.com, chenjun102@huawei.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 0/9] mm/huge_memory: refactor __split_huge_pmd_locked()
Date: Fri, 11 Sep 2026 18:51:08 +0200 [thread overview]
Message-ID: <c09fb2ac-58b9-4b17-be2d-38bf7fa8fbb9@kernel.org> (raw)
In-Reply-To: <cover.1787941780.git.yintirui@gmail.com>
On 8/28/26 20:33, Yin Tirui wrote:
> __split_huge_pmd_locked() currently decides from the VMA --
> vma_is_anonymous(), then vma_is_special_huge() -- before inspecting the PMD
> entry, so split and zap can classify the same PMD differently. The entry
> itself should decide. The function also mixes the present and non-present
> cases, resulting in duplicated code.
>
> This series uses the PMD entry and its folio to decide how to handle each
> PMD, as zap_huge_pmd() does. It separates the present and non-present paths
> and moves their common work into helper functions. After this change,
> __split_huge_pmd_locked() only selects the appropriate helper.
I skimmed over some of the patches and there seems to be valuable cleanups in
there. As the MM list is right now extremely busy, I won't be able to review
this right now, so unfortunately this will have to wait.
--
Cheers,
David
prev parent reply other threads:[~2026-09-11 16:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 18:33 Yin Tirui
2026-08-28 18:33 ` [PATCH RFC 1/9] mm/huge_memory: read the huge PMD entry once when splitting it Yin Tirui
2026-08-28 18:33 ` [PATCH RFC 2/9] mm/huge_memory: add and use huge_zero_pmd_can_split() Yin Tirui
2026-08-28 18:33 ` [PATCH RFC 3/9] mm/huge_memory: add and use unmap_huge_pmd_entry() Yin Tirui
2026-08-28 18:33 ` [PATCH RFC 4/9] mm/huge_memory: use normal_or_softleaf_folio_pmd() in the PMD split path Yin Tirui
2026-09-12 7:37 ` Lance Yang
2026-09-13 5:21 ` Lance Yang
2026-08-28 18:33 ` [PATCH RFC 5/9] mm/huge_memory: dispatch on the folio when splitting a huge PMD Yin Tirui
2026-08-28 18:33 ` [PATCH RFC 6/9] mm/huge_memory: add and use split_huge_pmd_anon_rmap() Yin Tirui
2026-08-28 18:33 ` [PATCH RFC 7/9] mm/huge_memory: add struct split_pmd_state Yin Tirui
2026-08-28 18:33 ` [PATCH RFC 8/9] mm/huge_memory: split present and non-present huge PMDs separately Yin Tirui
2026-08-28 18:33 ` [PATCH RFC 9/9] mm/huge_memory: unify the migration and device private PTE loops Yin Tirui
2026-09-11 16:51 ` David Hildenbrand (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c09fb2ac-58b9-4b17-be2d-38bf7fa8fbb9@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=chenjun102@huawei.com \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=nico.pache@linux.dev \
--cc=ryan.roberts@arm.com \
--cc=usama.arif@linux.dev \
--cc=wangkefeng.wang@huawei.com \
--cc=yintirui@gmail.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®