From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DA7B34E764 for ; Wed, 16 Sep 2026 14:56:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789570588; cv=none; b=D5ecan+P2xLtiQq9yX0GaVoAOwgIY31nD71D4zmBdA6KJW6KUNH18J3/zpDcfZGCxBOBsyywdg0WRpGbJZH+Q21xtewA9Vf1zm1xlqMOylSdP7yrzVaJitoHRPuxuyRKuLFhAGywibN66O3QmM15CXLBwc5y4Wdd/r93emsURAI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789570588; c=relaxed/simple; bh=w5hmfYQd5qS6jmp5if4MTfMkG4gKJAqCpM+ctVlrJx8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=akqsoJSZTW/g3Tzj0YqKNOS+ABOgpv6M2KGSO3fqRZR64OxeX26PzkFk9oukgsUM1sAbDNmX9M2ESgOPzDl/yffCt9sDSn002wCsaEdO6tXIxliTxaX4xrkHyl0DJ3Yn//a1ucFOrRiaOIg7vnDQIsPZOAog7NJCtjAZzDOVQG8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gpsB+0pX; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gpsB+0pX" Received: by mail-pj2-f13.google.com with SMTP id d9443c01a7336-2d747f05ffcso6932535ad.0 for ; Wed, 16 Sep 2026 07:56:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789570587; x=1790175387; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=fOtt4epAjEgetEW4Rf7UpxEkjN1u8RJ270fhKCbRhRQ=; b=gpsB+0pXhV5Fpk8oz8ZAIm1e0F4oG/SJmYb8KutcgEoeU5P5gRBEKrOTTOmuVSszWx /sgU9r4nBZP6Ne3OZjTW0ZJNsMaGgR3HYblsJ8JyO9V/bcATeox1PrPLWL6XihGJ12Xo U0gemKPW3fIh5pvfnbrYk9orM+IzDKn3hN/2A8Luoc73QZpAITuQ/U+Lyp6AghAt13P9 323JOe8rt8BB0Q+5IpCDQnnVOJFFN83tHNSt4D2xayA7VQCOxZOiMEpijOypzwSjrMRu CV0YVG+9j8Y507nBIm4Hp1LmqNh9sKlMnulMvMb1wWKZlzj0Bhg/MU8TkUgHnkhDvyYw YQpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789570587; x=1790175387; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fOtt4epAjEgetEW4Rf7UpxEkjN1u8RJ270fhKCbRhRQ=; b=MtFFrpu6VreHV8VKFQ67HocziHw6NJ9bJNaRlbQ1/hHveQsNLkHOS76mhKeCqXMDBK jrM66vfWR8B4BghQBBDvVaWOVeoI5hx0v56Zi4REYE/+1nv5fm/1zlA2XshQA9ODc1gK 8Z7BWI4CWiu/TChkQ/eMvzuLersIK0+do6aa0cdLf3ki4Bxa9jyR85F7LsPkoqwxdTVu jXTZE1WL2KVKSi3kPGw41c1UbdDJ/rY04aIQDlzABu65z9eY9IqyBxWIJ/6iCQqPM87X cY6a1lx6xOt92bdq+jZIAwjjZvYfstz0E118/uajCoDvpRXwG2U8hfdSRSI5EkXqW8AW 0MMQ== X-Forwarded-Encrypted: i=1; AKwUvBxW5wL7A17TwjvA0Kt/MUqI6gBBxoE5ry4tnggxG9F81rzoARcl900wmX7/KLrU25Z9Wqv7v6w3rZ7+nUI=@vger.kernel.org X-Gm-Message-State: AFuF++louQR3oZeP9pB2ZqqoUoOQIdEPgnHRNvPmhTlK+RnAk841Pw5u /DYQBl81s6hL+HLGIgPyzaDCX80h7R9vaEBqp6v+R5r1j+/8q9nqJ1tE X-Gm-Gg: AYBFou1hgSQTZddR3kBr/oH/U3lkEVz1lnkJPZy6pRTbg0ORENeeNP+aAkK4fctmw5+ /how5HOi/14GYtLtxoIS2yAcFUYpHX6U2//vBgRxeFd07OXQwnG2T7DItgs0ZXJUIjuGeANf9jS Ndk3GfBa6dLWmXIcfPj6j/n38klLdBsqKaoZTMpw+k49AyY6WKr001hC19CytyLd9CxNGe8kDse 8Wl2fDenO5RLychYMJqX0JlDfCO2S5FekbMFqZuUO9sqS80aQykuwD6w2RdystmuTjdnYsDt1xK 3loK6CQHHWiMMrUKiHekV/I0JhZLRATCGhF3BdKulCodNgWO38M2jrjiZA1a9sQE5EcCwL6WNyK 0KsJc1J1bVH2212FWToXRBLlNZNzC8da1UocQAQjlsnohi9MbwgZf/+8NXjzaZ1b4R5QiXQ9tGK IFs200FrLTkrxfBgV+rIJaYjgr8h1L5OpzJYI7E/8iOFx6G/cNFTMDv3loYaF/U+jMDXFW7Tio/ TkN+n0JeRfg X-Received: by 2002:a17:902:d588:b0:2dd:7593:8634 with SMTP id d9443c01a7336-2dd8e412565mr65993445ad.13.1789570586585; Wed, 16 Sep 2026 07:56:26 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2dd89d8fe00sm13413325ad.12.2026.09.16.07.56.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 07:56:26 -0700 (PDT) Sender: Guenter Roeck Date: Wed, 16 Sep 2026 07:56:25 -0700 From: Guenter Roeck To: "Pradhan, Sanman" Cc: Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "linux-hwmon@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sanman Pradhan , "stable@vger.kernel.org" Subject: Re: [PATCH v2 1/3] hwmon: (pmbus/tps53679) Fix TPS53676 phase page decoding Message-ID: References: <20260915164823.160977-1-sanman.pradhan@hpe.com> <20260915164823.160977-2-sanman.pradhan@hpe.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260915164823.160977-2-sanman.pradhan@hpe.com> On Tue, Sep 15, 2026 at 04:48:35PM +0000, Pradhan, Sanman wrote: > From: Sanman Pradhan > > tps53676_identify() reads the USER_DATA_03 phase configuration to count > the phases assigned to each channel and derive the number of PMBus pages. > In each 16-bit phase descriptor the channel (PAGE) is encoded in bit 4 and > the firing order in bits 3:0, but the code tested bit 3 (0x08), which is > part of the firing-order field. > > TPS53676 supports up to seven phases, so firing-order bit 3 is never set. > As a result the existing test classifies every enabled phase as channel A. > On a dual-channel configuration the phases assigned to channel B are > therefore miscounted as channel A and page 1 is not exposed. > > Test the PAGE field (bit 4) instead. > > Fixes: cb3d37b59012 ("hwmon: (pmbus/tps53679) Add support for TI TPS53676") > Cc: stable@vger.kernel.org > Signed-off-by: Sanman Pradhan Applied. I'll fix the other problem separately. Thanks, Guenter