mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: ChenMiao <chenmiao.ku@gmail.com>,
	Linux Kernel	 <linux-kernel@vger.kernel.org>,
	Linux OpenRISC <linux-openrisc@vger.kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>, Jonas Bonn <jonas@southpole.se>,
	 Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
	Stafford Horne <shorne@gmail.com>,
	Peter Zijlstra	 <peterz@infradead.org>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Jason Baron	 <jbaron@akamai.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ard Biesheuvel	 <ardb@kernel.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Nicolas Schier	 <nicolas.schier@linux.dev>,
	Sahil Siddiq <sahilcdq0@gmail.com>,
		linux-doc@vger.kernel.org
Subject: Re: [PATCH v4 4/4] openrisc: Add jump label support
Date: Thu, 04 Sep 2025 12:07:14 +0200	[thread overview]
Message-ID: <c0a6f1960a39ca6cc84764614cfd8ccb0afc24f9.camel@sipsolutions.net> (raw)
In-Reply-To: <20250904100109.688033-5-chenmiao.ku@gmail.com> (sfid-20250904_120203_780907_7229F626)

Hi,

So I'm not quite sure why I'm CC'ed, nor do I really care much, but
since I was idly reading through it anyway ...

> +		if (unlikely(offset < -134217728 || offset > 134217724)) {
> +			WARN_ON_ONCE(true);
> +		}

Seems like that should just be

	WARN_ON_ONCE(offset < -134217728 || offset > 134217724);

since the unlikely is in there already.

> +	if (early_boot_irqs_disabled) {
> +		copy_to_kernel_nofault(addr, &insn, sizeof(insn));
> +	} else {
> +		patch_insn_write(addr, insn);
> +	}

(and maybe that doesn't need braces)

johannes

  reply	other threads:[~2025-09-04 10:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-04 10:00 [PATCH v4 0/4] openrisc: Support basic trace mechanism ChenMiao
2025-09-04 10:00 ` [PATCH v4 1/4] openrisc: Add text patching API support ChenMiao
2025-09-05 17:15   ` Stafford Horne
2025-09-04 10:00 ` [PATCH v4 2/4] openrisc: Add R_OR1K_32_PCREL relocation type module support ChenMiao
2025-09-05 17:14   ` Stafford Horne
2025-09-04 10:00 ` [PATCH v4 3/4] openrisc: Regenerate defconfigs ChenMiao
2025-09-05 17:13   ` Stafford Horne
2025-09-04 10:00 ` [PATCH v4 4/4] openrisc: Add jump label support ChenMiao
2025-09-04 10:07   ` Johannes Berg [this message]
2025-09-04 10:19     ` Miao Chen
2025-09-05 17:12   ` Stafford Horne
2025-09-05 17:16 ` [PATCH v4 0/4] openrisc: Support basic trace mechanism Stafford Horne
2025-09-05 17:38   ` Chen Miao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0a6f1960a39ca6cc84764614cfd8ccb0afc24f9.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ardb@kernel.org \
    --cc=chenmiao.ku@gmail.com \
    --cc=corbet@lwn.net \
    --cc=jbaron@akamai.com \
    --cc=jonas@southpole.se \
    --cc=jpoimboe@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-openrisc@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=nicolas.schier@linux.dev \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sahilcdq0@gmail.com \
    --cc=shorne@gmail.com \
    --cc=stefan.kristiansson@saunalahti.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®