From: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: tomm.merciai@gmail.com, linux-renesas-soc@vger.kernel.org,
biju.das.jz@bp.renesas.com,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Douglas Anderson <dianders@chromium.org>,
Adam Ford <aford173@gmail.com>,
Jesse Van Gavere <jesseevg@gmail.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/bridge: adv7511: Do not merge adv7511_mode_set() with atomic_enable()
Date: Mon, 26 May 2025 11:21:44 +0200 [thread overview]
Message-ID: <c0aa1d6f-4a2e-455f-b458-1b679beefe0f@bp.renesas.com> (raw)
In-Reply-To: <CAMuHMdVMDd2abFFzMY_Rbm=7pnX5C2qHBsa68tF_c=bRnp3zkg@mail.gmail.com>
Hi Geert,
Thanks for your comment.
On 26/05/25 11:13, Geert Uytterhoeven wrote:
> Hi Tommaso,
>
> On Mon, 26 May 2025 at 10:55, Tommaso Merciai
> <tommaso.merciai.xr@bp.renesas.com> wrote:
>> After adv7511_mode_set() was merged into .atomic_enable(), only the
>> native resolution is working when using modetest.
>>
>> This is caused by incorrect timings: adv7511_mode_set() must not be
>> merged into .atomic_enable().
>>
>> Move adv7511_mode_set() back to the .mode_set() callback in
>> drm_bridge_funcs to restore correct behavior.
>
> Thanks for your patch!
>
>> Fixes: 0a9e2f0a6466 ("drm/bridge: adv7511: switch to the HDMI connector helpers")
>
> I can't find that commit? I guess you mean:
> Fixes: ae01d3183d2763ed ("drm/bridge: adv7511: switch to the HDMI
> connector helpers")
Yes, sorry.
You are completely right!
https://cgit.freedesktop.org/drm/drm-misc/commit/drivers/gpu/drm/bridge/adv7511?id=ae01d3183d2763ed27ab71f4ef5402b683d9ad8a
>
> Gr{oetje,eeting}s,
>
> Geert
>
Thanks & Regards,
Tommaso
next prev parent reply other threads:[~2025-05-26 9:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-26 8:54 Tommaso Merciai
2025-05-26 9:13 ` Geert Uytterhoeven
2025-05-26 9:21 ` Tommaso Merciai [this message]
2025-05-26 9:24 ` Biju Das
2025-05-26 9:26 ` Maxime Ripard
2025-05-26 9:58 ` Tommaso Merciai
2025-05-26 10:49 ` Laurent Pinchart
2025-05-26 11:19 ` Tommaso Merciai
2025-05-26 11:40 ` Maxime Ripard
2025-05-26 13:18 ` Dmitry Baryshkov
2025-05-26 14:02 ` Tommaso Merciai
2025-05-26 14:13 ` Tommaso Merciai
2025-05-26 14:28 ` Laurent Pinchart
2025-05-26 16:43 ` Tommaso Merciai
2025-05-27 10:11 ` Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0aa1d6f-4a2e-455f-b458-1b679beefe0f@bp.renesas.com \
--to=tommaso.merciai.xr@bp.renesas.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=aford173@gmail.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=jernej.skrabec@gmail.com \
--cc=jesseevg@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tomm.merciai@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®