From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750802AbdAXG3U (ORCPT ); Tue, 24 Jan 2017 01:29:20 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:54592 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703AbdAXG3T (ORCPT ); Tue, 24 Jan 2017 01:29:19 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 156186084B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCH] drm: bridge: dw-hdmi: fix building without CONFIG_OF To: Arnd Bergmann References: <20170123122312.3290934-1-arnd@arndb.de> Cc: David Airlie , Laurent Pinchart , Jose Abreu , Daniel Vetter , Philipp Zabel , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org From: Archit Taneja Message-ID: Date: Tue, 24 Jan 2017 11:59:09 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20170123122312.3290934-1-arnd@arndb.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/23/2017 05:50 PM, Arnd Bergmann wrote: > The of_node member in struct drm_bridge is hidden when CONFIG_OF > is disabled, causing a build error: > > drivers/gpu/drm/bridge/dw-hdmi.c: In function '__dw_hdmi_probe': > drivers/gpu/drm/bridge/dw-hdmi.c:2063:14: error: 'struct drm_bridge' has no member named 'of_node' > > We could fix this either using a Kconfig dependency on CONFIG_OF > or making the one line conditional. The latter gives us better > compile test coverage, so this is what I'm doing here. > > Fixes: 69497eb9234e ("drm: bridge: dw-hdmi: Implement DRM bridge registration") > Signed-off-by: Arnd Bergmann Thanks for fixing this, queued to drm-misc. Archit > --- > drivers/gpu/drm/bridge/dw-hdmi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c > index 4fda0717e789..9a9ec27d9e28 100644 > --- a/drivers/gpu/drm/bridge/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/dw-hdmi.c > @@ -2060,7 +2060,9 @@ __dw_hdmi_probe(struct platform_device *pdev, > > hdmi->bridge.driver_private = hdmi; > hdmi->bridge.funcs = &dw_hdmi_bridge_funcs; > +#ifdef CONFIG_OF > hdmi->bridge.of_node = pdev->dev.of_node; > +#endif > > ret = dw_hdmi_fb_registered(hdmi); > if (ret) > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project