Re: [PATCH v16 6/7] sched: Fix proxy/current (push,pull)ability

[K Prateek Nayak <kprateek.nayak@amd.com>]

Hello John,

On 4/12/2025 11:32 AM, John Stultz wrote:
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index ad45a8fea245e..eb07c3a1b8fa4 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -2166,6 +2166,9 @@ static void enqueue_task_dl(struct rq *rq, struct task_struct *p, int flags)
>   	if (dl_server(&p->dl))
>   		return;
>   
> +	if (task_is_blocked(p))
> +		return;
> +
>   	if (!task_current(rq, p) && !p->dl.dl_throttled && p->nr_cpus_allowed > 1)
>   		enqueue_pushable_dl_task(rq, p);
>   }

Do we need an early return in put_prev_task_dl() similar to the one in
put_prev_task_rt()?

> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index fa03ec3ed56a2..87ccd5d5375a3 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -1477,6 +1477,9 @@ enqueue_task_rt(struct rq *rq, struct task_struct *p, int flags)
>   
>   	enqueue_rt_entity(rt_se, flags);
>   
> +	if (task_is_blocked(p))
> +		return;
> +
>   	if (!task_current(rq, p) && p->nr_cpus_allowed > 1)
>   		enqueue_pushable_task(rq, p);
>   }
> @@ -1757,6 +1760,8 @@ static void put_prev_task_rt(struct rq *rq, struct task_struct *p, struct task_s
>   
>   	update_rt_rq_load_avg(rq_clock_pelt(rq), rq, 1);
>   
> +	if (task_is_blocked(p))
> +		return;
>   	/*
>   	 * The previous task needs to be made eligible for pushing
>   	 * if it is still active

-- 
Thanks and Regards,
Prateek