From: Dmitry Osipenko <digetx@gmail.com>
To: Sowjanya Komatineni <skomatineni@nvidia.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Mantravadi Karthik <mkarthik@nvidia.com>,
Shardar Mohammed <smohammed@nvidia.com>,
Timo Alho <talho@nvidia.com>
Cc: "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH V3 2/3] i2c: tegra: Update transfer timeout
Date: Tue, 29 Jan 2019 01:08:28 +0300 [thread overview]
Message-ID: <c0b36535-6767-7327-5dc5-612e6957a769@gmail.com> (raw)
In-Reply-To: <BYAPR12MB3398E9D32B57B0E2FC2A6466C2960@BYAPR12MB3398.namprd12.prod.outlook.com>
28.01.2019 21:28, Sowjanya Komatineni пишет:
>
>
>>> Update I2C transfer timeout based on transfer bytes and I2C bus rate
>>> to allow enough time during max transfer size based on the speed.
>>
>> Could it be that I2C device is busy and just slowly handling the transfer requests? Maybe better to leave the timeout as-is and assume the worst case scenario?
>>
> This change includes min transfer time out of 100ms in addition to computed timeout based on transfer bytes and speed which can account in cases of slave devices running at slower speed.
> Also Tegra I2C Master supports Clock stretching by the slave.
Okay, I suppose in reality this shouldn't break anything.
Please explain what benefits this change brings. Does it fix or improve anything? The commit message only describes changes done in the patch and has no word on justification of those changes. Transfer timeout is an extreme case that doesn't happen often and when it happens, usually only the fact of timeout matters. If there is no real value in shortening of the timeout, why bother then?
next prev parent reply other threads:[~2019-01-28 22:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-26 3:57 [PATCH V3 1/3] i2c: tegra: Sort all the include headers alphabetically Sowjanya Komatineni
2019-01-26 3:57 ` [PATCH V3 2/3] i2c: tegra: Update transfer timeout Sowjanya Komatineni
2019-01-26 18:02 ` Dmitry Osipenko
2019-01-28 18:28 ` Sowjanya Komatineni
2019-01-28 22:08 ` Dmitry Osipenko [this message]
2019-01-28 22:15 ` Sowjanya Komatineni
2019-01-28 22:27 ` Dmitry Osipenko
2019-01-28 22:31 ` Sowjanya Komatineni
2019-01-29 10:15 ` Thierry Reding
2019-01-29 10:16 ` Thierry Reding
2019-01-29 11:21 ` Dmitry Osipenko
2019-01-26 3:57 ` [PATCH V3 3/3] i2c: tegra: Add DMA Support Sowjanya Komatineni
2019-01-26 17:11 ` Dmitry Osipenko
2019-01-26 18:16 ` Dmitry Osipenko
2019-01-26 17:29 ` Dmitry Osipenko
2019-01-26 20:42 ` Dmitry Osipenko
2019-01-26 21:24 ` Dmitry Osipenko
2019-01-28 23:47 ` Sowjanya Komatineni
2019-01-29 2:02 ` Sowjanya Komatineni
2019-01-29 3:11 ` Dmitry Osipenko
2019-01-26 17:29 ` [PATCH V3 1/3] i2c: tegra: Sort all the include headers alphabetically Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0b36535-6767-7327-5dc5-612e6957a769@gmail.com \
--to=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkarthik@nvidia.com \
--cc=skomatineni@nvidia.com \
--cc=smohammed@nvidia.com \
--cc=talho@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®