mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Yeoreum Yun <yeoreum.yun@arm.com>
Cc: catalin.marinas@arm.com, pcc@google.com, will@kernel.org,
	anshuman.khandual@arm.com, joey.gouly@arm.com,
	yury.khrustalev@arm.com, maz@kernel.org, oliver.upton@linux.dev,
	frederic@kernel.org, akpm@linux-foundation.org,
	surenb@google.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v6 2/9] arm64: report address tag when FEAT_MTE_TAGGED_FAR is supported
Date: Wed, 11 Jun 2025 12:43:18 +0100	[thread overview]
Message-ID: <c0b4dc8a-b37c-4e8e-be2e-bc8906615702@sirena.org.uk> (raw)
In-Reply-To: <20250611094107.928457-3-yeoreum.yun@arm.com>

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

On Wed, Jun 11, 2025 at 10:41:00AM +0100, Yeoreum Yun wrote:

> +HWCAP3_MTE_FAR
> +    Functionality implied by ID_AA64PFR2_EL1.MTEFAR == 0b0001.

> +Applications should interpret the values of these bits based on
> +the support for the 'mte_far' hwcap. If the support is not present,
> +the values of these bits should be considered as undefined otherwise valid.

The constant is HWCAP3_MTE_FAR and the cpuinfo is mtefar:

> +	[KERNEL_HWCAP_MTE_FAR]		= "mtefar",

The reference to the hwcap should probably be one of these, I'd go for
HWCAP3_MTE_FAR since it says hwcap.

>  	/*
>  	 * The architecture specifies that bits 63:60 of FAR_EL1 are UNKNOWN
>  	 * for tag check faults. Set them to corresponding bits in the untagged
> -	 * address.
> +	 * address if ARM64_MTE_FAR isn't supported.
> +	 * Otherwise, bits 63:60 of FAR_EL1 are KNOWN.

Should this say UNKNOWN?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2025-06-11 11:43 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-11  9:40 [PATCH v6 0/9] support FEAT_MTE_TAGGED_FAR feature Yeoreum Yun
2025-06-11  9:40 ` [PATCH v6 1/9] arm64/cpufeature: add " Yeoreum Yun
2025-06-11  9:41 ` [PATCH v6 2/9] arm64: report address tag when FEAT_MTE_TAGGED_FAR is supported Yeoreum Yun
2025-06-11 11:43   ` Mark Brown [this message]
2025-06-11 12:19     ` Yeo Reum Yun
2025-06-11 12:35       ` Mark Brown
2025-06-11 13:16         ` Yeoreum Yun
2025-06-11  9:41 ` [PATCH v6 3/9] tools/kselftest: add MTE_FAR hwcap test Yeoreum Yun
2025-06-11  9:41 ` [PATCH v6 4/9] kselftest/arm64/mte: register mte signal handler with SA_EXPOSE_TAGBITS Yeoreum Yun
2025-06-11 11:45   ` Mark Brown
2025-06-11  9:41 ` [PATCH v6 5/9] kselftest/arm64/mte: check MTE_FAR feature is supported Yeoreum Yun
2025-06-11 11:52   ` Mark Brown
2025-06-11 12:23     ` Yeo Reum Yun
2025-06-11  9:41 ` [PATCH v6 6/9] kselftest/arm64/mte: add address tag related macro and function Yeoreum Yun
2025-06-11 11:58   ` Mark Brown
2025-06-11 12:25     ` Yeo Reum Yun
2025-06-11 12:37       ` Mark Brown
2025-06-11  9:41 ` [PATCH v6 7/9] kselftest/arm64/mte: add verification for address tag in signal handler Yeoreum Yun
2025-06-11 12:12   ` Mark Brown
2025-06-11 13:26     ` Yeoreum Yun
2025-06-11  9:41 ` [PATCH v6 8/9] kselftest/arm64/mte: refactor check_mmap_option test Yeoreum Yun
2025-06-11 12:27   ` Mark Brown
2025-06-11 13:28     ` Yeoreum Yun
2025-06-11  9:41 ` [PATCH v6 9/9] kselftest/arm64/mte: add mtefar tests on check_mmap_options Yeoreum Yun
2025-06-11 12:25   ` Mark Brown
2025-06-11 13:34     ` Yeoreum Yun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0b4dc8a-b37c-4e8e-be2e-bc8906615702@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=frederic@kernel.org \
    --cc=joey.gouly@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=pcc@google.com \
    --cc=surenb@google.com \
    --cc=will@kernel.org \
    --cc=yeoreum.yun@arm.com \
    --cc=yury.khrustalev@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®