From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755371AbdKBKEx (ORCPT ); Thu, 2 Nov 2017 06:04:53 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:57124 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753015AbdKBKEv (ORCPT ); Thu, 2 Nov 2017 06:04:51 -0400 Cc: Sudeep Holla , ALKML , LKML , DTML , Roy Franz , Harb Abdulhamid , Nishanth Menon , Arnd Bergmann , Loc Ho , Alexey Klimov , Ryan Harkin , Jassi Brar , Michael Turquette , linux-clk@vger.kernel.org Subject: Re: [PATCH v3 18/22] clk: add support for clocks provided by SCMI To: Stephen Boyd References: <1506604306-20739-1-git-send-email-sudeep.holla@arm.com> <1506604306-20739-19-git-send-email-sudeep.holla@arm.com> <20171102072350.GO30645@codeaurora.org> From: Sudeep Holla Organization: ARM Message-ID: Date: Thu, 2 Nov 2017 10:04:45 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171102072350.GO30645@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/11/17 07:23, Stephen Boyd wrote: > On 09/28, Sudeep Holla wrote: >> On some ARM based systems, a separate Cortex-M based System Control >> Processor(SCP) provides the overall power, clock, reset and system >> control. System Control and Management Interface(SCMI) Message Protocol >> is defined for the communication between the Application Cores(AP) >> and the SCP. >> >> This patch adds support for the clocks provided by SCP using SCMI >> protocol. >> >> Cc: Michael Turquette >> Cc: Stephen Boyd >> Cc: linux-clk@vger.kernel.org >> Signed-off-by: Sudeep Holla >> --- > > Acked-by: Stephen Boyd > Thanks >> MAINTAINERS | 2 +- >> drivers/clk/Kconfig | 10 +++ >> drivers/clk/Makefile | 1 + >> drivers/clk/clk-scmi.c | 210 +++++++++++++++++++++++++++++++++++++++++++++++++ >> 4 files changed, 222 insertions(+), 1 deletion(-) >> create mode 100644 drivers/clk/clk-scmi.c >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 23ec3471f542..32c184391aee 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -12941,7 +12941,7 @@ M: Sudeep Holla >> L: linux-arm-kernel@lists.infradead.org >> S: Maintained >> F: Documentation/devicetree/bindings/arm/arm,sc[mp]i.txt >> -F: drivers/clk/clk-scpi.c >> +F: drivers/clk/clk-sc[mp]i.c > > Is there a lot of copy/paste going on from clk-scpi.c? Maybe it > could be consolidated? > Not much apart from the usual driver skeleton. Also SCPI specification will not be enhanced any further while SCMI will be. So they will deviated in the feature set going further. Even I was thinking of merging then together initially but based on some WIP changes to the specification, I thought it may not be good idea. But if we think it can be merged in future , I will do that for sure(for easy maintenance) -- Regards, Sudeep