From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.182 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794704416; b=1IEn2ZWXvXxJ20ikxxJ9riaKQ0HCtHRQX6C7kl3hD7PkoxTLdBJfKoxCg9ZIybJlmeWz qszx5yYk5jmAm6kB7ldTjrpI/n++KB6dlFr5oiFHLyRmDiDhcqklatq1o5CEBP424WDek iFdc9qIUxgSMrrimP8UYqEtJ6FzT/V0zd+GyovSXNzNp507SMIs4hZ36TgoUlCkaIPvhn bXtFXXL5r5QiyL6bJ+6P7MLo7earMgSiMvKez6WwlumhtfMrifgZWwdzvonnfHVGcumpq tO6fIFnhWpp7iAtd3hZ7A9Fyq1YuzgiqF8F6DZ0gE0HMFSxBaCmUGK0VnbghrWhxmQQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794704416; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Reply-To:Subject: Content-Language:To:Cc:References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=5JVcksrPn6+Ig6tuNU22o2qjR3uSsPz6hcIi+8PBA4g=; b=Z3H76qRhhhCa1jdXAeHffu00P1UXdQsfk5bk6N8xoFjFrkJ7lgJGZs/FHOt5cLtczmWS Ute+Ldbz0Ci/6zXlLQyK7St3br2Vfucp3foDb/sNvndg8Oaf1t6h0jd8A6m97q5cVT+BS GA9oyvdaNJvsrhsh9rSFDoPkjqyB77JOEuAVQXdZ9HTz2Lohf3+2CHYULEif9vlOybceC Jn/MPAiK/SWD38Bta1+zIHvAXQYqOEVlpeW5MUleWKmXAFYW8yJn2nfNfl9pNXbkPtE4e X6zG6X57CuuTIfQ/CbEyYvkXb0eJSmCz/I7DHGkvAXeUXYOA1/piGRljujoz7kkxm9A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=XcrRPS93; arc=none smtp.remote-ip=74.125.82.182 Received: from mail-dy1-f182.google.com (mail-dy1-f182.google.com [74.125.82.182]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D520F606A331 for ; Sun, 15 Nov 2026 01:00:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D520F606A331 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=XcrRPS93 Received: by mail-dy1-f182.google.com with SMTP id 5a478bee46e88-36dbde64409so3370789eec.0 for ; Sat, 14 Nov 2026 17:00:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794704414; x=1795309214; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:reply-to:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5JVcksrPn6+Ig6tuNU22o2qjR3uSsPz6hcIi+8PBA4g=; b=XcrRPS936P40vJno3XvqyDp8fAli9TuND9KYSi1V5lmSwLiBH63p01bDAcdtZA4bTX J/W9I4NXICyt47rJfltq6+b8mnoNn5sCp1YIjAjkpT9u5Uq0y6ipNma8gZPZn+k1AUdY z+fOIkNd+wcVt5uX2/wOLwR8dQN9cgCwc9KvVOlp7KrLJwqEGJLar9ZdARuOoIe3VvHT CiHYsCOxpMRDw4MP9d3JbSzEONnWzYdpfjGvRxRSWlE1W+CyGw/dHDcxOAcO1Lv8fXxC OEnkpOWaEGBrRwsieMLA9wlrMVLqI1ceO084+uugzp4XTcYP4wip3TWr4R2VBgYf+ooz DX9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794704414; x=1795309214; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:reply-to:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5JVcksrPn6+Ig6tuNU22o2qjR3uSsPz6hcIi+8PBA4g=; b=IGQxHiXoVVOyf0etpK8Yme0KP4Yf4or/szWz/TWciENAYvqSyfi/GE9xtEWRPCI/Bb js8+2vSfvjD8YF0IaikPZCMT6JhgOXClOsRwYHj+8M/1LQrVAuFXdhpS6ABB1QTgJUm4 J8zNj/pOCcNUgOYPloEgDoxzgUvKyrCrD4dU0fuzkGsYNtgRWoNW9ESmgWA7+3X2lGsz UyvOJcbPn68CCT5JbSsikdTw0LbOZIKsDnpjJLgxEa4ZLobSJD+JTcopr7yL+qabI9Dl lYTg/18LaroU5Hip8ilcrS9Nfiten9zOFVE4m2vE8LBkaBneCO/MW9k0gACehXdF+yA1 BEzQ== X-Forwarded-Encrypted: i=1; AL+hErEcPOQP7xz3QagD3QrSqQmGnRf/tV/X4Vo6+48xMKYt+KgTC2lko4AdL9ANsuISWcDNaeE5MQ2VuPLHjhg=@vger.kernel.org X-Gm-Message-State: APuU4Z+sF6ZFwMYrKVDnntMWvdCYgjbBQwPAfOyTiGuNYUMbIOAVxXlq B/zpkQQPt+NSQKsnBxvbwugoHAUT8rDa4/Pw204G53gtpWM1UbbT84dS X-Gm-Gg: AYBFou3bQ5ikdRrkiURb6aRM9PeuRTNMVHPRCBGWyVvInas5kmh2Rt1hI2LyLReJIPU bMsAA4gexo8wW5n59pYfD3REMnVhu3XhimHJfuJheOtpNRaj0ld4U0RM7sG83otKCv5AI5s3bYT lcV9LF5OvlfS4vQgS4Q+cg+fl1Rxj8bpCl0/x3WYDD0KC4nvg0byfs9LLxBZPTxt1UeQhw5UzD7 rMumaNsq8abLw9Wc9MWdswGXRwvgwXTGs6Q+XithUGh+rdIAk4MTYX+X9v2mu4rpXzr49ua8Fad nrYssyc8BRfyTlhv6T43B1lCmhYoFPs667ByJ20yiEtY333NiaLnTfQF2+Wbs0HgCPh3+P61bk2 lYnb9sqmLVYy8qzuUc1j4M6DTeudao4v4N36CLhUF8ayqKc1bjqrhxlcMxLYQ25KhXEXCWLAeYq F4kF5+32d/mICSNF4DRspksFNHzSxFe/87UeMUrtjMvqjP/ACfl9wwE5wgfnbe1sUE3CRf+/bH6 Rb9YLl6CvXCKN+V276t3AR9L+B/xPUaIESg/RXX7eQl8SHkFP79BRzojC6338hE6obO+Y4f3hP5 xLegLQtFaIDk3EgX7waYIEp617pictDR/EvhfpC72HBr2Z89SqwQVWSl+6HM8swAQzA= X-Received: by 2002:a05:7300:7481:b0:375:c5e1:931d with SMTP id 5a478bee46e88-37966e3aff8mr9267695eec.25.1794704413837; Sat, 14 Nov 2026 17:00:13 -0800 (PST) Received: from [192.168.35.43] ([218.50.238.131]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-379560f5e06sm26895445eec.19.2026.11.14.17.00.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Nov 2026 17:00:13 -0800 (PST) Message-ID: Date: Sun, 15 Nov 2026 10:00:08 +0900 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: chanwoo@kernel.org Subject: Re: [PATCH v2 7/7] PM / devfreq: rockchip-dfi: add RK3576 support Content-Language: ko To: Sebastian Reichel , Stephen Boyd , Brian Masney , Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Sascha Hauer Cc: Nicolas Frattaroli , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, kernel@collabora.com References: <20260921-b4-rockchip-dfi-rk3576-support-v2-0-04f847016321@collabora.com> <20260921-b4-rockchip-dfi-rk3576-support-v2-7-04f847016321@collabora.com> From: Choi Chanwoo In-Reply-To: <20260921-b4-rockchip-dfi-rk3576-support-v2-7-04f847016321@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/22/2026 6:15 AM, Sebastian Reichel wrote: > Add RK3576 support to the DFI driver exposing the same functionality > as found on previous chips. This uses the RK3588 init for getting the > DRAM type info from the GRF registers. In contrast to RK3588 it uses > a newer DDRMON controller IP, though (version 0x40). > > Co-developed-by: Nicolas Frattaroli > Signed-off-by: Nicolas Frattaroli > Signed-off-by: Sebastian Reichel > --- > drivers/devfreq/event/rockchip-dfi.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c > index 8ba97af78e3d..a895e566b4b9 100644 > --- a/drivers/devfreq/event/rockchip-dfi.c > +++ b/drivers/devfreq/event/rockchip-dfi.c > @@ -858,6 +858,10 @@ static const char * const rk3399_clk_names[] = { > "pclk_ddr_mon", > }; > > +static const char * const rk3576_clk_names[] = { > + "pclk_ddr_mon_ch0", "pclk_ddr_mon_ch1", > +}; > + > static const char * const rk3588_clk_names[] = { > "pclk_ddr_mon_ch0", "pclk_ddr_mon_ch1", "pclk_ddr_mon_ch2", > "pclk_ddr_mon_ch3", > @@ -887,6 +891,18 @@ static const struct rockchip_dfi_variant rk3568_variant = { > .reg_access = 0x2c, > }; > > +static const struct rockchip_dfi_variant rk3576_variant = { > + .init = rk3588_dfi_init, > + .stride = 0x10000, > + .max_channels = 2, > + .clk_names = rk3576_clk_names, > + .num_clks = ARRAY_SIZE(rk3576_clk_names), > + .reg_write_access = 0x28, > + .reg_read_access = 0x2c, > + .reg_access = 0x34, > + .reg_clock_cycles = 0x30, > +}; > + > static const struct rockchip_dfi_variant rk3588_variant = { > .init = rk3588_dfi_init, > .stride = 0x4000, > @@ -903,6 +919,7 @@ static const struct rockchip_dfi_variant rk3588_variant = { > static const struct of_device_id rockchip_dfi_id_match[] = { > { .compatible = "rockchip,rk3399-dfi", .data = &rk3399_variant }, > { .compatible = "rockchip,rk3568-dfi", .data = &rk3568_variant }, > + { .compatible = "rockchip,rk3576-dfi", .data = &rk3576_variant }, > { .compatible = "rockchip,rk3588-dfi", .data = &rk3588_variant }, > { }, > }; > Acked-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Principal Engineer, Samsung Electronics