From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751885AbdK3Ivn convert rfc822-to-8bit (ORCPT ); Thu, 30 Nov 2017 03:51:43 -0500 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:43866 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751178AbdK3Ivl (ORCPT ); Thu, 30 Nov 2017 03:51:41 -0500 From: Yan Markman To: Russell King - ARM Linux CC: Antoine Tenart , "andrew@lunn.ch" , "f.fainelli@gmail.com" , "davem@davemloft.net" , "gregory.clement@free-electrons.com" , "thomas.petazzoni@free-electrons.com" , "miquel.raynal@free-electrons.com" , "Nadav Haklai" , "mw@semihalf.com" , "Stefan Chulski" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect Thread-Topic: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect Thread-Index: AQHTaE0J1bz47nEl5EqXJeKzEHOhkKMpz+GAgAAA0ICAAeUZ0P//8SEAgAAt2KD//+jiAIAA4Y6g Date: Thu, 30 Nov 2017 08:51:21 +0000 Message-ID: References: <20171128132932.27196-1-antoine.tenart@free-electrons.com> <20171128155317.GA7974@flint.armlinux.org.uk> <20171128155611.GA8358@flint.armlinux.org.uk> <20448667430e434aad5bb8cd1b082611@IL-EXCH01.marvell.com> <20171129195911.GG8356@n2100.armlinux.org.uk> <21ec97be76d54a6c8a80fd5b56d35678@IL-EXCH01.marvell.com> <20171129212032.GI8356@n2100.armlinux.org.uk> In-Reply-To: <20171129212032.GI8356@n2100.armlinux.org.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.5.102.207] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-30_02:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1711300118 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The phylink_stop is called before phylink_disconnect_phy You could see in mvpp2.c: mvpp2_stop_dev() { phylink_stop(port->phylink); } mvpp2_stop() { mvpp2_stop_dev(port); phylink_disconnect_phy(port->phylink); } .ndo_stop = mvpp2_stop, -----Original Message----- From: Russell King - ARM Linux [mailto:linux@armlinux.org.uk] Sent: Wednesday, November 29, 2017 11:21 PM To: Yan Markman Cc: Antoine Tenart ; andrew@lunn.ch; f.fainelli@gmail.com; davem@davemloft.net; gregory.clement@free-electrons.com; thomas.petazzoni@free-electrons.com; miquel.raynal@free-electrons.com; Nadav Haklai ; mw@semihalf.com; Stefan Chulski ; netdev@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect On Wed, Nov 29, 2017 at 09:06:56PM +0000, Yan Markman wrote: > The attached p21 patch doesn't change anything. > But another one from the mail-text is good > void phylink_disconnect_phy(struct phylink *pl) > + pl->phy_state.link = false; > > There still (not for my MRVL-PP2) problem: > It is expected that on ifconfig-down the callback > pl->ops->mac_link_down(ndev, pl->link_an_mode); would be called, but > it isn't Are you calling phylink_stop() or are you just calling phylink_disconnect() ? You must call phylink_stop() prior to phylink_disconnect(). This probably explains why the p21 patch did nothing. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up