From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Niko Pasaloukos <nikolaos.pasaloukos@blaize.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: James Cowgill <james.cowgill@blaize.com>,
Matt Redfearn <matthew.redfearn@blaize.com>,
Neil Jones <neil.jones@blaize.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 3/7] dt-bindings: reset: Add binding constants for BLZP1600
Date: Wed, 24 Apr 2024 17:20:18 +0200 [thread overview]
Message-ID: <c0c3257b-7706-4055-942e-8f66678cd30d@linaro.org> (raw)
In-Reply-To: <2a3d928d-3e18-4e3a-9f5b-94dbbaaf3652@linaro.org>
On 24/04/2024 16:16, Krzysztof Kozlowski wrote:
>> +
>> +/* BLZP1600 reset numbers as defined in the hardware architecture */
>> +
>> +#define BLZP1600_A53_C0_HARD_RST 0
>> +#define BLZP1600_A53_C0_SOFT_RST 1
>> +#define BLZP1600_A53_C1_HARD_RST 2
>> +#define BLZP1600_A53_C1_SOFT_RST 3
>> +#define BLZP1600_A53_L2_CACHE_RST 4
>> +#define BLZP1600_A53_DBG_RST 5
>> +#define BLZP1600_GIC_RST 6
>> +#define BLZP1600_CRYPTO_RST 7
>> +/* reset 8 invalid */
>
> Same concerns.
>
> However another problem is lack of users of it. Your patchset looks
> random - this goes to subsustem, but there is no device binding, no
> driver, no DTS. Could be result of lack of threading. :/
And now I see my reply at v1 saying that these gaps are unexpected.
Please respond to reviewers comments either acknowledging the comment or
responding with feedback. What are these header constants representing?
Best regards,
Krzysztof
prev parent reply other threads:[~2024-04-24 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 13:32 Niko Pasaloukos
2024-04-24 14:16 ` Krzysztof Kozlowski
2024-04-24 15:20 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0c3257b-7706-4055-942e-8f66678cd30d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=james.cowgill@blaize.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.redfearn@blaize.com \
--cc=neil.jones@blaize.com \
--cc=nikolaos.pasaloukos@blaize.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®