From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-113.freemail.mail.aliyun.com (out30-113.freemail.mail.aliyun.com [115.124.30.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06AA5243956 for ; Fri, 28 Nov 2025 01:40:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.113 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764294059; cv=none; b=SJMeJPr2rvbg5I5DYUe8HhhUICyjl7Xx5ORnTK9peDDd4s3vjJpSheWW9C0HVvsqLG9SCKzvge1I19EzoLx0+2QYyBlroMM0L76Sjozt6Y2Oni2aTjXpFsYQMSx/yNzdOp/UsMx3in56uyzj3N3VQuk5Gq2Y9HaFa0zVr2T9aBA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764294059; c=relaxed/simple; bh=yhfcr2u7EpYJIzthOuFyAOrCTjS06UOm2kEJ1Ny9ofI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CkX8dcAL/s3fE6SKGM1eZhaNPKc2ECcUv9UbxH3TLFZuh6nLpY4L+sAICiq6t2WnBAvI7wLWM0LIuDvpmnCrVR+3QD713NxmAerRvNZ/MVQHG5MokeeCwYwA9bTRwqpyrufVyc0Hugg/ZSZ/J9iii8SQbmKPjxiyGPmUrC2pRpI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=nIO5wtkh; arc=none smtp.client-ip=115.124.30.113 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="nIO5wtkh" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1764294048; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=CpsoWGihg5zy3BeGFjBwgtw52Pr/CBr3dGHsUPYc2o4=; b=nIO5wtkhLBbap2LjEP53ghCMXizN3z2+i/HQmR9atCs6pKdKeB+G+rgcImOSlbPuAHm8O+v76lU5mEy8RZ1m+Sht/YgiKsh5d+f8zWyYsz+WSXNJloR7j4Dx8KBQabARbXAvoS06ybWEpMeHM0VS4dxPC2lCEqPDekFzXfv3r7A= Received: from 30.221.130.183(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0WtZNSKV_1764294047 cluster:ay36) by smtp.aliyun-inc.com; Fri, 28 Nov 2025 09:40:47 +0800 Message-ID: Date: Fri, 28 Nov 2025 09:40:46 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] erofs: get rid of raw bi_end_io() usage To: Ming Lei , Christoph Hellwig Cc: linux-erofs@lists.ozlabs.org, LKML , Stephen Zhang References: <20251127080237.2589998-1-hsiangkao@linux.alibaba.com> <20251127080756.2602939-1-hsiangkao@linux.alibaba.com> From: Gao Xiang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025/11/28 08:58, Ming Lei wrote: > On Thu, Nov 27, 2025 at 04:07:56PM +0800, Gao Xiang wrote: >> These BIOs are actually harmless in practice, as they are all pseudo >> BIOs and do not use advanced features like chaining. Using the BIO >> interface is a more friendly and unified approach for both bdev and >> and file-backed I/Os. >> >> Let's use bio_endio() instead. >> >> Signed-off-by: Gao Xiang >> --- >> v2: >> - call bio_endio() unconditionally in erofs_fileio_ki_complete(). > > bio_endio() can cover bio not submitted yet, so: > > Reviewed-by: Ming Lei Thank you and Christoph for review! Thanks, Gao Xiang