From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752861AbdKJMq6 (ORCPT ); Fri, 10 Nov 2017 07:46:58 -0500 Received: from mout.web.de ([212.227.15.14]:55376 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751018AbdKJMq4 (ORCPT ); Fri, 10 Nov 2017 07:46:56 -0500 Subject: [PATCH 1/4] ASN.1: Adjust two function calls together with a variable assignment From: SF Markus Elfring To: kernel-janitors@vger.kernel.org, Andrew Morton Cc: LKML References: <960a8501-03b0-95d9-c2bf-4633e48e73a6@users.sourceforge.net> Message-ID: Date: Fri, 10 Nov 2017 13:46:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <960a8501-03b0-95d9-c2bf-4633e48e73a6@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:vwTgO13jOah04IO+Tjw7Ub6Qv/9WYNykdLkf21GaLVFp0rlnbyw ocnK6ucxw896JfzF26uQCJA73FYZ26grWhS2GZVNouWJrfTYOMiO+iCCMiZbfLi1Rg2NXfl 5KkAyABJvNq/aG2NbU3wHus+MDXQz0MI8Oay3dQhKNxCqhRJBKmLqDlpmT9NiTmOakUp+4/ pipAGNfGnd1Oed3Rnn5ag== X-UI-Out-Filterresults: notjunk:1;V01:K0:F6yq5Tmpubg=:7n4drjIB4wTT2yZZLfxFWH 5XPwM540FF/WY2zk3qXf96jCEaK5qJy+r5q+N6/OAuDPvHM55G/ybvLrdGa6n+ntoQsTG9m21 PN/yQrJcX/2TE1e2RtKJAYdXO93taLh53VEA39dZHD0gbGkKzsf9yAyOP8kBO0ecZmz2q0lKc NQEP3Vzjx/sPjry+bU6mRBf4haxdtSZcsC/XvSsoQefsp+N0e4+BxjW8Nx3FrTJSJFm+tFvTa iR9FpkrJE1xa2s+HJTs+a6Smsk52gURvRs0k52tlBx4jatb2zQELgZWF9TcKfmXP3XuDtBToO V7BtOjoapHJu0AkMw7UXRCFJFm2US/ZmoGg6w4ST39FeppvdMFKzVC/g5KZTvo3v52zQIxjy/ O2yhZDyDETqErb33sC+Ta6fE3AHFUMTOEuFwU/TgNyDAWW07oLILWzc5R3knA5lXn4q7YGsb/ zeyuCrSkEc/L9RGnR4oj3LcLaDZhSe9zcAp9jwrv2PjVaNjOtKUHDN4DUV5L25Rgga3JJon++ 6dxo2KS00RqwhbPUngPlbUnR3grRd7jVBAfTYSlucbD+/EVlAah+yxK/W3+Dno0H//yrt9wzi 8IIxytzSCZUhVtZZ6Fp4+uqnBouxEItFMrLawy2JOIpvDGndkEZM0mLeFpptRXVcprKQQE0I5 PsLK2GnteAoBQKPn1zQXmZzfTv4uuZkigJb/7r8l4O1+3yxMCOhGM2Uj5dOkMK8tqFVQH0v8N OawywE8Vooi6m8BsYxVc0bwnoermatY2/qJsJx3+vApI2XLGUqaw9IA9e1CpUt75cR/PdVohe PCI92rrRJT5cyY7V2odwppDf1YaRTHYYuNDqWg2gKdfFi2fau4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 10 Nov 2017 10:40:17 +0100 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code places. Signed-off-by: Markus Elfring --- scripts/asn1_compiler.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/asn1_compiler.c b/scripts/asn1_compiler.c index c1b7ef3e24c1..e37e5ef3fabb 100644 --- a/scripts/asn1_compiler.c +++ b/scripts/asn1_compiler.c @@ -606,12 +606,14 @@ int main(int argc, char **argv) exit(1); } - if (!(buffer = malloc(st.st_size + 1))) { + buffer = malloc(st.st_size + 1); + if (!buffer) { perror(NULL); exit(1); } - if ((readlen = read(fd, buffer, st.st_size)) < 0) { + readlen = read(fd, buffer, st.st_size); + if (readlen < 0) { perror(filename); exit(1); } -- 2.15.0