From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3351C2B9F8 for ; Tue, 25 May 2021 11:32:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B46EC61413 for ; Tue, 25 May 2021 11:32:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231611AbhEYLdn (ORCPT ); Tue, 25 May 2021 07:33:43 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:4003 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231570AbhEYLdf (ORCPT ); Tue, 25 May 2021 07:33:35 -0400 Received: from dggems702-chm.china.huawei.com (unknown [172.30.72.60]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FqBgq3GFMzmZC4; Tue, 25 May 2021 19:29:43 +0800 (CST) Received: from dggemx753-chm.china.huawei.com (10.0.44.37) by dggems702-chm.china.huawei.com (10.3.19.179) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Tue, 25 May 2021 19:32:03 +0800 Received: from [10.136.110.154] (10.136.110.154) by dggemx753-chm.china.huawei.com (10.0.44.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 25 May 2021 19:32:03 +0800 Subject: Re: [PATCH v2 2/2] f2fs: atgc: export entries for better tunability via sysfs To: CC: , , References: <20210512020719.43685-1-yuchao0@huawei.com> From: Chao Yu Message-ID: Date: Tue, 25 May 2021 19:32:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20210512020719.43685-1-yuchao0@huawei.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.110.154] X-ClientProxiedBy: dggemx703-chm.china.huawei.com (10.1.199.50) To dggemx753-chm.china.huawei.com (10.0.44.37) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jaegeuk, could you please queue this in dev-test? On 2021/5/12 10:07, Chao Yu wrote: > This patch export below sysfs entries for better ATGC tunability. > > /sys/fs/f2fs//atgc_candidate_ratio > /sys/fs/f2fs//atgc_candidate_count > /sys/fs/f2fs//atgc_age_weight > /sys/fs/f2fs//atgc_age_threshold > > Signed-off-by: Chao Yu > --- > v2: > - limit value range of candidate_ratio and candidate_ratio in __sbi_store() > Documentation/ABI/testing/sysfs-fs-f2fs | 28 +++++++++++++++++++++++++ > fs/f2fs/sysfs.c | 27 ++++++++++++++++++++++++ > 2 files changed, 55 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs > index 4849b8e84e42..5088281e312e 100644 > --- a/Documentation/ABI/testing/sysfs-fs-f2fs > +++ b/Documentation/ABI/testing/sysfs-fs-f2fs > @@ -438,3 +438,31 @@ Description: Show the count of inode newly enabled for compression since mount. > Note that when the compression is disabled for the files, this count > doesn't decrease. If you write "0" here, you can initialize > compr_new_inode to "0". > + > +What: /sys/fs/f2fs//atgc_candidate_ratio > +Date: May 2021 > +Contact: "Chao Yu" > +Description: When ATGC is on, it controls candidate ratio in order to limit total > + number of potential victim in all candidates, the value should be in > + range of [0, 100], by default it was initialized as 20(%). > + > +What: /sys/fs/f2fs//atgc_candidate_count > +Date: May 2021 > +Contact: "Chao Yu" > +Description: When ATGC is on, it controls candidate count in order to limit total > + number of potential victim in all candidates, by default it was > + initialized as 10 (sections). > + > +What: /sys/fs/f2fs//atgc_age_weight > +Date: May 2021 > +Contact: "Chao Yu" > +Description: When ATGC is on, it controls age weight to balance weight proportion > + in between aging and valid blocks, the value should be in range of > + [0, 100], by default it was initialized as 60(%). > + > +What: /sys/fs/f2fs//atgc_age_threshold > +Date: May 2021 > +Contact: "Chao Yu" > +Description: When ATGC is on, it controls age threshold to bypass GCing young > + candidates whose age is not beyond the threshold, by default it was > + initialized as 604800 seconds (equals to 7 days). > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c > index 39b522ec73e7..dc71bc968c72 100644 > --- a/fs/f2fs/sysfs.c > +++ b/fs/f2fs/sysfs.c > @@ -37,6 +37,7 @@ enum { > #endif > RESERVED_BLOCKS, /* struct f2fs_sb_info */ > CPRC_INFO, /* struct ckpt_req_control */ > + ATGC_INFO, /* struct atgc_management */ > }; > > struct f2fs_attr { > @@ -75,6 +76,8 @@ static unsigned char *__struct_ptr(struct f2fs_sb_info *sbi, int struct_type) > #endif > else if (struct_type == CPRC_INFO) > return (unsigned char *)&sbi->cprc_info; > + else if (struct_type == ATGC_INFO) > + return (unsigned char *)&sbi->am; > return NULL; > } > > @@ -495,6 +498,20 @@ static ssize_t __sbi_store(struct f2fs_attr *a, > } > #endif > > + if (!strcmp(a->attr.name, "atgc_candidate_ratio")) { > + if (t > 100) > + return -EINVAL; > + sbi->am.candidate_ratio = t; > + return count; > + } > + > + if (!strcmp(a->attr.name, "atgc_age_weight")) { > + if (t > 100) > + return -EINVAL; > + sbi->am.age_weight = t; > + return count; > + } > + > *ui = (unsigned int)t; > > return count; > @@ -710,6 +727,11 @@ F2FS_RW_ATTR(F2FS_SBI, f2fs_sb_info, compr_written_block, compr_written_block); > F2FS_RW_ATTR(F2FS_SBI, f2fs_sb_info, compr_saved_block, compr_saved_block); > F2FS_RW_ATTR(F2FS_SBI, f2fs_sb_info, compr_new_inode, compr_new_inode); > #endif > +/* For ATGC */ > +F2FS_RW_ATTR(ATGC_INFO, atgc_management, atgc_candidate_ratio, candidate_ratio); > +F2FS_RW_ATTR(ATGC_INFO, atgc_management, atgc_candidate_count, max_candidate_count); > +F2FS_RW_ATTR(ATGC_INFO, atgc_management, atgc_age_weight, age_weight); > +F2FS_RW_ATTR(ATGC_INFO, atgc_management, atgc_age_threshold, age_threshold); > > #define ATTR_LIST(name) (&f2fs_attr_##name.attr) > static struct attribute *f2fs_attrs[] = { > @@ -778,6 +800,11 @@ static struct attribute *f2fs_attrs[] = { > ATTR_LIST(compr_saved_block), > ATTR_LIST(compr_new_inode), > #endif > + /* For ATGC */ > + ATTR_LIST(atgc_candidate_ratio), > + ATTR_LIST(atgc_candidate_count), > + ATTR_LIST(atgc_age_weight), > + ATTR_LIST(atgc_age_threshold), > NULL, > }; > ATTRIBUTE_GROUPS(f2fs); >