From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4769D2D7817 for ; Tue, 28 Apr 2026 02:28:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777343328; cv=none; b=LqT6YIsG9xsb8VXndYYPtPuZC5JoqIU315gncn5NRHce5HlW6X15KEb98FNugJKDPEPlPqMOn4GZMxyBDOvcMcT6BMQ706jQcw+QX2JBeC+ArfW/vaxMerJKEDeQxnRHTwXSLC17VJIgVgnvdtYIzK2kEzADQKun0J1zkyezp+k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777343328; c=relaxed/simple; bh=wizFbC0Fd5PGOQYPtrvBHZWYwMpeaMfcNees1Z9iPto=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kt9UbLuRD5stcNNq8EBJz1sCxlNwZr4Vh86lXOsCkR3WCpUV/4KSTZJFXEHjb1nqVI7cnWluoEiPK2RdtoleIQXsbwe96tVixy4vBf17Rhg4pdNtBuFnqvC+XeDIkyXfB5W+M/rYMH/C5KTfetFE/XGKUxft6VF3V0lcXaFW9P8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=h3aSYlyt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DRbAS4NL; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="h3aSYlyt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DRbAS4NL" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63RNl2eT3760591 for ; Tue, 28 Apr 2026 02:28:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VPzxcDFXiWrzals8bQN+wr9M8M/HVCUe6SSz/woMcQk=; b=h3aSYlytsmDR/39V +6ytcNIFPZujdq0Wb9bC47o0MwcyGknAGminCRam3kpnmk6J9NQMYp6e4WSMqjEL xbJ2h3RyCHdXIVjafoqhk2HnWnb1dJFovlMPlQE1v386PS0/UG9Nbn1Vi4fIioE5 UpUOphmEOn/OsGfgHS+9zaFVmC4JEoAg1mAzkMYQAxGTw8k7xr3jf7Bhd+ooTzOu fsmUnTl/Bwg4UBH6h15HggCtIKTX2e+kitTw6qB1rHkdFaNOMa7WYUOjryLs6VDE D2JIIwkJpHpF/huPj2zDE8SSPzHayR9KgbDurFjJAODLTm2+oPtqwuXo0k4P9O0P 6YQoBg== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dtacdt78h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 28 Apr 2026 02:28:46 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-82fa860e71eso5157870b3a.0 for ; Mon, 27 Apr 2026 19:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777343326; x=1777948126; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VPzxcDFXiWrzals8bQN+wr9M8M/HVCUe6SSz/woMcQk=; b=DRbAS4NLy0VZccbFcwfaZJHkegKL2gyg2aEjxI4S8czPOFgOhTpsBeBQYpKhC9OG4s vMqTI9M0AAXcj7qUb14IWNrq0z4j+EFZoHBqL+dDHBVPPtV25KP8sYd3ZKjconM/h6At bmH/GP/D3hOie2a4NeT5Z0qIItftop411TmjtfLkMBD0lcEEHg9QocF3oPXeptbo2k6s hPAP60X5rPE9jJHUWGrk9ixXoqp1N8Wi+kQBNsh2Xb7DL5PhkFdK/ti2NoP6CJj2VgeP Nm3M+137YInzSE8b3//XzhAER7O6bc3WNL3EfJ13sWcNYpv/MzNpL6aWs2q/I0voZojG JilQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777343326; x=1777948126; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VPzxcDFXiWrzals8bQN+wr9M8M/HVCUe6SSz/woMcQk=; b=DU8rL+wS0Qr9Ydh7zKJYUYX7fh7LyyzNgcsoG3d7KVKohrF2zcfklAQARcn7QgefZp PO+GSpTm0U2m3LDKB/ras4fNlk0ea3WVvEkl9BWo31EGLXtuqI8Iu6TDyf5Q2GE8jDO7 PwCGp01Eqcnb20+8VgwTrFRmq66iSPJ0lurV2P3MLcmczIi2gGY7CuTfXOYej4sMjuz/ G6aMpiSLEm8iCK0zeOvvyxP4OA6W++av+hgoJwaA5bl5+37pT9a976UNIzR0AAJ8iF0D 4JRqxV1KFRljYzf3Y7QpDTzdWBF51aiXhNmgSK5h69tKyhXgio9ay5j2KcyQsEfnmgh5 +8xQ== X-Forwarded-Encrypted: i=1; AFNElJ/j0rjeb1tSMt+GBpDncYIkl2ZFWkWnNp4yIhmMQT8DU2ARXQCyJb2ObSC10vXy/caBmWG9zqjZODgx/T8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxjl8G+zhf0r8qHxEJeQpkECalkiFsAMA+CdKMvQKxI1toHEm9k joD4O6gDAoEIqn/3dZhN1JoabI4qFKGlUPKG9vGJYTWxdNrJJ8IKD3TI9lgqAHBFBsk7uy1Lkb5 1Vx3l2gYxGiTG622wTjFprwfSMHgAjkFNW/E9ioOVhMeZn5gR+kLU325SJxzgB2kqrTM= X-Gm-Gg: AeBDieuLejmeFzWZgZF2ip2GoOkgpv+lIQ3nQr7WMaJePgdya0si1r3Yw3705eQ8P7c YERdDFRAQWqjyPnjHpM4kDnxopx6wap9flw4hJXbiRuir8oMsuXFPUhljn38JfNzZ16z8ic8Wlc ouXMhNrxLOj0yT29az0IImlp4STVgnTQ/vLP8QJCC/eYhHR0tExl5BVjGNhJJoabj5FibX8ONns CIuwz9RPIKd2eoUX9par8bBCO3xPuwC9dwI/kmVXdtzKoTO2cNuVIJmzV4Px20yfzCw5cTpZ1EI 7ejwpINLp3aDmIc+phCbLyrGbDPa5CAT4wQ1FcUnrIvNYZX9zLJ5R7tjJYrbJX9AkMbvWCP8c4q J/2cDfM4zE3uvZDwtcNyaPPn29jiKzS0xEZda/O++06+NmGqggR/W2qFPOtAHg1ucu/qG1zFD2V cUZVwyBLcpqQtcTFF42Py/JMwKcCELpA== X-Received: by 2002:a05:6a00:6c83:b0:82c:ae0e:dea with SMTP id d2e1a72fcca58-834ddb9f511mr1033694b3a.32.1777343325938; Mon, 27 Apr 2026 19:28:45 -0700 (PDT) X-Received: by 2002:a05:6a00:6c83:b0:82c:ae0e:dea with SMTP id d2e1a72fcca58-834ddb9f511mr1033664b3a.32.1777343325496; Mon, 27 Apr 2026 19:28:45 -0700 (PDT) Received: from [10.133.33.153] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-834daf5705fsm930726b3a.42.2026.04.27.19.28.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Apr 2026 19:28:45 -0700 (PDT) Message-ID: Date: Tue, 28 Apr 2026 10:28:41 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath11k: fix warning when unbinding To: Jose Ignacio Tornos Martinez , jjohnson@kernel.org Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260420110130.509670-1-jtornosm@redhat.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20260420110130.509670-1-jtornosm@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI4MDAyMSBTYWx0ZWRfX+ljPvivSuoCX kEKAT76etoO8uPbZuMO+lwJKH4MMvPAZaHJmDLh3mhJt6VAVbyLfEsJM22ui/wB8AdQ99W+qWyq vSACXRJaquYtY3aU7dkryW1sqKLnlEU+6GEyPZMYpSBmxPx/38HLNcyfxIBr2dtpCRBL566S8AM S7KEuYIBO0ZK7rriIR7gryVrFMy98UXU328tkiglclObL15usT8piLgOnCUl5WEuzu/BJuK5ftf WX43OCGfxyAmjXdpzetM0OCaLjiiKMl1a5z8q7h7U/Q7aJWLuju4Eq1yGRODbngKc4ypHgI2o2z HGp3Z6gM2TufLd0k1muFJOOSbkSJOZm+kyxHprghEg9kRzUV0/6SYyVRiUZhXBrGzqQXa5xHxxK HeXszRedbQyjiWYDSPGlqcUQQWezSZao5yplCVwPmRomYmyzcO5vfUmrm5qa5fRmW2POl5pe0TU 24RKIaNFxTutXMdFLmQ== X-Authority-Analysis: v=2.4 cv=QsduG1yd c=1 sm=1 tr=0 ts=69f01b5e cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=oU0rmw-L0ToDbzm52QUA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-GUID: QbZUfhCMhfzZ0wKMVqRGaK7hOgqaQXgk X-Proofpoint-ORIG-GUID: QbZUfhCMhfzZ0wKMVqRGaK7hOgqaQXgk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-27_04,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604280021 On 4/20/2026 7:01 PM, Jose Ignacio Tornos Martinez wrote: > If there is an error during some initialization related to firmware, > the buffers dp->tx_ring[i].tx_status are released. > However this is released again when the device is unbinded (ath11k_pci), > and we get: > WARNING: CPU: 0 PID: 6231 at mm/slub.c:4368 free_large_kmalloc+0x57/0x90 > Call Trace: > free_large_kmalloc > ath11k_dp_free > ath11k_core_deinit > ath11k_pci_remove > ... > > The issue is always reproducible from a VM because the MSI addressing > initialization is failing. MSI initialization runs at probe time but I don't see an error path doing dp->tx_ring[i].tx_status release. So can you help elaborate? what is the call path when the dp->tx_ring[i].tx_status is first released? > > In order to fix the issue, just set the buffers to NULL after releasing in > order to avoid the double free. > > Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") > Cc: stable@vger.kernel.org > Signed-off-by: Jose Ignacio Tornos Martinez > --- > drivers/net/wireless/ath/ath11k/dp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/ath/ath11k/dp.c b/drivers/net/wireless/ath/ath11k/dp.c > index bbb86f165141..5a50b623bd07 100644 > --- a/drivers/net/wireless/ath/ath11k/dp.c > +++ b/drivers/net/wireless/ath/ath11k/dp.c > @@ -1040,6 +1040,7 @@ void ath11k_dp_free(struct ath11k_base *ab) > idr_destroy(&dp->tx_ring[i].txbuf_idr); > spin_unlock_bh(&dp->tx_ring[i].tx_idr_lock); > kfree(dp->tx_ring[i].tx_status); > + dp->tx_ring[i].tx_status = NULL; > } > > /* Deinit any SOC level resource */