From: Sagi Grimberg <sagi@grimberg.me>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
Christoph Hellwig <hch@lst.de>,
Chaitanya Kulkarni <kch@nvidia.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Chaitanya Kulkarni <chaitanyak@nvidia.com>,
Keith Busch <kbusch@kernel.org>, Ira Weiny <ira.weiny@intel.com>
Subject: Re: [PATCH v2] nvmet-tcp: Don't kmap() pages which can't come from HIGHMEM
Date: Thu, 18 Aug 2022 14:45:49 +0300 [thread overview]
Message-ID: <c0d5e4c2-512f-3d6e-b555-8a87b1be1db5@grimberg.me> (raw)
In-Reply-To: <20220817184519.25141-1-fmdefrancesco@gmail.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Fabio, did you run blktests?
The simplest thing you can do is:
$ git clone https://github.com/osandov/blktests.git
$ cd blktests
$ nvme_trtype=tcp ./check nvme
next prev parent reply other threads:[~2022-08-18 11:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 18:45 Fabio M. De Francesco
2022-08-18 11:45 ` Sagi Grimberg [this message]
2022-08-21 15:04 ` Fabio M. De Francesco
2022-08-18 15:48 ` Chaitanya Kulkarni
2022-08-21 15:12 ` Fabio M. De Francesco
2022-08-21 5:46 ` Christoph Hellwig
2022-08-21 19:12 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0d5e4c2-512f-3d6e-b555-8a87b1be1db5@grimberg.me \
--to=sagi@grimberg.me \
--cc=chaitanyak@nvidia.com \
--cc=fmdefrancesco@gmail.com \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®