From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754072AbdBDLox (ORCPT ); Sat, 4 Feb 2017 06:44:53 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:58641 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753923AbdBDLow (ORCPT ); Sat, 4 Feb 2017 06:44:52 -0500 Subject: Re: [PATCH] Staging: iio: resolver: ad2s1210.c - style fix To: Derek Robson , lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org References: <20170204014541.30023-1-robsonde@gmail.com> Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Jonathan Cameron Message-ID: Date: Sat, 4 Feb 2017 11:44:50 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170204014541.30023-1-robsonde@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/02/17 01:45, Derek Robson wrote: > Changed symbolic permissions to octal permissions. > Found using checkpatch > > Signed-off-by: Derek Robson Applied. Thanks, Jonathan > --- > drivers/staging/iio/resolver/ad2s1210.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c > index 6b992634f009..90b57c03609c 100644 > --- a/drivers/staging/iio/resolver/ad2s1210.c > +++ b/drivers/staging/iio/resolver/ad2s1210.c > @@ -531,36 +531,36 @@ static int ad2s1210_read_raw(struct iio_dev *indio_dev, > return ret; > } > > -static IIO_DEVICE_ATTR(fclkin, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(fclkin, 0644, > ad2s1210_show_fclkin, ad2s1210_store_fclkin, 0); > -static IIO_DEVICE_ATTR(fexcit, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(fexcit, 0644, > ad2s1210_show_fexcit, ad2s1210_store_fexcit, 0); > -static IIO_DEVICE_ATTR(control, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(control, 0644, > ad2s1210_show_control, ad2s1210_store_control, 0); > -static IIO_DEVICE_ATTR(bits, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(bits, 0644, > ad2s1210_show_resolution, ad2s1210_store_resolution, 0); > -static IIO_DEVICE_ATTR(fault, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(fault, 0644, > ad2s1210_show_fault, ad2s1210_clear_fault, 0); > > -static IIO_DEVICE_ATTR(los_thrd, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(los_thrd, 0644, > ad2s1210_show_reg, ad2s1210_store_reg, > AD2S1210_REG_LOS_THRD); > -static IIO_DEVICE_ATTR(dos_ovr_thrd, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(dos_ovr_thrd, 0644, > ad2s1210_show_reg, ad2s1210_store_reg, > AD2S1210_REG_DOS_OVR_THRD); > -static IIO_DEVICE_ATTR(dos_mis_thrd, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(dos_mis_thrd, 0644, > ad2s1210_show_reg, ad2s1210_store_reg, > AD2S1210_REG_DOS_MIS_THRD); > -static IIO_DEVICE_ATTR(dos_rst_max_thrd, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(dos_rst_max_thrd, 0644, > ad2s1210_show_reg, ad2s1210_store_reg, > AD2S1210_REG_DOS_RST_MAX_THRD); > -static IIO_DEVICE_ATTR(dos_rst_min_thrd, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(dos_rst_min_thrd, 0644, > ad2s1210_show_reg, ad2s1210_store_reg, > AD2S1210_REG_DOS_RST_MIN_THRD); > -static IIO_DEVICE_ATTR(lot_high_thrd, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(lot_high_thrd, 0644, > ad2s1210_show_reg, ad2s1210_store_reg, > AD2S1210_REG_LOT_HIGH_THRD); > -static IIO_DEVICE_ATTR(lot_low_thrd, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(lot_low_thrd, 0644, > ad2s1210_show_reg, ad2s1210_store_reg, > AD2S1210_REG_LOT_LOW_THRD); > >