From: Joe Perches <joe@perches.com>
To: Peter Zijlstra <peterz@infradead.org>,
Daniel Bristot de Oliveira <bristot@redhat.com>
Cc: x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>, Marc Zyngier <maz@kernel.org>,
Peter Xu <peterx@redhat.com>, Andy Lutomirski <luto@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/irq: Use printk_deferred() on raw_spin_lock() protected sections
Date: Thu, 24 Sep 2020 09:08:57 -0700 [thread overview]
Message-ID: <c0dbf88bb7ca4d77ed0576ced82302b81aebe664.camel@perches.com> (raw)
In-Reply-To: <20200924102822.GA2628@hirez.programming.kicks-ass.net>
On Thu, 2020-09-24 at 12:28 +0200, Peter Zijlstra wrote:
> On Mon, Sep 21, 2020 at 06:22:12PM +0200, Daniel Bristot de Oliveira wrote:
> > While testing hotplug I got this BUG:
> > It was caused by printk() inside a code section protected by a
> > raw_spin_lock() that ended up calling a serial console that
> > uses a regular spin_lock().
> >
> > Use the printk_deferred() to avoid calling the serial console
> > in a raw_spin_lock() protected section.
>
> I consider printk_deferred() to be a bug, can't we just wait for the new
> printk implementation to land so we don't need all this nonsense?
It will be good to do a sed fixup for all these
printk_deferred uses soon, but in the meantime
isn't it useful to avoid BUGs?
next prev parent reply other threads:[~2020-09-24 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 16:22 Daniel Bristot de Oliveira
2020-09-24 10:28 ` Peter Zijlstra
2020-09-24 16:08 ` Joe Perches [this message]
2020-09-25 9:19 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0dbf88bb7ca4d77ed0576ced82302b81aebe664.camel@perches.com \
--to=joe@perches.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=bristot@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome