mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
To: Gokul Sriram Palanisamy <quic_gokulsri@quicinc.com>,
	<sboyd@kernel.org>, <andersson@kernel.org>,
	<bjorn.andersson@linaro.org>, <david.brown@linaro.org>,
	<devicetree@vger.kernel.org>, <jassisinghbrar@gmail.com>,
	<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-remoteproc@vger.kernel.org>, <mark.rutland@arm.com>,
	<mturquette@baylibre.com>, <ohad@wizery.com>, <robh@kernel.org>,
	<sricharan@codeaurora.org>
Cc: <gokulsri@codeaurora.org>
Subject: Re: [PATCH v9 8/8] arm64: dts: qcom: Enable Q6v5 WCSS for ipq8074 SoC
Date: Fri, 21 Jun 2024 21:39:59 +0530	[thread overview]
Message-ID: <c0dee6b8-599f-4086-87d7-cc3750b46d0a@quicinc.com> (raw)
In-Reply-To: <20240621114659.2958170-9-quic_gokulsri@quicinc.com>



On 6/21/2024 5:16 PM, Gokul Sriram Palanisamy wrote:
> Enable remoteproc WCSS PIL driver with glink. Also,
> configure shared memory and enables smp2p required for IPC.
> 
> Signed-off-by: Nikhil Prakash V <quic_nprakash@quicinc.com>
> Signed-off-by: Sricharan R <quic_srichara@quicinc.com>
> Signed-off-by: Gokul Sriram Palanisamy <quic_gokulsri@quicinc.com>
> ---
>   arch/arm64/boot/dts/qcom/ipq8074.dtsi | 80 +++++++++++++++++++++++++++
>   1 file changed, 80 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> index 92682d3c9478..b98766cce0d6 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> @@ -108,6 +108,12 @@ memory@4ac00000 {
>   			reg = <0x0 0x4ac00000 0x0 0x400000>;
>   			no-map;
>   		};
> +
> +		q6_region: memory@4b000000 {
> +			no-map;

move the no-map after reg, to align with other entries.

> +			reg = <0x0 0x4b000000 0x0 0x5f00000>;
> +		};
> +
>   	};
>   
>   	firmware {
> @@ -117,6 +123,30 @@ scm {
>   		};
>   	};
>   

...

>   
> +		q6v5_wcss: remoteproc@cd00000 {
> +			compatible = "qcom,ipq8074-wcss-pil";
> +			reg = <0x0cd00000 0x4040>,
> +			      <0x004ab000 0x20>;
> +			reg-names = "qdsp6",
> +				    "rmb";
> +			qca,auto-restart;
> +			qca,extended-intc;
> +			interrupts-extended = <&intc 0 325 1>,


Use macros instead of open coding.

> +					      <&wcss_smp2p_in 0 0>,
> +					      <&wcss_smp2p_in 1 0>,
> +					      <&wcss_smp2p_in 2 0>,
> +					      <&wcss_smp2p_in 3 0>;
> +			interrupt-names = "wdog",
> +					  "fatal",
> +					  "ready",
> +					  "handover",
> +					  "stop-ack";
> +
> +			resets = <&gcc GCC_WCSSAON_RESET>,
> +				 <&gcc GCC_WCSS_BCR>,
> +				 <&gcc GCC_WCSS_Q6_BCR>;
> +
> +			reset-names = "wcss_aon_reset",
> +				      "wcss_reset",
> +				      "wcss_q6_reset";
> +
> +			clocks = <&gcc GCC_PRNG_AHB_CLK>;
> +			clock-names = "prng";
> +
> +			qcom,halt-regs = <&tcsr 0xa000 0xd000 0xe000>;
> +
> +			qcom,smem-states = <&wcss_smp2p_out 0>,
> +					   <&wcss_smp2p_out 1>;
> +			qcom,smem-state-names = "shutdown",
> +						"stop";
> +
> +			memory-region = <&q6_region>;
> +
> +			glink-edge {
> +				interrupts = <GIC_SPI 321 IRQ_TYPE_EDGE_RISING>;
> +				qcom,remote-pid = <1>;
> +				mboxes = <&apcs_glb 8>;
> +
> +				rpm_requests {
> +					qcom,glink-channels = "rpm_requests";
> +				};
> +			};
> +		};
> +
>   		pcie1: pcie@10000000 {
>   			compatible = "qcom,pcie-ipq8074";
>   			reg = <0x10000000 0xf1d>,

  parent reply	other threads:[~2024-06-21 16:10 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-21 11:46 [PATCH v9 0/8] remoteproc: qcom: q6v5-wcss: Add support for secure pil Gokul Sriram Palanisamy
2024-06-21 11:46 ` [PATCH v9 1/8] remoteproc: qcom: Add PRNG proxy clock Gokul Sriram Palanisamy
2024-06-21 15:09   ` Krzysztof Kozlowski
2024-06-25  4:25     ` Gokul Sriram P
2024-06-21 21:08   ` Dmitry Baryshkov
2024-06-25  5:33     ` Gokul Sriram P
2024-06-26 19:17       ` Dmitry Baryshkov
2024-06-27 10:01         ` Gokul Sriram P
2024-06-27 11:08           ` Dmitry Baryshkov
2024-06-27 11:29             ` Gokul Sriram P
2024-06-27 13:35               ` Dmitry Baryshkov
2024-06-21 11:46 ` [PATCH v9 2/8] remoteproc: qcom: Add secure PIL support Gokul Sriram Palanisamy
2024-06-21 21:17   ` Dmitry Baryshkov
2024-06-25  5:36     ` Gokul Sriram P
2024-06-21 11:46 ` [PATCH v9 3/8] remoteproc: qcom: Add support for split q6 + m3 wlan firmware Gokul Sriram Palanisamy
2024-06-27 11:11   ` Dmitry Baryshkov
2024-06-21 11:46 ` [PATCH v9 4/8] remoteproc: qcom: Add ssr subdevice identifier Gokul Sriram Palanisamy
2024-06-21 15:10   ` Krzysztof Kozlowski
     [not found]     ` <8adae0a7-d496-4c9f-ab0c-f162c06e90c4@quicinc.com>
2024-06-25  7:04       ` Krzysztof Kozlowski
2024-06-25  7:13         ` Dmitry Baryshkov
2024-06-21 21:23   ` Dmitry Baryshkov
2024-06-21 11:46 ` [PATCH v9 5/8] remoteproc: qcom: Update regmap offsets for halt register Gokul Sriram Palanisamy
2024-06-21 15:11   ` Krzysztof Kozlowski
2024-06-21 11:46 ` [PATCH v9 6/8] dt-bindings: clock: qcom: Add reset for WCSSAON Gokul Sriram Palanisamy
2024-06-21 15:12   ` Krzysztof Kozlowski
2024-06-21 16:17   ` Kathiravan Thirumoorthy
2024-06-21 11:46 ` [PATCH v9 7/8] clk: qcom: Add WCSSAON reset Gokul Sriram Palanisamy
2024-06-21 16:14   ` Kathiravan Thirumoorthy
2024-06-21 21:28   ` Dmitry Baryshkov
2024-06-21 11:46 ` [PATCH v9 8/8] arm64: dts: qcom: Enable Q6v5 WCSS for ipq8074 SoC Gokul Sriram Palanisamy
2024-06-21 15:14   ` Krzysztof Kozlowski
2024-06-21 16:09   ` Kathiravan Thirumoorthy [this message]
2024-06-27 12:42   ` kernel test robot
2024-06-28  2:47   ` kernel test robot
2024-06-28 21:12   ` kernel test robot
2024-06-21 21:22 ` [PATCH v9 0/8] remoteproc: qcom: q6v5-wcss: Add support for secure pil Dmitry Baryshkov
2024-06-21 21:24 ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0dee6b8-599f-4086-87d7-cc3750b46d0a@quicinc.com \
    --to=quic_kathirav@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gokulsri@codeaurora.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=ohad@wizery.com \
    --cc=quic_gokulsri@quicinc.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sricharan@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®