From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751454AbdKVFpp (ORCPT ); Wed, 22 Nov 2017 00:45:45 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:36410 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751079AbdKVFpk (ORCPT ); Wed, 22 Nov 2017 00:45:40 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9007260818 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=timur@codeaurora.org Subject: Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function To: Sinan Kaya , linux-pci@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bjorn Helgaas , open list References: <1511328675-21981-1-git-send-email-okaya@codeaurora.org> <1511328675-21981-31-git-send-email-okaya@codeaurora.org> From: Timur Tabi Message-ID: Date: Tue, 21 Nov 2017 23:45:37 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1511328675-21981-31-git-send-email-okaya@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/21/17 11:31 PM, Sinan Kaya wrote: > Use pci_get_domain_bus_and_slot() with a domain number of 0 where we can't > extract the domain number. Other places, use the actual domain number from > the device. > > Now that all users of pci_get_bus_and_slot() switched to > pci_get_domain_bus_and_slot(), it is now safe to remove this function. This doesn't really eliminate pci_get_bus_and_slot(), because it doesn't force developers to support non-zero domains. What's to stop a driver developer from doing this? #define pci_get_bus_and_slot(b, d) pci_get_domain_bus_and_slot(0, b, d) thereby completely ignoring what you're trying to do? -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.