From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33267378815 for ; Sun, 19 Apr 2026 07:19:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776583199; cv=none; b=Nl2BWt6qfA+ux/m4Sl0cGcnClY9VJHzKaiDMVYXDj4Nd7aWqy/DF4xMmLh6EM8rkY+G0NQmQE25hHFY/fF1r9OJnuY1C6yQbQGbZZXdPkCBDyBX04Lx5kRMlWpH493qPvgrA4R9d6gv82EKAAFacoi3caqiN+qgIIiufRWAJKBo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776583199; c=relaxed/simple; bh=yHU0KXsOgo76EVncDivnKe0OrmUXaQSwZ7RvlLdufV8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l6TUBypnnjXeYAwuGpr4mv5w+FwOZzTT++xMwcwsUcGiWdlk5PHyZ8j9kols5eB95gW0DAOvFkTtuVcCR+sDoZPseHcXyfzX0s8khIBs4MichC5Butb0c4V6TPzYU7W4egO/k+ZBGdCU1fr4y7kV1CkaxWrCMhPtc3uSMMTyWwE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LFULbpIq; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LFULbpIq" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-35d965648a2so1766282a91.0 for ; Sun, 19 Apr 2026 00:19:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776583197; x=1777187997; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NubENbVnw4RB0klzgk0+GOCS1Cv2Xg/qv0QNTz0zlFs=; b=LFULbpIqh6VgtH9OI08shhr6mUud9dndPkuDgAw8a+9SjercwMgS8RnP7QQrCZZfCz Qp2txmrFGKOpZUz8/kpA70UDm7oRKV2jJr9DH8aKZYX79ao8eY3qYbuKmUQQ3jZybBri F+UbVU7BadqBu6s+CR5t6vKPuigX4I/RWdKJEYbnk/fzw5DDwYDUesThVJWjMBi3VTPx Jc2sPGmb4MBWMnJnwshZ9490jkOMpEC491Q/7JzjZZQwJZ6ITMswICGo4/goPq5MrOqP xnnB/piMN9kFpMRVz5RTHTz3PmwUTHstalKLRP9l/9Nv6xOmquMo4KZhrXxa0ObxrYsl gjoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776583197; x=1777187997; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NubENbVnw4RB0klzgk0+GOCS1Cv2Xg/qv0QNTz0zlFs=; b=eBbPxgosKTSqWY2KYuv8iVuuXtJVPBBPctJhRh1RYQudMsv+8z/GLT52ubTHvenuVD FQ1Lzkn1jAOvkilxv9Z9oEGx+kpX2A0ar423D1ytfSWpLNbveJHnWIKQpeMrkyI6tDQo OyaWryQnUSjDTwA9dKkVRQZNk6dw4C80ST2B3GEGpORGD+BU4cjzbRVaEX37NNQ79rYO H3YbDEUn4jFRCPsQ0qs4zeOeCPKXs2CXl1NRTcV5t35gUGShV5skM2D+Uy8Dh8MjOUhO uSuy+oqp009+C+L6pX8wSAv+asiEQg9U8C/q1XxAOQa+KuCFXwNOm/qca+EhcTBT1278 XVIw== X-Forwarded-Encrypted: i=1; AFNElJ8JRWLZCmmMTek29xA0XxP70NK6mlj83lL/9d6odYm7NFdVfs+wG91uySd1TVmo3B5/HRxLIF6/2qNmaFM=@vger.kernel.org X-Gm-Message-State: AOJu0YxW6K473qVACxcjYR6ZTRpIbpVzIdJpTsHcRCnJLnzUtUL8lRlL 4Kv8oW14qHN1e39NArf+N0eWOkh4w/KKiFIUygYoYCwwRCXXEUnsTJbBHhMCJQ== X-Gm-Gg: AeBDiesOZpKEPZKFeB7NMYYRTqEf23QNGbU30JkiWgM7aYptOx8S5YXSVWndvBkMwvt WnhnrZKMaZHEgObnYZX0PASnWM7tzoZowpwv65MXlZk0SrLgiP0V4mZaZYFm1WDTTzHoUfEm1tX 4U9e2CeR+AGKM9UPI65OOserTBTgKEZ9Ne5nV5yZUDLvCl+ONNbSK/+5TiwC4tpJg4f4eQgEJGd At9Cen2ov1epx/JAD7IffR1ZnReqrIS8oF8665FL3CBWheJ5uuM71rSZlNI04UwcXKoV0ipYbxx JpkaTtrl7O1uZxhZLlRLSeRy3x/+Seso0rmVJUT0uhqcmprjCjHInAHGP6Ree/BAa0tWc1lyPr4 XDQ0FJFGq20OPBartsYNtjLgRLy7riTWp+DK9no/xd+/VprtWbkcrU9jSJOPivpaRaKNkn3w9iV ChJDqa/w1C0lRHT6pUiGwtskyArLLo/KpDNvxP X-Received: by 2002:a17:90b:5288:b0:359:fe72:3559 with SMTP id 98e67ed59e1d1-3614048b1aemr11300754a91.21.1776583197605; Sun, 19 Apr 2026 00:19:57 -0700 (PDT) Received: from gye-SER8.. ([1.243.227.27]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3614198f775sm7730486a91.16.2026.04.19.00.19.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Apr 2026 00:19:57 -0700 (PDT) From: Gyeyoung Baek To: Tomeu Vizoso , Boris Brezillon , Rob Herring , Steven Price , =?UTF-8?q?Adri=C3=A1n=20Larumbe?= Cc: Oded Gabbay , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Gyeyoung Baek , stable@vger.kernel.org Subject: [PATCH v1 1/2] accel/rocket: Fix prep_bo ioctl leaking positive return from dma_resv_wait_timeout() Date: Sun, 19 Apr 2026 16:17:15 +0900 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit dma_resv_wait_timeout() returns a positive 'remaining jiffies' value on success, 0 on timeout, and -errno on failure. rocket_ioctl_prep_bo() returns this 'long' result from an int-typed ioctl handler, so positive values reach userspace as bogus errors. Explicitly set ret to 0 on the success path. Fixes: 525ad89dd904 ("accel/rocket: Add IOCTLs for synchronizing memory accesses") Cc: stable@vger.kernel.org Signed-off-by: Gyeyoung Baek --- drivers/accel/rocket/rocket_gem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/accel/rocket/rocket_gem.c b/drivers/accel/rocket/rocket_gem.c index b6a385d2e..c80847192 100644 --- a/drivers/accel/rocket/rocket_gem.c +++ b/drivers/accel/rocket/rocket_gem.c @@ -145,6 +145,8 @@ int rocket_ioctl_prep_bo(struct drm_device *dev, void *data, struct drm_file *fi ret = dma_resv_wait_timeout(gem_obj->resv, DMA_RESV_USAGE_WRITE, true, timeout); if (!ret) ret = timeout ? -ETIMEDOUT : -EBUSY; + else if (ret > 0) + ret = 0; shmem_obj = &to_rocket_bo(gem_obj)->base; -- 2.43.0