From: Andrew Lunn <andrew@lunn.ch>
To: Roger Quadros <rogerq@kernel.org>
Cc: MD Danish Anwar <danishanwar@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Richard Cochran <richardcochran@gmail.com>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
vladimir.oltean@nxp.com, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org, srk@ti.com,
r-gunasekaran@ti.com, Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH net-next v2] net: ti: icssg_prueth: add TAPRIO offload support
Date: Thu, 21 Sep 2023 18:32:31 +0200 [thread overview]
Message-ID: <c0ec8d22-534b-4962-b5b2-ff6391b32b1b@lunn.ch> (raw)
In-Reply-To: <b3248b40-38a1-47b0-a61d-e81a451fa0a7@kernel.org>
> > + if (!netif_running(ndev)) {
> > + netdev_err(ndev, "interface is down, link speed unknown\n");
> > + return -ENETDOWN;
> > + }
>
> Do we really need this?
The error message suggests it is wrong anyway. netif_running() being
true means it is admin up. But the carrier might be down, and so the
link speed is unknown. So maybe this should be using netif_carrier_ok() ?
Andrew
next prev parent reply other threads:[~2023-09-21 20:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 7:00 MD Danish Anwar
2023-09-21 10:42 ` Roger Quadros
2023-09-21 16:32 ` Andrew Lunn [this message]
2023-09-21 16:35 ` Andrew Lunn
2023-09-22 7:05 ` MD Danish Anwar
2023-09-22 4:58 ` MD Danish Anwar
2023-09-22 10:40 ` Roger Quadros
2023-09-22 11:30 ` Anwar, Md Danish
2023-09-28 10:16 ` MD Danish Anwar
2023-09-21 20:14 ` Vinicius Costa Gomes
2023-09-27 6:19 ` MD Danish Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0ec8d22-534b-4962-b5b2-ff6391b32b1b@lunn.ch \
--to=andrew@lunn.ch \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=r-gunasekaran@ti.com \
--cc=richardcochran@gmail.com \
--cc=rogerq@kernel.org \
--cc=rogerq@ti.com \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®