mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Peter Griffin" <peter.griffin@linaro.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"André Draszik" <andre.draszik@linaro.org>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Sam Protsenko" <semen.protsenko@linaro.org>,
	"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
	"Chanwoo Choi" <cw00.choi@samsung.com>
Cc: Will McVicker <willmcvicker@google.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH v7 0/4] Implement hardware automatic clock gating (HWACG) for gs101
Date: Mon, 22 Dec 2025 12:50:10 +0100	[thread overview]
Message-ID: <c0eeae31-6951-47ca-8651-868db18d349e@kernel.org> (raw)
In-Reply-To: <20251222-automatic-clocks-v7-0-fec86fa89874@linaro.org>

On 22/12/2025 11:22, Peter Griffin wrote:
> Hi folks,
> 
> This series addresses an issue with Samsung Exynos based upstream clock driver
> whereby the upstream clock driver sets all the clock gates into "manual mode"
> (which uses a bit that is documented as reserved in the gate registers).
> 

Applied. There were several checkpatch notices/less important warnings
of which most were result of existing code but few were introduced.
Please be sure you do not introduce new warnings NEXT TIME.

Also, DTS cannot be in the middle of the patchset. It's almost always
wrong, like in this case as well. This was raised, also by me, multiple
times on the lists and it is explicitly documented in submitting
patches. Putting it in the middle suggests you try to fix up broken
unbisectable things by reordering patches, but you cannot. Things will
be broken anyway, because DTS ALWAYS goes separate (also documented in
maintainers profile).

Best regards,
Krzysztof

  parent reply	other threads:[~2025-12-22 11:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-22 10:22 Peter Griffin
2025-12-22 10:22 ` [PATCH v7 1/4] dt-bindings: clock: google,gs101-clock: add samsung,sysreg property as required Peter Griffin
2025-12-22 10:22 ` [PATCH v7 2/4] arm64: dts: exynos: gs101: add samsung,sysreg property to CMU nodes Peter Griffin
2025-12-22 10:22 ` [PATCH v7 3/4] clk: samsung: Implement automatic clock gating mode for CMUs Peter Griffin
2026-01-07  7:22   ` André Draszik
2026-01-07  9:27     ` Peter Griffin
2026-01-07 23:59   ` Marek Szyprowski
2026-01-08 10:55     ` André Draszik
2026-01-08 11:15       ` Peter Griffin
2025-12-22 10:22 ` [PATCH v7 4/4] clk: samsung: gs101: Enable auto_clock_gate mode for each gs101 CMU Peter Griffin
2025-12-22 11:50 ` Krzysztof Kozlowski [this message]
2026-01-06 20:03   ` [PATCH v7 0/4] Implement hardware automatic clock gating (HWACG) for gs101 Peter Griffin
2025-12-22 11:50 ` (subset) " Krzysztof Kozlowski
2025-12-22 11:51   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0eeae31-6951-47ca-8651-868db18d349e@kernel.org \
    --to=krzk@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=andre.draszik@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel-team@android.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@kernel.org \
    --cc=semen.protsenko@linaro.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=willmcvicker@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®