From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b3-smtp.messagingengine.com (fout-b3-smtp.messagingengine.com [202.12.124.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0E876F06B; Sat, 2 Nov 2024 02:15:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.146 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730513747; cv=none; b=f7V5zg99wvKFJAAN5XpoljZ3FkvhXoM5YTYgcwJePTIvPZR+Vmzb2RsIcxqxE5tTVYPX5v0uBuhAJxfCH+Nm0GFEl91irvtCV5SRctooRKcEQXDnuG9DoV4U9mFEgxBzDouEa024NU0CqWQHD1SSQKVMDwlzprGq4r3ZSV7uEBM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730513747; c=relaxed/simple; bh=4HRyW9usEgJivrqYSxIzLmFyzTbk3OkwzMVmJVuPG34=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=ii6MIRLp1BSV7/y4ePmAnD1+PWwFkM6RsQAiPYBYCvJK9RkMto37xYcJB0ZPUA9BKKvI8AH7ILoWHLkvmSgtJameLnsWw6aplGVw3JS8qP/iM+Y5v7fkkYAW+tKCpiqBrZ3I8vQ+EC6pwveVIRQnHLprKaviE39s770TkqU4us8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=squebb.ca; spf=pass smtp.mailfrom=squebb.ca; dkim=pass (2048-bit key) header.d=squebb.ca header.i=@squebb.ca header.b=EX5/LjnT; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=KO5VbYnB; arc=none smtp.client-ip=202.12.124.146 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=squebb.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=squebb.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=squebb.ca header.i=@squebb.ca header.b="EX5/LjnT"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="KO5VbYnB" Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfout.stl.internal (Postfix) with ESMTP id 49952114007C; Fri, 1 Nov 2024 22:15:44 -0400 (EDT) Received: from phl-imap-10 ([10.202.2.85]) by phl-compute-02.internal (MEProxy); Fri, 01 Nov 2024 22:15:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=squebb.ca; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1730513744; x=1730600144; bh=JmyUrRjBzHgkkvAgRz/uOrtHBYfuEIrZL234zQOVTFc=; b= EX5/LjnTeE95z0qucJ44FBtGT7yyGwr63CLMmdXfXu/gOCAXRcmEzQBgA1TH+cSJ 22XnyCgIyNigSf8MnyFQ55DU/YJWP0TMIczCv95KEND0RirbOoe/36sAAdQd9pg5 ph0nd3lhXILA1DRoqDQf6Bg1iGmV6yhvc6lcYguGEyH3iOaKpoS8Zjg3OYUjWO5Q fLsa+geaWdhIwqtzK1GggK1Fhqy3prNv0V5UlcmAgLbjnWqbynG8ZPqbdIW8MmJZ 7OE1FJKtD8mte7CXffqhenH7PMPTzX3UcgEem8AEahM1o2yQ7g+GHmxh60OqgV2p 1p0z10G1pSZREza4Vs3qsQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1730513744; x= 1730600144; bh=JmyUrRjBzHgkkvAgRz/uOrtHBYfuEIrZL234zQOVTFc=; b=K O5VbYnBtDvjRCxlge1nLiBEVKyHB5jKozzxnb6fqSTa4NFFnZK+MAyQEgTs9uM0b N6oxasnl+fZXvoXMtnBDTlE5kwXR99gyTUEiVd+9xiUSe5YYj3CWCyNB3ALphk3Z vxqMiqADxxN5Zo8COgLV+LnUt2QHBCeltybLINXP1a7+HaNjlBzZfPvamjxnTgt9 0EU0uYKst83FG8vEpsvf/vKPkig8A82kbmDO9JOkcZ79QtJ4Z7NppqAHybED5LVd esa2wg4BOwuUBl+JjzWX5OXqljR0o8EtWSvSL0vv9mNnsvUYNr8zaYKDlWHmSIr1 rmLHTCI1zzm1YJNr+dZ7w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdeltddggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddt necuhfhrohhmpedfofgrrhhkucfrvggrrhhsohhnfdcuoehmphgvrghrshhonhdqlhgvnh hovhhosehsqhhuvggssgdrtggrqeenucggtffrrghtthgvrhhnpefhuedvheetgeehtdeh tdevheduvdejjefggfeijedvgeekhfefleehkeehvdffheenucevlhhushhtvghrufhiii gvpeeinecurfgrrhgrmhepmhgrihhlfhhrohhmpehmphgvrghrshhonhdqlhgvnhhovhho sehsqhhuvggssgdrtggrpdhnsggprhgtphhtthhopedvuddpmhhouggvpehsmhhtphhouh htpdhrtghpthhtohepshhhhigrmhdqshhunhgurghrrdhsqdhksegrmhgurdgtohhmpdhr tghpthhtohepmhgrrhhiohdrlhhimhhonhgtihgvlhhlohesrghmugdrtghomhdprhgtph htthhopehikhgvrdhprghnsegtrghnohhnihgtrghlrdgtohhmpdhrtghpthhtoheprghl vgigsggvlhhmgeeksehgmhgrihhlrdgtohhmpdhrtghpthhtoheptghorhgvnhhtihhnrd gthhgrrhihsehgmhgrihhlrdgtohhmpdhrtghpthhtoheplhhuiihmrgigihhmihhlihgr nhesghhmrghilhdrtghomhdprhgtphhtthhopehhmhhhsehhmhhhrdgvnhhgrdgsrhdprh gtphhtthhopehsohihvghrsehirhhlrdhhuhdprhgtphhtthhopehlvghnsgeskhgvrhhn vghlrdhorhhg X-ME-Proxy: Feedback-ID: ibe194615:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 8686A3C0066; Fri, 1 Nov 2024 22:15:43 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Fri, 01 Nov 2024 22:15:23 -0400 From: "Mark Pearson" To: "Limonciello, Mario" , "Hans de Goede" , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= Cc: "Rafael J. Wysocki" , "Len Brown" , "Maximilian Luz" , "Lee Chun-Yi" , "Shyam Sundar S K" , "Corentin Chary" , "Luke D . Jones" , "Ike Panhc" , "Henrique de Moraes Holschuh" , "Alexis Belmonte" , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , "Ai Chao" , "Gergo Koteles" , "open list" , "linux-acpi@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "open list:THINKPAD ACPI EXTRAS DRIVER" , "Matthew Schwartz" Message-Id: In-Reply-To: <20241031040952.109057-18-mario.limonciello@amd.com> References: <20241031040952.109057-1-mario.limonciello@amd.com> <20241031040952.109057-18-mario.limonciello@amd.com> Subject: Re: [PATCH v3 17/22] ACPI: platform_profile: Add concept of a "custom" profile Content-Type: text/plain Content-Transfer-Encoding: 7bit On Thu, Oct 31, 2024, at 12:09 AM, Mario Limonciello wrote: > When two profile handlers don't agree on the current profile it's ambiguous > what to show to the legacy sysfs interface. > > Add a "custom" profile string that userspace will be able to distinguish > this situation when using the legacy sysfs interface. > > Signed-off-by: Mario Limonciello > --- > drivers/acpi/platform_profile.c | 1 + > include/linux/platform_profile.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c > index c2bb325ba531c..3128bd16615b6 100644 > --- a/drivers/acpi/platform_profile.c > +++ b/drivers/acpi/platform_profile.c > @@ -20,6 +20,7 @@ static const char * const profile_names[] = { > [PLATFORM_PROFILE_BALANCED] = "balanced", > [PLATFORM_PROFILE_BALANCED_PERFORMANCE] = "balanced-performance", > [PLATFORM_PROFILE_PERFORMANCE] = "performance", > + [PLATFORM_PROFILE_CUSTOM] = "custom", > }; > static_assert(ARRAY_SIZE(profile_names) == PLATFORM_PROFILE_LAST); > > diff --git a/include/linux/platform_profile.h b/include/linux/platform_profile.h > index 6aad98f4abaf4..da009c8a402c9 100644 > --- a/include/linux/platform_profile.h > +++ b/include/linux/platform_profile.h > @@ -23,6 +23,7 @@ enum platform_profile_option { > PLATFORM_PROFILE_BALANCED, > PLATFORM_PROFILE_BALANCED_PERFORMANCE, > PLATFORM_PROFILE_PERFORMANCE, > + PLATFORM_PROFILE_CUSTOM, > PLATFORM_PROFILE_LAST, /*must always be last */ > }; > > -- > 2.43.0 Looks good to me. Reviewed-by: Mark Pearson Mark